156 Commits

Author SHA1 Message Date
Urse Daniel
4f8aa8d4be
added indeterminate state for the 'select all' checkbox + unit test. (#5590) 2020-04-06 13:01:03 +01:00
Urse Daniel
6d406d8a7d
[ADF-4264] Fixed the breadcrumb when changing to custom site in node selector (#5589)
* unit test for veryfing if changing to a custom site the current breadcrumb folder is the title of the site.

* fixed the problem when changing to a custom site the breadcrumb current folder title is not changing. fixed the issue when navigating inside a node after changing to a custom site the path to the root in the breadcrumb was not the correct path.

* updated the styling for the data rows to match the styling of the breadcrumb

* if there is an error the loader should stop not only if there is a message. updated to fix the node-selector site problem when adding a non existing site, the loader would previously keep spinning even though in console was thrown an error but the clients never had an UI update about the issue.
2020-04-03 10:55:51 +01:00
Urse Daniel
8f3f5b3879
[ADF-4933] Adding keydown event on data row to simulate double click when pressing 'enter' key (#5564)
* changing the event on row from keyup to keydown to fix the issue of reopening the file after closing ussing only keyboard (opening and closing the file by enter)

* Reverting the 'onRowKeyDown' to not make a breaking change and added a new method to handle the opening file using 'enter' key

* Added unit test - it should emit double click if keydown "enter key" on row

* Small changes for clean coding
2020-03-27 16:33:44 +00:00
Denys Vuika
fc6a80c45a
[ACA-2566][ACA-2567] permissions a11y fixes (#5560)
* fix layout and a11y, cleanup html

* fix sorting announcer

* fix i18n issue for Actions column
2020-03-19 16:47:24 +00:00
Eugenio Romano
a70883378a
[AAE-2107] Move e2e to Unit test (#5535)
* [AAE-2107] Move e2e to Unit test

* * fixed namings

* * more unit test added

* * minor changes
2020-03-05 16:47:59 +00:00
Eugenio Romano
2d0b571875
remove not needed spaces (#5495)
* remove not usefull spaces

* increase timeout

* increase timeout

* fix
2020-02-23 17:00:16 +00:00
Eugenio Romano
1847768b56
[AAE-1848] fix kebab case files and add tlsint rule (#5481)
* fix kebab case files and add tlsint rule

* headless

* m 2 in e2e

* download file in headless chrome

* fix budget

* fix import

* fix import
2020-02-20 21:08:42 +00:00
dhrn
ffc17157a4
[AAE-1831] DataTable Unit test (#5475) 2020-02-14 14:32:40 +00:00
Denys Vuika
a0926a38d8
Minor code and style fixes (#5398)
* type fixes

* import fixes

* fix typos

* fix warning for private props that init in ctor only

* typing fixes

* typing fixes

* style cleanup

* fix test template
2020-02-09 22:03:32 +00:00
Mark Steadman
3459c98bd0 [ACA-2602]- Datatable - Selected state properly announced (#5459)
* chore: selected row now announces state

* chore: removal of tabindex on icon button
2020-02-09 21:22:56 +00:00
Adina Parpalita
7d04297e6e
[ADF-5073] Sorted column header is incorrectly read by a screen reader (#5449)
* translate column title

* remove forgotten empty lines

* enable screenshots for investigating weirdly failing tests

* reenable the stages
2020-02-06 13:54:58 +00:00
Denys Vuika
d09373501f
[AAE-1564][DW-1654] improved datatable schema (#5408)
* improved datatable schema

* collect all runtime columns
2020-01-28 14:08:18 +00:00
Eugenio Romano
3767ecb91c
chore: hiding icon in table from SR users (#5403)
Co-authored-by: Mark Steadman <47225088+Steady5063@users.noreply.github.com>
2020-01-25 16:56:56 +01:00
Eugenio Romano
142e142ccb
[ACA-2567] - sortable (#5402)
* chore: aca-2567 accessibility for sortable columns

* chore: sortable table accessibility update

* fix: refactor sortable table headers into function

* chore: updated sort by text

Co-authored-by: Mark Steadman <47225088+Steady5063@users.noreply.github.com>
2020-01-25 16:13:30 +01:00
pionnegru
10b024e53a tests 2019-12-02 19:17:33 +02:00
pionnegru
e4ae7b2466 enable focus from column definititon 2019-12-02 19:17:31 +02:00
Silviu Popa
202764631a [ADF-5002] Datatable - fix focus selection for grid list (#5268)
* [ADF-5002] Datatable - fix focus selection for grid list

* fix faling e2e
2019-11-20 15:31:19 +00:00
Suzana Dirla
f0ac4b19ad [ADF-4986] Move or copy - Empty cells should not receive focus (#5226) 2019-11-08 16:02:42 +02:00
Cilibiu Bogdan
040fc52724 [ADF-2990] Datatable - access header row via keyboard (#5206)
* header row as adf-datatable-row

* remove tabindex if header is hidden

* adjust logic if no row data is passed

* skip row focus if disabled

* set active row index on header interaction

* take in account header row

* fix header row and cells focus

* tests

* fix reference

* fix tests
2019-11-04 08:08:15 +00:00
Cilibiu Bogdan
af6bd0892c [ADF-2990] Datatable - row navigation (#5198)
* datatable row component

* add to module

* implement datatable row component

* use FocusKeyManager for arrows navigation

* tests

* prevent screen reader to announce undefined value

* prevent from bubbling up

* fix unit test

* fix row locator

* fix locator reference

* fix row reference locators

* fix locator xpath
2019-10-30 07:39:43 +00:00
Suzana Dirla
6119ce83de [ADF-4966] Keep table headers - visually hidden when showHeader false (#5170)
* [ADF-4966] Move or copy - Add table headers - visually hidden

- needed by screen readers

* [ADF-4966] use automatic column header translation

* [ADF-4966] move the fix to the datatable component

-improve accessibility - keep table headers-but visually hidden for showHeader false

* [ADF-4966] code review change

* [ADF-4966] fix array shallow copy on failing e2e-test

* [ADF-4966] improve accessibility only for list display

- fixes failing test
2019-10-25 15:46:45 +01:00
dhrn
baa0d6da30 [ADF-4947] Array type supported in data table columns (#5165)
* [WIP] [ADF-4947] Array type supported in data table columns

* * removed resolver for aria label

* * process services feature added

* * fixed docs
2019-10-18 00:01:52 +01:00
Denys Vuika
d7ab0417b8
[AAE-622] No implicit returns (#5157)
* enable noImplicitReturns rule

* type fixes

* fix return types

* fix return value

* fix tests

* fix visibility service

* update tests

* add missing types

* fix test
2019-10-17 09:35:39 +01:00
davidcanonieto
47ec01555a [ADF-4893] Fix visibility condition in datatable action menu (#5088)
* [ADF-4893] Fix visibility condition in datatable action menu

* Add filtering for when menu cache is disabled

* Fix unit test and improve code

* Fix linting

* Fix linting

* Add missing return type
2019-10-14 15:28:24 +01:00
Cilibiu Bogdan
9f22cb5cc7 fix focus outline (#5115) 2019-09-30 14:19:22 +01:00
Eugenio Romano
3dc92beeb9
Review documentation plus some tools fix (#5100)
* review 3.5.0 doc

* fix documentation

* fix documentation

* fix documentation
2019-09-26 10:27:04 +01:00
davidcanonieto
6ec6be36d5 [ADF-4913] Fix Gallery View in datatable Component (#5101) 2019-09-26 08:41:29 +01:00
Denys Vuika
90b2cee70d
[ADF-4894] Json editor dialog (#5082)
* move download-zip to its own folder

* json dialog

* update docs

* update test

* disable e2e test

* json widget for the Form

* remove deprecated test

* fix tests, update display text name
2019-09-20 07:26:37 +01:00
Cilibiu Bogdan
d5b4caa5ed [ADF-4892] DocumentList - set appropriate column aria-sort state (#5079)
* set specific aria-sort state

* return false when table has no sorting

* move logic to component

* aria sort method

* tests
2019-09-18 15:21:35 +01:00
Cilibiu Bogdan
5b11e52903 [ADF-4888] DocumentList - cell header title is announced over cell value (#5068)
* fix focus outline

* focus on cell values

* focus on size value if defined

* row actions menu aria-label
2019-09-12 15:04:43 +01:00
Cilibiu Bogdan
bf6889ee54 [ADF-4831] DocumentList - filetype alternative text is not meaningful (#4998)
* filetype alternative text

* icons text translation key

* icon text accessibility translation

* fix e2e

* add miscellaneous file type
2019-09-05 11:50:28 +01:00
Denys Vuika
edc0945f39 fix "ng lint" command (#5012)
* update to latest js-api

* fix the "ng lint" command

* fix linting issues

* fix lint issues

* lint fixes

* code fixes

* fix html

* fix html

* update tests

* test fixes

* update tests

* fix tests and api

* fix code
2019-08-29 16:35:30 +01:00
Suzana Dirla
bfc3f30674 [ADF-4846] Move to ADF the style overrides from ACA (#5016)
* [ADF-4846] add $data-table-cell-link-color variable

- move style fix needed on ACA to ADF

* [ADF-4846] add $adf-permission-list-width variable

- moved style fix for adf-permission-lists from ACA to ADF
2019-08-27 14:56:01 +02:00
Cilibiu Bogdan
9960a37e9a add aria label and selected (#4999) 2019-08-19 22:53:25 +02:00
Cilibiu Bogdan
f5c5e7cf9e add aria-sort (#4997) 2019-08-19 11:33:48 +01:00
Denys Vuika
1abb9bfc89 [ADF-4745] memory leak fixes (#4931)
* fix app-layout component

* fix card-view component

* fix cloud-layout service

* code fixes

* code fixes

* even more fixes

* even more fixes

* lint fixes

* test fixes

* fix code

* remove useless pipes

* fix code owners

* enable spellcheck for cloud components

* update test

* update test
2019-07-16 15:56:00 +01:00
Suzana Dirla
a4fc53a742 [ADF-4708] fileSize header is now left aligned with bottom cells (#4902) 2019-07-05 14:52:39 +01:00
davidcanonieto
5c07d5b3e6 [ADF-4457] StorageService should be independent of AppConfigService (#4712)
* [ADF-4457] StorageService should be independent of AppConfigService

* [ADF-4457] Fix e2e tests

* [ADF-4457] Fix e2e tests

* [ADF-4457] Improve storage service workflow

* Fix linting

* Fix unit tests

* Fix e2e test

* Add missing class to constructor

* Fix e2e test

* Rebase branch

* Improve unit test

* fix test
2019-06-25 16:21:13 +01:00
Eugenio Romano
f861b94de4
[Staging-branch] 3.4.0 (#4839)
* next 3.4.0

* next 3.4.0

* [ADF-4426] Move CSS overrides from ACA to ADF - 2nd round (#4837)

* [ADF-4426] align toolbar icon color with design

* [ADF-4426] clean-up style - it is never applied

* [ADF-4426] display title for name location cell - useful for long names

* [ADF-4426] move content-node-selector cell fix from ACA

- fixes https://github.com/Alfresco/alfresco-ng2-components/issues/4686

* [ADF-4426] move content-node-selector cell fix from ACA

- fixes https://github.com/Alfresco/alfresco-ng2-components/issues/4686

* [ADF-4426] move image width fix from ACA

* [ADF-4426] allow more customization of data-table borders

* [ADF-4426] move fix from ACA

[ACA-2363] fixes issue with text being visible underneath the info drawer

* [ADF-4426] get adf-datatable-link style from ACA

* [ADF-4426] allow set of DL selected row icon color

* [ADF-4426] allow more document list customization

- code moved from ACA
- more css variables
- removed non used and duplicated outline styles
- some code clean-up...

* [ADF-4635] The Status drop-down is looking different for Processes than for Tasks (#4822)
2019-06-20 12:32:41 +01:00
Cilibiu Bogdan
4603cef19e [ADF-4667] Document list - sorting icon RTL fix (#4848)
* sorting icon RTL fix

* single quotes over double quotes

* overspecify position
2019-06-14 10:04:59 +01:00
davidcanonieto
7497822a46 [ADF-4342] Create localized pipe and centralize date format (#4813)
* [ADF-4342] Date Format defined in app config

* [ADF-4342] Create localized pipe and centralize date format

* Add unit test for new date pipe

* Add info internationalization docs

* Fix lining

* Fix linting

* Fix date pipe unit test

* [ADF-4342] Add supported language files

* Fix e2e tests
2019-06-11 09:35:35 +01:00
davidcanonieto
c85df84a01 [ADF-4636][ADF-4137][ADF-4596] Datatable and Assignee bugs (#4832) 2019-06-11 00:35:02 +01:00
arditdomi
6897f20954 [ADF-4466] Fix alignment issues - IE11 (#4772)
* [ADF-4466] Fix alignment issues - IE11

* [ADF-4466] Fix implementation from demo shell specific to generic

* [ADF-4466] Remove unused query for IE11
2019-05-24 16:41:19 +01:00
Silviu Popa
26a495c95d [ADF-4588] Datatable - fix copy content tooltip for ellipsis cell (#4751)
* [ADF-4588] - remove overflow from ellipsis class

* [ADF-4588] - fix css
2019-05-22 10:34:39 +01:00
davidcanonieto
fc9f04c6c6 [ADF-4498] Disable Sticky header on Datatable if header is not visible (#4701)
* [ADF-4498] Disable Sticky header on Datatable if header is not visible

* [ADF-4498] Improve flag check
2019-05-13 07:02:36 +01:00
davidcanonieto
d6719c0b57 [ADF-4478] Fix layout container and empty template (#4683) 2019-05-02 15:00:09 +01:00
Denys Vuika
55113f37b6 [ADF-4444] drag and drop fixes (#4674)
* more granular control over drag and drop

* fix performance, internal drop-zone directive
2019-04-30 14:53:36 +01:00
arditdomi
54a2b14285 [ADF-4339] Fix documentList and ContentServices UI for IE11 (#4660)
* [ADF-4339] Fix documentList and ContentServices UI for IE11

* [ADF-4339] Fixed syntax mistake
2019-04-29 11:20:09 +01:00
Eugenio Romano
f94eb5872a
[ADF-4405] [ADF-4423] Fix clipboard directive on json cell (#4643)
* [ADF-4405] [ADF-4423] Fix clipboard directive on json cell

* [ADF-4405] Fix unit tests

* [ADF-4405] Fix e2e test
2019-04-25 19:49:38 +01:00
Eugenio Romano
d427e06136
Revert "[ADF-4405] [ADF-4423] Fix clipboard directive on json cell (#4623)" (#4642)
This reverts commit 630b1043a96e283403e35826e299b5cd1cd6d11d.
2019-04-23 14:30:08 +01:00