diff --git a/engines/base/src/main/java/org/alfresco/transform/base/TransformManager.java b/engines/base/src/main/java/org/alfresco/transform/base/TransformManager.java index 66560209..680e3195 100644 --- a/engines/base/src/main/java/org/alfresco/transform/base/TransformManager.java +++ b/engines/base/src/main/java/org/alfresco/transform/base/TransformManager.java @@ -38,7 +38,8 @@ public interface TransformManager { /** * Allows a {@link CustomTransformer} to use a local source {@code File} rather than the supplied {@code InputStream}. - * The file will be deleted once the request is completed. + * The file will be deleted once the request is completed. To avoid creating extra files, if a File has already + * been created by the base t-engine, it is returned. * If possible this method should be avoided as it is better not to leave content on disk. * @throws IllegalStateException if this method has already been called. */ @@ -46,14 +47,14 @@ public interface TransformManager /** * Allows a {@link CustomTransformer} to use a local target {@code File} rather than the supplied {@code OutputStream}. - * The file will be deleted once the request is completed. + * The file will be deleted once the request is completed. To avoid creating extra files, if a File has already + * been created by the base t-engine, it is returned. * If possible this method should be avoided as it is better not to leave content on disk. * @throws IllegalStateException if this method has already been called. A call to {@link #respondWithFragment(Integer)} * allows the method to be called again. */ File createTargetFile(); - // TODO: Do we want to support the following? /** * Allows a single transform request to have multiple transform responses. For example images from a video at * different time offsets or different pages of a document. Following a call to this method a transform response is diff --git a/engines/base/src/main/java/org/alfresco/transform/base/metadataExtractors/AbstractMetadataExtractor.java b/engines/base/src/main/java/org/alfresco/transform/base/metadataExtractors/AbstractMetadataExtractor.java index 9ed892bc..7d765f92 100644 --- a/engines/base/src/main/java/org/alfresco/transform/base/metadataExtractors/AbstractMetadataExtractor.java +++ b/engines/base/src/main/java/org/alfresco/transform/base/metadataExtractors/AbstractMetadataExtractor.java @@ -33,7 +33,6 @@ import org.alfresco.transform.base.CustomTransformer; import org.alfresco.transform.base.TransformManager; import org.slf4j.Logger; -import java.io.File; import java.io.IOException; import java.io.InputStream; import java.io.OutputStream; @@ -64,19 +63,17 @@ import static org.alfresco.transform.base.metadataExtractors.AbstractMetadataExt * * The transform results in a Map of extracted properties encoded as json being returned to the content repository. * * To support the same functionality as metadata extractors configured inside the content repository, - * extra key value pairs may be returned from {@link #extractMetadata}. These are: + * extra key value pairs may be returned from {@link #extractMetadata(String, InputStream, String, OutputStream, Map, TransformManager)}. + * These are: *