From 87a5e8a480f5bea20ecdaad815c7a89b8d7dba52 Mon Sep 17 00:00:00 2001 From: alandavis Date: Mon, 18 Jul 2022 13:32:48 +0100 Subject: [PATCH] Save point: [skip ci] * minor --- .../org/alfresco/transform/base/TransformController.java | 4 +--- .../base/TransformControllerWithSingleEngineTest.java | 6 +++--- 2 files changed, 4 insertions(+), 6 deletions(-) diff --git a/engines/base/src/main/java/org/alfresco/transform/base/TransformController.java b/engines/base/src/main/java/org/alfresco/transform/base/TransformController.java index 3a958807..90e75641 100644 --- a/engines/base/src/main/java/org/alfresco/transform/base/TransformController.java +++ b/engines/base/src/main/java/org/alfresco/transform/base/TransformController.java @@ -33,9 +33,7 @@ import org.alfresco.transform.config.TransformConfig; import org.alfresco.transform.registry.TransformServiceRegistry; import org.slf4j.Logger; import org.slf4j.LoggerFactory; -import org.springframework.beans.TypeMismatchException; import org.springframework.beans.factory.annotation.Autowired; -import org.springframework.beans.factory.annotation.Value; import org.springframework.boot.context.event.ApplicationReadyEvent; import org.springframework.context.event.EventListener; import org.springframework.http.ResponseEntity; @@ -222,7 +220,7 @@ public class TransformController targetMimetype = overrideMimetypeFromExtension(origRequestParameters, TARGET_MIMETYPE, targetMimetype); origRequestParameters.forEach((name, value) -> { - if (name.startsWith("value") == false) + if (!name.startsWith("value")) { if (name.startsWith("name")) { diff --git a/engines/base/src/test/java/org/alfresco/transform/base/TransformControllerWithSingleEngineTest.java b/engines/base/src/test/java/org/alfresco/transform/base/TransformControllerWithSingleEngineTest.java index cef3874b..eb00270d 100644 --- a/engines/base/src/test/java/org/alfresco/transform/base/TransformControllerWithSingleEngineTest.java +++ b/engines/base/src/test/java/org/alfresco/transform/base/TransformControllerWithSingleEngineTest.java @@ -103,7 +103,7 @@ public class TransformControllerWithSingleEngineTest private String coreVersion; @Test - public void initEngine() throws Exception + public void testInitEngine() throws Exception { assertEquals(TestTransformEngineTwoTransformers.class.getSimpleName(), transformController.transformEngine.getClass().getSimpleName()); @@ -111,7 +111,7 @@ public class TransformControllerWithSingleEngineTest } @Test - public void startupLogsIncludeEngineMessages() throws Exception + public void testStartupLogsIncludeEngineMessages() { StringJoiner controllerLogMessages = getLogMessagesFor(TransformController.class); @@ -148,7 +148,7 @@ public class TransformControllerWithSingleEngineTest } @Test - public void versionEndpointIncludesAvailable() throws Exception + public void testVersionEndpointIncludesAvailable() throws Exception { mockMvc.perform(MockMvcRequestBuilders.get(ENDPOINT_VERSION)) .andExpect(status().isOk())