[ACS-4460] MtlsTestUtils simplify methods

This commit is contained in:
kcichonczyk 2023-03-13 20:56:44 +01:00
parent 3706bef72b
commit ad0d4c68f0
3 changed files with 13 additions and 6 deletions

View File

@ -62,4 +62,13 @@ public class MtlsTestUtils {
} }
return new RestTemplate(requestFactory); return new RestTemplate(requestFactory);
} }
public static RestTemplate getRestTemplate()
{
return MtlsTestUtils.isMtlsEnabled() ? MtlsTestUtils.restTemplateWithMtls() : new RestTemplate();
}
public static CloseableHttpClient getHttpClient() throws UnrecoverableKeyException, CertificateException, NoSuchAlgorithmException, KeyStoreException, IOException, KeyManagementException {
return MtlsTestUtils.isMtlsEnabled() ? MtlsTestUtils.httpClientWithMtls() : HttpClients.createDefault();
}
} }

View File

@ -28,7 +28,7 @@ import org.springframework.web.client.RestTemplate;
*/ */
public class HttpClient public class HttpClient
{ {
private static final RestTemplate REST_TEMPLATE = MtlsTestUtils.isMtlsEnabled() ? MtlsTestUtils.restTemplateWithMtls() : new RestTemplate(); private static final RestTemplate REST_TEMPLATE = MtlsTestUtils.getRestTemplate();
public static ResponseEntity<Resource> sendTRequest( public static ResponseEntity<Resource> sendTRequest(
final String engineUrl, final String sourceFile, final String engineUrl, final String sourceFile,

View File

@ -32,7 +32,6 @@ import org.apache.http.entity.mime.HttpMultipartMode;
import org.apache.http.entity.mime.MultipartEntityBuilder; import org.apache.http.entity.mime.MultipartEntityBuilder;
import org.apache.http.entity.mime.content.FileBody; import org.apache.http.entity.mime.content.FileBody;
import org.apache.http.impl.client.CloseableHttpClient; import org.apache.http.impl.client.CloseableHttpClient;
import org.apache.http.impl.client.HttpClients;
import org.apache.http.util.EntityUtils; import org.apache.http.util.EntityUtils;
import org.slf4j.LoggerFactory; import org.slf4j.LoggerFactory;
@ -76,7 +75,7 @@ public class SfsClient
.addPart("file", new FileBody(file, ContentType.DEFAULT_BINARY)) .addPart("file", new FileBody(file, ContentType.DEFAULT_BINARY))
.build()); .build());
try (CloseableHttpClient client = MtlsTestUtils.isMtlsEnabled() ? MtlsTestUtils.httpClientWithMtls() : HttpClients.createDefault()) try (CloseableHttpClient client = MtlsTestUtils.getHttpClient())
{ {
final HttpResponse response = client.execute(post); final HttpResponse response = client.execute(post);
int status = response.getStatusLine().getStatusCode(); int status = response.getStatusLine().getStatusCode();
@ -135,8 +134,7 @@ public class SfsClient
sfsBaseUrl+"/alfresco/api/-default-/private/sfs/versions/1/file/{0}", sfsBaseUrl+"/alfresco/api/-default-/private/sfs/versions/1/file/{0}",
uuid)); uuid));
try (CloseableHttpClient client = MtlsTestUtils.isMtlsEnabled() ? try (CloseableHttpClient client = MtlsTestUtils.getHttpClient())
MtlsTestUtils.httpClientWithMtls() : HttpClients.createDefault())
{ {
final HttpResponse response = client.execute(head); final HttpResponse response = client.execute(head);
final int status = response.getStatusLine().getStatusCode(); final int status = response.getStatusLine().getStatusCode();
@ -155,7 +153,7 @@ public class SfsClient
sfsBaseUrl+"/alfresco/api/-default-/private/sfs/versions/1/file/{0}", sfsBaseUrl+"/alfresco/api/-default-/private/sfs/versions/1/file/{0}",
uuid)); uuid));
try (CloseableHttpClient client = HttpClients.createDefault()) try (CloseableHttpClient client = MtlsTestUtils.getHttpClient())
{ {
final HttpResponse response = client.execute(get); final HttpResponse response = client.execute(get);
final int status = response.getStatusLine().getStatusCode(); final int status = response.getStatusLine().getStatusCode();