Refactor Tika Controller (#415)

Allows for object creation to be done on instatiation, instead of first transform call.
This commit is contained in:
David Edwards 2021-06-11 21:07:11 +01:00 committed by GitHub
parent 08a9c7f28d
commit f831c46672
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -68,11 +68,13 @@ public class TikaController extends AbstractTransformerController
{ {
private static final Logger logger = LoggerFactory.getLogger(TikaController.class); private static final Logger logger = LoggerFactory.getLogger(TikaController.class);
@Value("${transform.core.tika.pdfBox.notExtractBookmarksTextDefault:false}")
private boolean notExtractBookmarksTextDefault;
private TikaJavaExecutor javaExecutor; private TikaJavaExecutor javaExecutor;
public TikaController(@Value("${transform.core.tika.pdfBox.notExtractBookmarksTextDefault:false}") boolean notExtractBookmarksTextDefault)
{
javaExecutor= new TikaJavaExecutor(notExtractBookmarksTextDefault);
}
@Override @Override
public String getTransformerName() public String getTransformerName()
{ {
@ -106,15 +108,6 @@ public class TikaController extends AbstractTransformerController
Map<String, String> transformOptions, File sourceFile, File targetFile) Map<String, String> transformOptions, File sourceFile, File targetFile)
{ {
transformOptions.put(TRANSFORM_NAME_PARAMETER, transformName); transformOptions.put(TRANSFORM_NAME_PARAMETER, transformName);
getJavaExecutor().transform(sourceMimetype, targetMimetype, transformOptions, sourceFile, targetFile); javaExecutor.transform(sourceMimetype, targetMimetype, transformOptions, sourceFile, targetFile);
}
private TikaJavaExecutor getJavaExecutor()
{
if(javaExecutor==null)
{
javaExecutor = new TikaJavaExecutor(notExtractBookmarksTextDefault);
}
return javaExecutor;
} }
} }