v2.0.10 pom

pom.xml

@@ -6,7 +6,7 @@
 	
 	<groupId>com.inteligr8</groupId>
 	<artifactId>common-rest-client</artifactId>
-	<version>2.0.8</version>
+	<version>2.0.10</version>
 	<packaging>jar</packaging>
 
 	<name>ReST API Client for Java</name>
@@ -74,6 +74,11 @@
 			<artifactId>jackson-datatype-jsr310</artifactId>
 			<version>${jackson.version}</version>
 		</dependency>
+		<dependency>
+			<groupId>org.apache.commons</groupId>
+			<artifactId>commons-lang3</artifactId>
+			<version>3.14.0</version>
+		</dependency>
 		<dependency>
 			<groupId>org.slf4j</groupId>
 			<artifactId>slf4j-api</artifactId>

src/main/java/com/inteligr8/rs/BasicAuthorizationFilter.java

@@ -20,6 +20,8 @@ import java.util.Base64;
 import javax.ws.rs.client.ClientRequestContext;
 import javax.ws.rs.core.HttpHeaders;
 
+import org.apache.commons.lang3.StringUtils;
+
 /**
  * This class implements a simple 2-credential (username & password) based
  * authorization filter.
@@ -36,8 +38,8 @@ public class BasicAuthorizationFilter implements AuthorizationFilter {
 	 * @param password A password or secret key.
 	 */
 	public BasicAuthorizationFilter(String username, String password) {
-		this.username = username;
-		this.password = password;
+		this.username = StringUtils.trimToNull(username);
+		this.password = StringUtils.trimToNull(password);
 	}
 	
 	/**

src/main/java/com/inteligr8/rs/ClientEnforcementAuthorizationFilter.java

@@ -16,6 +16,8 @@ package com.inteligr8.rs;
 
 import javax.ws.rs.client.ClientRequestContext;
 
+import org.apache.commons.lang3.StringUtils;
+
 /**
  * This class is the base for implementations of client authorization similar
  * to OAuth-based flows.
@@ -45,8 +47,8 @@ public class ClientEnforcementAuthorizationFilter implements AuthorizationFilter
 	 * @param clientSecret A secret corresponding to the client ID.
 	 */
 	public ClientEnforcementAuthorizationFilter(String clientId, String clientSecret) {
-		this.clientId = clientId;
-		this.clientSecret = clientSecret;
+		this.clientId = StringUtils.trimToNull(clientId);
+		this.clientSecret = StringUtils.trimToNull(clientSecret);
 	}
 
 	/**

src/main/java/com/inteligr8/rs/ClientImpl.java

@@ -19,8 +19,6 @@ import javax.ws.rs.client.ClientBuilder;
 
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
-import org.springframework.beans.factory.annotation.Autowired;
-import org.springframework.stereotype.Component;
 
 /**
  * A class that provides pre-configured JAX-RS Client & WebTarget objects
@@ -28,7 +26,6 @@ import org.springframework.stereotype.Component;
  * 
  * @author brian@inteligr8.com
  */
-@Component("client.jaxrs")
 public class ClientImpl extends Client {
 	
 	private final Logger logger = LoggerFactory.getLogger(ClientImpl.class);
@@ -39,7 +36,6 @@ public class ClientImpl extends Client {
 	 * This constructor is for Spring or POJO use.
 	 * @param config The client configuration.
 	 */
-	@Autowired
 	public ClientImpl(ClientConfiguration config) {
 		this.config = config;
 	}

src/main/java/com/inteligr8/rs/OAuthAuthorizationCodeAuthorizationFilter.java

@@ -18,6 +18,10 @@ import java.net.URI;
 
 import javax.ws.rs.core.Form;
 
+import org.apache.commons.lang3.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 /**
  * This class implements the OAuth Authorization Code flow as an authorization
  * filter.
@@ -26,6 +30,8 @@ import javax.ws.rs.core.Form;
  */
 public class OAuthAuthorizationCodeAuthorizationFilter extends OAuthAuthorizationFilter {
     
+    private final Logger logger = LoggerFactory.getLogger(this.getClass());
+	
 	private final String code;
 	private final URI redirectUri;
 	
@@ -68,12 +74,13 @@ public class OAuthAuthorizationCodeAuthorizationFilter extends OAuthAuthorizatio
 	public OAuthAuthorizationCodeAuthorizationFilter(String tokenUrl, String clientId, String clientSecret, String code, URI redirectUri) {
 		super(tokenUrl, clientId, clientSecret);
 		
-		this.code = code;
+		this.code = StringUtils.trimToNull(code);
 		this.redirectUri = redirectUri;
 	}
 	
 	@Override
 	protected Form createForm() {
+        this.logger.debug("Using OAuth grant_type 'authorization_code'");
 		Form form = new Form().param("grant_type", "authorization_code");
 		if (this.redirectUri != null)
 			form.param("redirect_uri", this.redirectUri.toString());

src/main/java/com/inteligr8/rs/OAuthAuthorizationFilter.java

@@ -27,6 +27,7 @@ import javax.ws.rs.core.HttpHeaders;
 import javax.ws.rs.core.Response;
 import javax.ws.rs.core.Response.Status.Family;
 
+import org.apache.commons.lang3.StringUtils;
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
@@ -88,9 +89,9 @@ public abstract class OAuthAuthorizationFilter implements AuthorizationFilter {
 	 */
 	public OAuthAuthorizationFilter(String tokenUrl, String clientId, String clientSecret, String scope) {
 		this.tokenUrl = tokenUrl;
-		this.clientId = clientId;
-		this.clientSecret = clientSecret;
-		this.scope = scope;
+		this.clientId = StringUtils.trimToNull(clientId);
+		this.clientSecret = StringUtils.trimToNull(clientSecret);
+		this.scope = StringUtils.trimToNull(scope);
 	}
 
 	/**

src/main/java/com/inteligr8/rs/OAuthClientCredentialAuthorizationFilter.java

@@ -16,6 +16,9 @@ package com.inteligr8.rs;
 
 import javax.ws.rs.core.Form;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 /**
  * This class implements the OAuth Client Credential flow as an authorization
  * filter.
@@ -24,6 +27,8 @@ import javax.ws.rs.core.Form;
  */
 public class OAuthClientCredentialAuthorizationFilter extends OAuthAuthorizationFilter {
     
+    private final Logger logger = LoggerFactory.getLogger(this.getClass());
+
 	/**
 	 * @param tokenUrl The URL to the OAuth IdP token service.
 	 * @param clientId The ID provided by the OAuth IdP administrator.
@@ -35,6 +40,7 @@ public class OAuthClientCredentialAuthorizationFilter extends OAuthAuthorization
 	
 	@Override
 	protected Form createForm() {
+        this.logger.debug("Using OAuth grant_type 'client_credentials'");
 		return new Form().param("grant_type", "client_credentials");
 	}
 	

src/main/java/com/inteligr8/rs/OAuthPasswordGrantAuthorizationFilter.java

@@ -16,6 +16,10 @@ package com.inteligr8.rs;
 
 import javax.ws.rs.core.Form;
 
+import org.apache.commons.lang3.StringUtils;
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 /**
  * This class implements the OAuth Password Grant flow as an authorization
  * filter.
@@ -24,6 +28,8 @@ import javax.ws.rs.core.Form;
  */
 public class OAuthPasswordGrantAuthorizationFilter extends OAuthAuthorizationFilter {
     
+    private final Logger logger = LoggerFactory.getLogger(this.getClass());
+	
 	private final String username;
 	private final String password;
 
@@ -46,12 +52,13 @@ public class OAuthPasswordGrantAuthorizationFilter extends OAuthAuthorizationFil
 	 */
 	public OAuthPasswordGrantAuthorizationFilter(String tokenUrl, String clientId, String clientSecret, String username, String password) {
 		super(tokenUrl, clientId, clientSecret);
-		this.username = username;
-		this.password = password;
+		this.username = StringUtils.trimToNull(username);
+		this.password = StringUtils.trimToNull(password);
 	}
 	
 	@Override
 	protected Form createForm() {
+        this.logger.debug("Using OAuth grant_type 'password': {}", this.username);
 		return new Form().param("grant_type", "password")
 				.param("username", this.username);
 	}