mirror of
https://github.com/bmlong137/maven-tiles
synced 2025-09-17 14:21:08 +00:00
Merge branch 'peterjanes-fail-on-extensions'
* peterjanes-fail-on-extensions: Fail tile validation if <build><extensions> is present. Fail tile validation when a plugin includes <extensions>. Fail tile validation if <build><extensions> is present. Fail tile validation when a plugin includes <extensions>. Fail tile validation if <build><extensions> is present. Fail tile validation when a plugin includes <extensions>. Fail tile validation if <build><extensions> is present. Change-Id: Ib45c6308be0e09f7e9a3e4a65fa40b5076f3b15c
This commit is contained in:
@@ -112,6 +112,21 @@ class TileValidator {
|
||||
validModel = null
|
||||
}
|
||||
|
||||
if (model.build?.extensions) {
|
||||
log.error("Tile has extensions and must not have")
|
||||
validModel = null
|
||||
}
|
||||
|
||||
if (model.build?.plugins) {
|
||||
for (plugin in model.build.plugins) {
|
||||
if (plugin.extensions) {
|
||||
log.error("Tile has plugins with extensions and must not have")
|
||||
validModel = null
|
||||
break
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
return validModel
|
||||
}
|
||||
}
|
||||
|
@@ -31,7 +31,7 @@ class TileValidatorTest {
|
||||
public void testValidation() {
|
||||
new TileValidator().loadModel(logger, new File("src/test/resources/bad-tile.xml"), "")
|
||||
|
||||
assert errors.size() == 8
|
||||
assert errors.size() == 10
|
||||
assert warnings.size() == 0
|
||||
assert infos.size() == 0
|
||||
}
|
||||
|
@@ -51,5 +51,21 @@
|
||||
</plugin>
|
||||
</plugins>
|
||||
</pluginManagement>
|
||||
<plugins>
|
||||
<plugin>
|
||||
<groupId>group</groupId>
|
||||
<artifactId>artifact</artifactId>
|
||||
<version>version</version>
|
||||
<extensions>true</extensions>
|
||||
</plugin>
|
||||
</plugins>
|
||||
<extensions>
|
||||
<extension>
|
||||
<groupId>group</groupId>
|
||||
<artifactId>artifact</artifactId>
|
||||
<version>version</version>
|
||||
</extension>
|
||||
</extensions>
|
||||
</build>
|
||||
|
||||
</project>
|
||||
|
Reference in New Issue
Block a user