inteligr8/SearchServices
1
0
Fork 0
mirror of https://github.com/Alfresco/SearchServices.git synced 2026-09-16 18:12:56 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: NPE on 3 new tests

Browse Source
This commit is contained in:
Paul Brodner
2016-12-14 19:21:53 +02:00
parent 9f67e7b2ff
commit 90e71607df
3 changed files with 10 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
e2e-test/java/org/alfresco/rest/sites/AddSiteMemberCoreTests.java
+1
View File
@@ -50,6 +50,7 @@ public class AddSiteMemberCoreTests extends RestTest
public void addManagerToPublicSite() throws Exception
{
UserModel testUser = dataUser.createRandomTestUser("testUser");
testUser.setUserRole(UserRole.SiteManager);
memberModel = restClient.authenticateUser(adminUserModel).withCoreAPI().usingSite(publicSiteModel).addPerson(testUser);
restClient.assertStatusCodeIs(HttpStatus.CREATED);
memberModel.assertThat().field("id").is(testUser.getUsername())
e2e-test/java/org/alfresco/rest/workflow/processes/AddProcessItemCoreTests.java
+4 -1
View File
@@ -7,6 +7,7 @@ import org.alfresco.rest.core.RestRequest;
import org.alfresco.rest.model.RestErrorModel;
import org.alfresco.rest.model.RestItemModel;
import org.alfresco.rest.model.RestProcessModel;
import org.alfresco.rest.model.RestProcessModelsCollection;
import org.alfresco.utility.model.FileModel;
import org.alfresco.utility.model.SiteModel;
import org.alfresco.utility.model.TestGroup;
@@ -114,7 +115,9 @@ public class AddProcessItemCoreTests extends RestTest
@Test(groups = { TestGroup.REST_API, TestGroup.WORKFLOW, TestGroup.PROCESSES, TestGroup.CORE })
public void failedAddingProcessItemIfInvalidProcessIdIsProvided() throws Exception
{
processModel = restClient.authenticateUser(adminUser).withParams("maxItems=1").withWorkflowAPI().getProcesses().getOneRandomEntry().onModel();
RestProcessModelsCollection processes = restClient.authenticateUser(adminUser).withParams("maxItems=1").withWorkflowAPI().getProcesses();
processModel= processes.assertThat().entriesListIsNotEmpty().when().getOneRandomEntry().onModel();
processModel.setId("invalidProcessId");
processItem = restClient.withWorkflowAPI().usingProcess(processModel).addProcessItem(document);
restClient.assertStatusCodeIs(HttpStatus.NOT_FOUND).assertLastError()
e2e-test/java/org/alfresco/rest/workflow/processes/GetProcessVariablesCoreTests.java
+5 -2
View File
@@ -6,6 +6,7 @@ import org.alfresco.rest.RestTest;
import org.alfresco.rest.exception.JsonToModelConversionException;
import org.alfresco.rest.model.RestErrorModel;
import org.alfresco.rest.model.RestProcessModel;
import org.alfresco.rest.model.RestProcessModelsCollection;
import org.alfresco.rest.model.RestProcessVariableCollection;
import org.alfresco.utility.model.FileModel;
import org.alfresco.utility.model.SiteModel;
@@ -77,8 +78,10 @@ public class GetProcessVariablesCoreTests extends RestTest
description = "Get process variables using invalid process ID")
@Test(groups = { TestGroup.REST_API, TestGroup.WORKFLOW, TestGroup.PROCESSES, TestGroup.CORE })
public void getProcessVariablesUsingInvalidProcessId() throws JsonToModelConversionException, Exception
{
processModel = restClient.authenticateUser(userWhoStartsTask).withParams("maxItems=2").withWorkflowAPI().getProcesses().getOneRandomEntry().onModel();
{
RestProcessModelsCollection processes = restClient.authenticateUser(userWhoStartsTask).withParams("maxItems=2").withWorkflowAPI().getProcesses();
processModel = processes.assertThat().entriesListIsNotEmpty().when().getOneRandomEntry().onModel();
String id = RandomStringUtils.randomAlphanumeric(10);
processModel.setId(id);
variables = restClient.withParams("maxItems=2").withWorkflowAPI().usingProcess(processModel).getProcessVariables();