[ SEARCH-2180 ] Review comments addressed

search-services/alfresco-solrclient-lib/src/main/java/org/alfresco/solr/client/LookAheadBufferedReader.java

@@ -1,3 +1,21 @@
+/*
+ * Copyright (C) 2005-2020 Alfresco Software Limited.
+ *
+ * This file is part of Alfresco
+ *
+ * Alfresco is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * Alfresco is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with Alfresco. If not, see <http://www.gnu.org/licenses/>.
+ */
 package org.alfresco.solr.client;
 
 import java.io.BufferedReader;

search-services/alfresco-solrclient-lib/src/main/java/org/alfresco/solr/client/SOLRAPIClient.java

@@ -500,7 +500,7 @@ public class SOLRAPIClient
         finally
         {
             ofNullable(response).ifPresent(Response::release);
-            silentlyClose(reader);
+            ofNullable(reader).ifPresent(this::silentlyClose);
         }
 
         LOGGER.debug("### Transactions found maxTxnCommitTime: " + maxTxnCommitTime );
@@ -1161,7 +1161,7 @@ public class SOLRAPIClient
         finally
         {
             ofNullable(response).ifPresent(Response::release);
-            silentlyClose(reader);
+            ofNullable(reader).ifPresent(this::silentlyClose);
         }
 
         if (LOGGER.isDebugEnabled())
@@ -1219,7 +1219,7 @@ public class SOLRAPIClient
         finally
         {
             ofNullable(response).ifPresent(Response::release);
-            silentlyClose(reader);
+            ofNullable(reader).ifPresent(this::silentlyClose);
         }
 
         if (LOGGER.isDebugEnabled())

search-services/alfresco-solrclient-lib/src/test/java/org/alfresco/solr/client/LookAheadBufferedReaderTest.java

@@ -2,7 +2,7 @@
  * #%L
  * Alfresco Remote API
  * %%
- * Copyright (C) 2005 - 2016 Alfresco Software Limited
+ * Copyright (C) 2005 - 2020 Alfresco Software Limited
  * %%
  * This file is part of the Alfresco software.
  * If the software was purchased under a paid Alfresco license, the terms of