REPO-3963: SSO: Deprecate OneOff setting in InMemoryTicketComponentImpl (#35)

This commit is contained in:
Andrei Rebegea
2018-11-06 16:41:28 +02:00
committed by GitHub
parent d1d9c15751
commit 14e090d6eb

View File

@@ -37,6 +37,8 @@ import org.alfresco.repo.cache.SimpleCache;
import org.alfresco.service.cmr.repository.datatype.Duration; import org.alfresco.service.cmr.repository.datatype.Duration;
import org.alfresco.util.GUID; import org.alfresco.util.GUID;
import org.apache.commons.codec.binary.Hex; import org.apache.commons.codec.binary.Hex;
import org.apache.commons.logging.Log;
import org.apache.commons.logging.LogFactory;
import org.safehaus.uuid.UUIDGenerator; import org.safehaus.uuid.UUIDGenerator;
/** /**
@@ -51,6 +53,8 @@ public class InMemoryTicketComponentImpl implements TicketComponent
*/ */
public static final String GRANTED_AUTHORITY_TICKET_PREFIX = "TICKET_"; public static final String GRANTED_AUTHORITY_TICKET_PREFIX = "TICKET_";
Log logger = LogFactory.getLog(getClass());
private static ThreadLocal<String> currentTicket = new ThreadLocal<String>(); private static ThreadLocal<String> currentTicket = new ThreadLocal<String>();
private boolean ticketsExpire; private boolean ticketsExpire;
private Duration validDuration; private Duration validDuration;
@@ -96,9 +100,15 @@ public class InMemoryTicketComponentImpl implements TicketComponent
/** /**
* Are tickets single use * Are tickets single use
*/ */
@Deprecated
public void setOneOff(boolean oneOff) public void setOneOff(boolean oneOff)
{ {
this.oneOff = oneOff; this.oneOff = oneOff;
if (this.oneOff)
{
logger.warn("The 'oneOff' feature has been deprecated and will be removed in a future version. "
+ "This feature may not work as intended even in the current version");
}
} }
/** /**
@@ -190,6 +200,7 @@ public class InMemoryTicketComponentImpl implements TicketComponent
} }
if (oneOff) if (oneOff)
{ {
//this feature is deprecated
ticketsCache.remove(ticketKey); ticketsCache.remove(ticketKey);
} }
else if (newTicket != ticket) else if (newTicket != ticket)