PMD Fixes

This commit is contained in:
Eva Vasques
2026-03-26 14:45:18 +00:00
parent a3918679a3
commit 20c1e957f9
2 changed files with 8 additions and 8 deletions
@@ -59,7 +59,7 @@ import org.alfresco.service.namespace.QName;
public class BroadcastDispositionActionDefinitionUpdateAction extends RMActionExecuterAbstractBase
{
/** Logger */
private static final Log logger = LogFactory.getLog(BroadcastDispositionActionDefinitionUpdateAction.class);
private static final Log LOGGER = LogFactory.getLog(BroadcastDispositionActionDefinitionUpdateAction.class);
public static final String NAME = "broadcastDispositionActionDefinitionUpdate";
public static final String CHANGED_PROPERTIES = "changedProperties";
@@ -115,7 +115,7 @@ public class BroadcastDispositionActionDefinitionUpdateAction extends RMActionEx
return;
}
logger.info("Batching is enabled for disposition action definition update action with batch size of " + batchSize);
LOGGER.info("Batching is enabled for disposition action definition update action with batch size of " + batchSize);
// Instead of calling getDispositionService().getDisposableItems that gets all disposable items in the tree,
// we will crawl the tree and process the items in batches (processDisposableItemsInBatch)
@@ -134,7 +134,7 @@ public class BroadcastDispositionActionDefinitionUpdateAction extends RMActionEx
behaviourFilter.enableBehaviour();
}
logger.info("Disposition action batch run summary: " + "queuedItems: " + batchProcessor.getTotalQueued()
LOGGER.info("Disposition action batch run summary: " + "queuedItems: " + batchProcessor.getTotalQueued()
+ "; processedItems: " + batchProcessor.getTotalProcessed()
+ "; failedItems: " + batchProcessor.getTotalFailed());
@@ -323,9 +323,9 @@ public class BroadcastDispositionActionDefinitionUpdateAction extends RMActionEx
DispositionActionDefinition definition = nextAction.getDispositionActionDefinition();
Date newAsOfDate = getDispositionService().calculateAsOfDate(dispositionedNode, definition);
if (logger.isDebugEnabled())
if (LOGGER.isDebugEnabled())
{
logger.debug("Set disposition as of date for next action '" + nextAction.getName() +
LOGGER.debug("Set disposition as of date for next action '" + nextAction.getName() +
"' (" + nextAction.getNodeRef() + ") to: " + newAsOfDate);
}
@@ -41,7 +41,7 @@ import org.alfresco.service.transaction.TransactionService;
public class DispositionActionBatchProcessor
{
private static final Log logger = LogFactory.getLog(DispositionActionBatchProcessor.class);
private static final Log LOGGER = LogFactory.getLog(DispositionActionBatchProcessor.class);
private final int batchSize;
private final List<NodeRef> batch = new ArrayList<>();
@@ -133,7 +133,7 @@ public class DispositionActionBatchProcessor
{
hasError = true;
totalFailed += currentBatch.size();
logger.error("Failed to process batch of " + currentBatch.size() + " items", e);
LOGGER.error("Failed to process batch of " + currentBatch.size() + " items", e);
return;
}
finally
@@ -142,6 +142,6 @@ public class DispositionActionBatchProcessor
}
totalProcessed += currentBatch.size();
logger.info("Disposition action update: processed " + totalProcessed + " items so far.");
LOGGER.info("Disposition action update: processed " + totalProcessed + " items so far.");
}
}