inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-07-31 17:39:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

RM-3913 FIXMEs should have JIRAs assigned to them.

Browse Source 
Mention issue number next to Fixme's.
This commit is contained in:
Roxana Dina
2016-09-06 16:00:49 +03:00
parent 582e18230b
commit 62a1570f27
5 changed files with 11 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/jscript/app/JSONConversionComponent.java
View File

@@ -324,6 +324,7 @@ public class JSONConversionComponent extends org.alfresco.repo.jscript.app.JS
for (ChildAssociationRef parent : parentAssocs)
{
// FIXME: What if there is more than a secondary parent?
// RM-3930
if (!parent.isPrimary())
{
originatingLocation = parent.getParentRef();
@@ -334,6 +335,7 @@ public class JSONConversionComponent extends org.alfresco.repo.jscript.app.JS
{
// assume we have found the correct in-place location
// FIXME when we support multiple in-place locations
// See RM-3929
break;
}
}

3
rm-community/rm-community-repo/test/java/org/alfresco/module/org_alfresco_module_rm/test/integration/transfer/CreateTransferFolderAsNonAdminUserTest.java
View File

@@ -133,6 +133,7 @@ public class CreateTransferFolderAsNonAdminUserTest extends BaseRMTestCase
}, getAdminUserName());
// FIXME: This step should be executed in "when()".
// See RM-3931
transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue();
}
@@ -142,7 +143,7 @@ public class CreateTransferFolderAsNonAdminUserTest extends BaseRMTestCase
@Override
public void when()
{
// FIXME: If the transfer step is executed here the test fails?!?
// FIXME: If the transfer step is executed here the test fails?!? See RM-3931
//transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue();
}

5
rm-community/rm-community-repo/test/java/org/alfresco/module/org_alfresco_module_rm/test/integration/transfer/FilingPermissionsOnTransferFolderTest.java
View File

@@ -140,6 +140,7 @@ public class FilingPermissionsOnTransferFolderTest extends BaseRMTestCase
}, getAdminUserName());
// FIXME: This step should be executed in "when()".
// See RM-3931
transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue();
}
@@ -149,7 +150,7 @@ public class FilingPermissionsOnTransferFolderTest extends BaseRMTestCase
@Override
public void when()
{
// FIXME: If the transfer step is executed here the test fails.
// FIXME: If the transfer step is executed here the test fails. See RM-3931
//transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue();
// Give testUser2 filing permissions on transfer folder
@@ -187,7 +188,7 @@ public class FilingPermissionsOnTransferFolderTest extends BaseRMTestCase
// Check if testUser2 has filing permissions on the transfer folder
assertEquals(ALLOWED, permissionService.hasPermission(transferFolder, FILING));
// FIXME: Should be able to execute the action. Failing intermittently.
// FIXME: Should be able to execute the action. Failing intermittently. See RM-3931
// Execute transfer complete action as testUser2 who has filing permissions on the transfer folder
// rmActionService.executeRecordsManagementAction(transferFolder, TransferCompleteAction.NAME);

3
rm-community/rm-community-repo/test/java/org/alfresco/module/org_alfresco_module_rm/test/integration/transfer/NoPermissionsOnTransferFolderTest.java
View File

@@ -140,6 +140,7 @@ public class NoPermissionsOnTransferFolderTest extends BaseRMTestCase
}, getAdminUserName());
// FIXME: This step should be executed in "when()".
// See RM-3931
transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue();
}
@@ -149,7 +150,7 @@ public class NoPermissionsOnTransferFolderTest extends BaseRMTestCase
@Override
public void when()
{
// FIXME: If the transfer step is executed here the test fails.
// FIXME: If the transfer step is executed here the test fails. See RM-3931
//transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue();
}

3
rm-community/rm-community-repo/test/java/org/alfresco/module/org_alfresco_module_rm/test/integration/transfer/ReadPermissionsOnTransferFolderTest.java
View File

@@ -144,6 +144,7 @@ public class ReadPermissionsOnTransferFolderTest extends BaseRMTestCase
}, getAdminUserName());
// FIXME: This step should be executed in "when()".
// See RM-3931
transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue();
}
@@ -153,7 +154,7 @@ public class ReadPermissionsOnTransferFolderTest extends BaseRMTestCase
@Override
public void when()
{
// FIXME: If the transfer step is executed here the test fails.
// FIXME: If the transfer step is executed here the test fails. See RM-3931
//transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue();
// Give testUser2 read permissions on transfer folder