RM-3913 FIXMEs should have JIRAs assigned to them.

Mention issue number next to Fixme's.
This commit is contained in:
Roxana Dina
2016-09-06 16:00:49 +03:00
parent 582e18230b
commit 62a1570f27
5 changed files with 11 additions and 5 deletions

View File

@@ -324,6 +324,7 @@ public class JSONConversionComponent extends org.alfresco.repo.jscript.app.JS
for (ChildAssociationRef parent : parentAssocs) for (ChildAssociationRef parent : parentAssocs)
{ {
// FIXME: What if there is more than a secondary parent? // FIXME: What if there is more than a secondary parent?
// RM-3930
if (!parent.isPrimary()) if (!parent.isPrimary())
{ {
originatingLocation = parent.getParentRef(); originatingLocation = parent.getParentRef();
@@ -334,6 +335,7 @@ public class JSONConversionComponent extends org.alfresco.repo.jscript.app.JS
{ {
// assume we have found the correct in-place location // assume we have found the correct in-place location
// FIXME when we support multiple in-place locations // FIXME when we support multiple in-place locations
// See RM-3929
break; break;
} }
} }

View File

@@ -133,6 +133,7 @@ public class CreateTransferFolderAsNonAdminUserTest extends BaseRMTestCase
}, getAdminUserName()); }, getAdminUserName());
// FIXME: This step should be executed in "when()". // FIXME: This step should be executed in "when()".
// See RM-3931
transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue(); transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue();
} }
@@ -142,7 +143,7 @@ public class CreateTransferFolderAsNonAdminUserTest extends BaseRMTestCase
@Override @Override
public void when() public void when()
{ {
// FIXME: If the transfer step is executed here the test fails?!? // FIXME: If the transfer step is executed here the test fails?!? See RM-3931
//transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue(); //transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue();
} }

View File

@@ -140,6 +140,7 @@ public class FilingPermissionsOnTransferFolderTest extends BaseRMTestCase
}, getAdminUserName()); }, getAdminUserName());
// FIXME: This step should be executed in "when()". // FIXME: This step should be executed in "when()".
// See RM-3931
transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue(); transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue();
} }
@@ -149,7 +150,7 @@ public class FilingPermissionsOnTransferFolderTest extends BaseRMTestCase
@Override @Override
public void when() public void when()
{ {
// FIXME: If the transfer step is executed here the test fails. // FIXME: If the transfer step is executed here the test fails. See RM-3931
//transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue(); //transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue();
// Give testUser2 filing permissions on transfer folder // Give testUser2 filing permissions on transfer folder
@@ -187,7 +188,7 @@ public class FilingPermissionsOnTransferFolderTest extends BaseRMTestCase
// Check if testUser2 has filing permissions on the transfer folder // Check if testUser2 has filing permissions on the transfer folder
assertEquals(ALLOWED, permissionService.hasPermission(transferFolder, FILING)); assertEquals(ALLOWED, permissionService.hasPermission(transferFolder, FILING));
// FIXME: Should be able to execute the action. Failing intermittently. // FIXME: Should be able to execute the action. Failing intermittently. See RM-3931
// Execute transfer complete action as testUser2 who has filing permissions on the transfer folder // Execute transfer complete action as testUser2 who has filing permissions on the transfer folder
// rmActionService.executeRecordsManagementAction(transferFolder, TransferCompleteAction.NAME); // rmActionService.executeRecordsManagementAction(transferFolder, TransferCompleteAction.NAME);

View File

@@ -140,6 +140,7 @@ public class NoPermissionsOnTransferFolderTest extends BaseRMTestCase
}, getAdminUserName()); }, getAdminUserName());
// FIXME: This step should be executed in "when()". // FIXME: This step should be executed in "when()".
// See RM-3931
transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue(); transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue();
} }
@@ -149,7 +150,7 @@ public class NoPermissionsOnTransferFolderTest extends BaseRMTestCase
@Override @Override
public void when() public void when()
{ {
// FIXME: If the transfer step is executed here the test fails. // FIXME: If the transfer step is executed here the test fails. See RM-3931
//transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue(); //transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue();
} }

View File

@@ -144,6 +144,7 @@ public class ReadPermissionsOnTransferFolderTest extends BaseRMTestCase
}, getAdminUserName()); }, getAdminUserName());
// FIXME: This step should be executed in "when()". // FIXME: This step should be executed in "when()".
// See RM-3931
transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue(); transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue();
} }
@@ -153,7 +154,7 @@ public class ReadPermissionsOnTransferFolderTest extends BaseRMTestCase
@Override @Override
public void when() public void when()
{ {
// FIXME: If the transfer step is executed here the test fails. // FIXME: If the transfer step is executed here the test fails. See RM-3931
//transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue(); //transferFolder = (NodeRef) rmActionService.executeRecordsManagementAction(recordsFolder, TransferAction.NAME).getValue();
// Give testUser2 read permissions on transfer folder // Give testUser2 read permissions on transfer folder