inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-07-31 17:39:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge branch 'feature/RM-6847_SonarMajorIssues' into 'master'

Browse Source 
RM-6847 Fix some of sonar major issues

See merge request records-management/records-management!1191
This commit is contained in:
Claudia Agache
2019-06-18 12:57:01 +01:00
parent acf5ee4586 8076adfe2c
commit 8a425ef6ee
8 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/action/impl/CopyMoveLinkFileToBaseAction.java
View File

@@ -77,7 +77,7 @@ public abstract class CopyMoveLinkFileToBaseAction extends RMActionExecuterAbstr
public enum CopyMoveLinkFileToActionMode
{
COPY, MOVE, LINK
};
}
/** Action Mode */
private CopyMoveLinkFileToActionMode mode;

2
rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/capability/declarative/condition/HoldCapabilityCondition.java
View File

@@ -45,7 +45,7 @@ import org.alfresco.service.cmr.security.AccessStatus;
public class HoldCapabilityCondition extends AbstractCapabilityCondition
{
/** indicates whether to evaluate holds that the node is within or not within */
private boolean includedInHold = false;;
private boolean includedInHold = false;
/** hold service */
private HoldService holdService;

2
rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/disposition/DispositionScheduleImpl.java
View File

@@ -116,7 +116,7 @@ public class DispositionScheduleImpl implements DispositionSchedule,
Boolean value = (Boolean)nodeService.getProperty(dispositionDefinitionNodeRef, PROP_RECORD_LEVEL_DISPOSITION);
if (value != null)
{
return value.booleanValue();
return value;
}
return false;
}

4
rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/disposition/DispositionServiceImpl.java
View File

@@ -95,7 +95,7 @@ public class DispositionServiceImpl extends ServiceBaseImpl
* disposition schedule impl node under a record or folder.
*/
DATE_AND_NAME
};
}
/** Behaviour filter */
private BehaviourFilter behaviourFilter;
@@ -210,7 +210,7 @@ public class DispositionServiceImpl extends ServiceBaseImpl
nodeService.addAspect(nodeRef, ASPECT_DISPOSITION_LIFECYCLE, null);
}
}
};
}
/**
* @see org.alfresco.module.org_alfresco_module_rm.disposition.DispositionService#refreshDispositionAction(NodeRef)

2
rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/job/PublishUpdatesJobExecuter.java
View File

@@ -177,7 +177,7 @@ public class PublishUpdatesJobExecuter extends RecordsManagementJobExecuter
}
}
return null;
};
}
}, AuthenticationUtil.getSystemUserName());
if (logger.isDebugEnabled())

2
rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/role/FilePlanRoleServiceImpl.java
View File

@@ -479,7 +479,7 @@ public class FilePlanRoleServiceImpl implements FilePlanRoleService,
return result;
}
}, AuthenticationUtil.getSystemUserName());
};
}
/**
*

2
rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/script/RelationshipsGet.java
View File

@@ -62,7 +62,7 @@ public class RelationshipsGet extends AbstractRmWebScript
private enum RelationshipEndPoint
{
SOURCE, TARGET
};
}
/** Relationship service */
private RelationshipService relationshipService;

6
rm-community/rm-community-repo/source/java/org/alfresco/module/org_alfresco_module_rm/security/RMMethodSecurityInterceptor.java
View File

@@ -100,7 +100,7 @@ public class RMMethodSecurityInterceptor extends MethodSecurityInterceptor
protected Map<String, CapabilityReport> initialValue()
{
return new HashMap<String, CapabilityReport>();
};
}
};
/**
@@ -108,7 +108,7 @@ public class RMMethodSecurityInterceptor extends MethodSecurityInterceptor
*/
private static final ThreadLocal<Boolean> IS_RM_SECURITY_CHECK = new ThreadLocal<Boolean>()
{
protected Boolean initialValue() {return false;};
protected Boolean initialValue() {return false;}
};
/**
@@ -116,7 +116,7 @@ public class RMMethodSecurityInterceptor extends MethodSecurityInterceptor
*/
private static final ThreadLocal<List<String>> MESSAGES = new ThreadLocal<List<String>>()
{
protected List<String> initialValue() {return new ArrayList<String>();};
protected List<String> initialValue() {return new ArrayList<String>();}
};
/**