inteligr8/alfresco-community-repo
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-community-repo.git synced 2025-08-07 17:49:17 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed major issues ("Bad practice - Method with Boolean return type returns explicit null") reported in Sonar

Browse Source 
git-svn-id: https://svn.alfresco.com/repos/alfresco-enterprise/modules/recordsmanagement/HEAD@71961 c4b6b30b-aa2e-2d43-bbcb-ca4b014f7261
This commit is contained in:
Tuna Aksoy
2014-05-27 22:40:52 +00:00
parent 9fdbdc2155
commit aff70c9637
3 changed files with 5 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/job/NotifyOfRecordsDueForReviewJobExecuter.java
View File

@@ -104,10 +104,10 @@ public class NotifyOfRecordsDueForReviewJobExecuter extends RecordsManagementJob
if(resultNodes.size() != 0) if(resultNodes.size() != 0)
{ {
//Send the email message - but we must not retry since email is not transactional //Send the email message - but we must not retry since email is not transactional
RetryingTransactionCallback<Boolean> txCallbackSendEmail = new RetryingTransactionCallback<Boolean>() RetryingTransactionCallback<Void> txCallbackSendEmail = new RetryingTransactionCallback<Void>()
{ {
// Set the notification issued property. // Set the notification issued property.
public Boolean execute() public Void execute()
{ {
// Send notification // Send notification
recordsManagementNotificationHelper.recordsDueForReviewEmailNotification(resultNodes); recordsManagementNotificationHelper.recordsDueForReviewEmailNotification(resultNodes);

2
rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/role/FilePlanRoleServiceImpl.java
View File

@@ -792,7 +792,7 @@ public class FilePlanRoleServiceImpl implements FilePlanRoleService,
AuthenticationUtil.runAs(new AuthenticationUtil.RunAsWork<Object>() AuthenticationUtil.runAs(new AuthenticationUtil.RunAsWork<Object>()
{ {
public Boolean doWork() public Void doWork()
{ {
String roleAuthority = authorityService.getName(AuthorityType.GROUP, getFullRoleName(role, rmRootNode)); String roleAuthority = authorityService.getName(AuthorityType.GROUP, getFullRoleName(role, rmRootNode));
authorityService.deleteAuthority(roleAuthority); authorityService.deleteAuthority(roleAuthority);

4
rm-server/source/java/org/alfresco/module/org_alfresco_module_rm/security/FilePlanPermissionServiceImpl.java
View File

@@ -396,7 +396,7 @@ public class FilePlanPermissionServiceImpl extends ServiceBaseImpl
runAsSystem(new AuthenticationUtil.RunAsWork<Object>() runAsSystem(new AuthenticationUtil.RunAsWork<Object>()
{ {
public Boolean doWork() public Void doWork()
{ {
if (isFilePlan(nodeRef)) if (isFilePlan(nodeRef))
{ {
@@ -519,7 +519,7 @@ public class FilePlanPermissionServiceImpl extends ServiceBaseImpl
{ {
runAsSystem(new AuthenticationUtil.RunAsWork<Object>() runAsSystem(new AuthenticationUtil.RunAsWork<Object>()
{ {
public Boolean doWork() public Void doWork()
{ {
// can't delete permissions if inherited (eg hold and transfer containers) // can't delete permissions if inherited (eg hold and transfer containers)
if (!permissionService.getInheritParentPermissions(nodeRef)) if (!permissionService.getInheritParentPermissions(nodeRef))