RM-6318 code review changes

This commit is contained in:
Ross Gale
2018-05-15 10:12:03 +01:00
parent 888157199d
commit c68ce588bb

View File

@@ -43,6 +43,7 @@ import org.alfresco.service.namespace.QName;
/** /**
* Parent class for records search utilities * Parent class for records search utilities
*
* @author Ross Gale * @author Ross Gale
* @since 2.7 * @since 2.7
*/ */
@@ -55,6 +56,7 @@ public class SearchUtil
/** /**
* Setter for node service * Setter for node service
*
* @param nodeService Node service * @param nodeService Node service
*/ */
public void setNodeService(NodeService nodeService) public void setNodeService(NodeService nodeService)
@@ -64,6 +66,7 @@ public class SearchUtil
/** /**
* Use a container node ref and return the nodeIds of the contents * Use a container node ref and return the nodeIds of the contents
*
* @param nodeRef container * @param nodeRef container
* @return list of nodeIds * @return list of nodeIds
*/ */
@@ -84,13 +87,15 @@ public class SearchUtil
NodeRef rootNodeRef = nodeService.getRootNode(STORE_REF_WORKSPACE_SPACESSTORE); NodeRef rootNodeRef = nodeService.getRootNode(STORE_REF_WORKSPACE_SPACESSTORE);
List<ChildAssociationRef> assocRefs = nodeService.getChildAssocs(rootNodeRef, ASSOC_CHILDREN, container); List<ChildAssociationRef> assocRefs = nodeService.getChildAssocs(rootNodeRef, ASSOC_CHILDREN, container);
if (assocRefs.size() == 0) if (assocRefs.isEmpty())
{ {
return nodeService.createNode(rootNodeRef, ASSOC_CHILDREN, container, TYPE_CONTAINER).getChildRef(); return nodeService.createNode(rootNodeRef, ASSOC_CHILDREN, container, TYPE_CONTAINER).getChildRef();
} else if (assocRefs.size() != 1) }
else if (assocRefs.size() != 1)
{ {
throw new AlfrescoRuntimeException("Only one container is allowed."); throw new AlfrescoRuntimeException("Only one container is allowed.");
} else }
else
{ {
return assocRefs.iterator().next().getChildRef(); return assocRefs.iterator().next().getChildRef();
} }