review updates - minor formatting, update java docs

This commit is contained in:
Rodica Sutu
2018-01-29 09:29:08 +02:00
parent 975b2fe323
commit d5af9932f9
2 changed files with 6 additions and 6 deletions

View File

@@ -54,7 +54,7 @@ public interface RecordsManagementQueryDAO
int getCountRmaIdentifier(String identifierValue); int getCountRmaIdentifier(String identifierValue);
/** /**
* Returns the property values from children for the given property * Returns distinct property values from children for the given property
* *
* @param parent the parent to evaluate * @param parent the parent to evaluate
* @param property the QName of the property to evaluate * @param property the QName of the property to evaluate

View File

@@ -100,7 +100,7 @@ public class RecordsManagementQueryDAOImplTest extends BaseRMTestCase implements
* Then the answer contains all distinct property values set * Then the answer contains all distinct property values set
*/ */
@org.junit.Test @org.junit.Test
public void testgetChildrenWithPropertyValues_childrenWithValues() throws Exception public void testGetChildrenWithPropertyValues_childrenWithValues() throws Exception
{ {
doBehaviourDrivenTest(new BehaviourDrivenTest() doBehaviourDrivenTest(new BehaviourDrivenTest()
{ {
@@ -136,8 +136,8 @@ public class RecordsManagementQueryDAOImplTest extends BaseRMTestCase implements
@Override @Override
public void then() throws Exception public void then() throws Exception
{ {
Set<String> expectedValues = ImmutableSet.of(propValue1,propValue2,propValue3); Set<String> expectedValues = ImmutableSet.of(propValue1, propValue2, propValue3);
assertEquals(propertyValues.size(),expectedValues.size()); assertEquals(propertyValues.size(), expectedValues.size());
assertTrue(propertyValues.containsAll(expectedValues)); assertTrue(propertyValues.containsAll(expectedValues));
} }
@@ -261,8 +261,8 @@ public class RecordsManagementQueryDAOImplTest extends BaseRMTestCase implements
/** /**
* Given a folder with no children but the property set on itself * Given a folder with no children but the property set on itself
* When I check if the folder contains children having certain descriptions * When get the children property values
* Then the answer is negative * Then the list is empty
*/ */
@org.junit.Test @org.junit.Test
public void testGetChildrenWithPropertyValues_noChildren() throws Exception public void testGetChildrenWithPropertyValues_noChildren() throws Exception