* Delete unused heartbeatpublic.keystore
* Rename CommunityHBDataCollector.java to RepositoryDataCollector.java as per code review
* Removed licence related data from RepositoryDataCollector.java
* Remove unused commented out methods
* Synchronise accessors for hb enabled flag
* Move HeartBeat bean definitions to new hearbeat-context.xml
* Removed bean definition for the EnterpriseHBDataCollector.java
* Refactored code based on code review
* Added real data collection to CommunityHBDataCollector.java
* Moved HeartBeat to community and refactored
* Configured HBDataCollectorService with dummy data collectors in bootstrap-context but this configuration might be moved elsewhere.
REMO-18404 Environment not being set for ImageMagick
The environment required by ImageMagick was not being set. Even though the environment shown by log4j.logger.org.alfresco.util.exec.RuntimeExec=trace indicated that the required variables already existed in the current environment, that does not mean they are passed on to the sub process. In this case they were not being passed on and they were not being set as additional variables required by the sub process.
The bug was introduced when Alfresco PDF renderer was added (REPO-2054) to ACS 5.2.1 and ACS 5.2.g. The context file for ImageMagic (imagemagick-transform-context.xml) was used as the basis for Alfresco PDF renderer's context file. Unfortunately the names of the spring beans that provided the Windows and Unix environment variable values were not changed. As a result, ImageMagick was being provided with Alfresco PDF renderer's environment variables.
The Alfresco global property img.gslib and environment variable $GS_LIB set using it, are now redundant following the REPO-2054 work so have been removed in this commit.
When testing this issue we should test ImageMagick and Alfresco PDF renderer on both Windows and Unix (Linux). I have not dug into why ImageMagick and Alfresco PDF renderer are working on Linux. I'm guessing that the current environment is being passed on unlike Windows.
* REPO-2819 : DELETE /shared-links/{id} with admin returns 403
Add an extra check to QuickShareServiceImpl.canDeleteSharedLink, because the admin user can return the SiteName of a nodeRef (even if it's private).
Add a JUnit test into QuickShareServiceIntegrationTest
Add a comment to the test - no actual shared Link is needed for this test.
* REPO-2520 : SiteMembership Java API calls should tell which site resulted in errors
Add the test class into the test suite (was not previously added).
* REPO-2793: refactoring the tests in the test suites so we can get more efficient and balanced Test Suites
* REPO-2793: cleanup and renames
* REPO-2793: fix the Virtual Folder tests that was failing on bamboo
* REPO-2793: fix some rendition tests on the build by running them earlier
* REPO-2793: fix the test testAR1303. It needed some cleanup
