Commit Graph

2346 Commits

Author SHA1 Message Date
Tom Page
f5b33d003d Merge branch 'feature/RM-3344_AdminAndGuest' into 'master'
Feature/rm 3344 admin and guest

RM-3344 Ensure that admin can't lose clearance and guest can't gain any clearance.

Rather than use the guest role, as was used previously for classification clearance, we are
explicitly checking the username.

See merge request !160
2016-04-28 10:00:23 +01:00
Tom Page
6f8fecae4b RM-3344 Ensure we are not downgrading admin or upgrading guest.
This is a first pass at preventing changes to the clearance of admin or guest.
Previously we weren't allowing any changes to their clearance, but when
working with security markings, admin in particular needs to occasionally gain
a new mark when a custom group is created.  Currently that clearing is not
happening, but this change does not prevent it, if needed.

Also remove an unused method from the CaveatMarkingServiceImpl, as the class
is already very full.
2016-04-27 16:12:11 +01:00
Tom Page
4d14d17fb4 Merge branch 'xperimental/RM-2812_MarkPublicAPIs' into 'master'
Xperimental/rm 2812 Mark Public APIs

First attempt to mark classes that should be part of the public API with \@AlfrescoPublicAPI.

I have also added a couple of \@deprecated annotations to classes where I thought it made sense, and
added comments to classes that I wanted to add to the public API but couldn't (due to their contract
being dependent on non-public API classes).

See merge request !138
2016-04-27 09:23:58 +01:00
Tom Page
365090abdf RM-2812 Finalisation of first pass of classes to annotate. 2016-04-27 09:15:37 +01:00
Tom Page
46b1a54dff Merge branch 'feature/RM-3144_PatchForClearanceLevel' into 'master'
Feature/rm 3144 patch for clearance level

Create a patch to migrate all users' clearance levels from the old classification model to
the new security marks model.

This merge request depends on getting !130 merged first.

See merge request !133
2016-04-27 08:27:12 +01:00
Tom Page
a5c0750065 Merge release/V2.4 into master.
Conflicts:
	pom.xml
	rm-automation/pom.xml
	rm-community/pom.xml
	rm-community/rm-community-repo/pom.xml
	rm-community/rm-community-share/pom.xml
	rm-enterprise/pom.xml
	rm-enterprise/rm-enterprise-repo/pom.xml
	rm-enterprise/rm-enterprise-share/pom.xml
2016-04-25 16:22:07 +01:00
Jean-Pierre
9b007ef5db [maven-release-plugin] prepare for next development iteration 2016-04-22 14:32:22 +01:00
Jean-Pierre
06676d6b5f [maven-release-plugin] prepare release V2.4 2016-04-22 14:32:19 +01:00
Jean-Pierre
6181859dcf [maven-release-plugin] prepare for next development iteration 2016-04-22 14:27:19 +01:00
Jean-Pierre
62582f48ff [maven-release-plugin] prepare release V2.4.b 2016-04-22 14:27:16 +01:00
Tom Page
c49a15c375 RM-2812 Add audit service and dependencies.
Having thought about this more, I don't think there's any problem adding
a deprecated class to the public API, as long as it's clearly marked as
such. It's deprecated at the moment because we think people might be using
it, but we want them to migrate to something else. Declaring this as part of
the public API formalises this process.

The RecordsManagementAuditService has the following dependencies:

RecordsManagementAuditQueryParameters <- RecordsManagementAuditService
RecordsManagementAuditEntry <- RecordsManagementAuditService
AuditEvent <- RecordsManagementAuditService
2016-04-20 16:24:44 +01:00
Tom Page
ebd8e09f88 RM-2812 Update following review comments.
The class dependency used to determine the classes to include based on the initial services is:

Depth 0: Service interfaces.

Depth 1:
ClearanceLevel <- SecurityClearanceService
RecordsManagementActionCondition <- RecordsManagementActionService
ClassificationAspectProperties <- ContentClassificationService
Version <- RecordableVersionConfigService, RecordableVersionService
Role <- FilePlanRoleService
CaveatGroupType <- CaveatSchemeService
RecordsManagementEvent <- RecordsManagementEventService
Group <- CapabilityService
RelationshipDisplayName <- RelationshipService
RecordsManagementActionResult <- RecordsManagementActionService
RecordsManagementAction <- RecordsManagementActionService
Relationship <- RelationshipService
ProtectedModelArtifact <- ModelSecurityService
ReportGenerator <- ReportService
RecordsManagementSearchParameters <- RecordsManagementSearchService
SecurityClearance <- SecurityClearanceService
SortDirection <- CaveatSchemeService
RecordsManagementEventType <- RecordsManagementEventService
Report <- ReportService
UserQueryParams <- SecurityClearanceService
CaveatMarkSortField <- CaveatSchemeService
ProtectedProperty <- ModelSecurityService
RelationshipDefinition <- RelationshipService
Capability <- FilePlanRoleService, CapabilityService
ExemptionCategory <- ClassificationSchemeService
CaveatGroup <- CaveatMarkingService, CaveatSchemeService
ClassificationReason <- ClassificationSchemeService
ProtectedAspect <- ModelSecurityService
MetadataReferral <- ReferralAdminService, ReferredMetadataService
CaveatMark <- CaveatClearanceService, CaveatMarkingService, ContentClassificationService, CaveatSchemeService, ClassificationSchemeService
SavedSearchDetails <- RecordsManagementSearchService
IdentifierGenerator <- IdentifierService

Depth 2:
RecordsManagementActionConditionDefinition <- RecordsManagementActionCondition
ReferralRegistry <- MetadataReferral
ClassificationSchemeEntity <- ExemptionCategory, ClassificationReason
RecordsManagementActionDefinition <- RecordsManagementAction
ReportDetails <- SavedSearchDetails
SortItem <- RecordsManagementSearchParameters
SavedSearchDetailsCompatibility <- SavedSearchDetails

Depth 3:
RecordsManagementModel <- SavedSearchDetailsCompatibility

Depth 4:
RecordsManagementCustomModel <- RecordsManagementModel
2016-04-20 16:14:07 +01:00
Ana Bozianu
30d1120005 Merge release/V2.4 into master 2016-04-20 18:04:27 +03:00
Ana Bozianu
3b40b746ad RM-3310 - added null check 2016-04-20 14:27:07 +03:00
Tom Page
fca0030c50 RM-2812 Mark public API methods with @AlfrescoPublicAPI. 2016-04-19 16:24:46 +01:00
Tuna Aksoy
7544f6c9dc Merge branch 'feature/RM-3150_Errors_When_Generating_Javadoc' into 'master'
Feature/rm 3150 errors when generating javadoc

See merge request !135
2016-04-18 16:44:51 +01:00
Tuna Aksoy
61c1be4236 RM-3150 (Errors when generating Javadoc for RM using Java 8) 2016-04-18 16:19:06 +01:00
Tuna Aksoy
f3d163c6f5 Revert "RM-3150 (Errors when generating Javadoc for RM using Java 8)"
This reverts commit f1f5aa2534.
2016-04-18 16:12:00 +01:00
Tuna Aksoy
f1f5aa2534 RM-3150 (Errors when generating Javadoc for RM using Java 8) 2016-04-18 16:01:02 +01:00
Tom Page
bec89ee464 RM-3144 Create a patch to migrate clearance level.
Previously the clearance level was stored in its own aspect in the
classified content model, but it has now been moved to the security marks
model.
2016-04-18 11:44:32 +01:00
Roxana Lucanu
a313125218 Merge release/V2.4 into master 2016-04-15 16:16:45 +03:00
Roxana Lucana-Ghetu
3b0540a19b Merge branch 'feature-2.4/RM-3285' into 'release/V2.4'
Feature 2.4/rm 3285

Added check not to be able to put null in cache, for nodes that are not records and don't have a filePlan.
Added unit test for it.

See merge request !128
2016-04-15 13:44:57 +01:00
Roxana Lucanu
dbd8304293 Changed class not to extend anymore BaseUnitTest class 2016-04-15 15:38:09 +03:00
Roxana Lucanu
fe0d6a543b RM-3285 - added null check for adding in cache 2016-04-15 13:34:30 +03:00
Kristijan Conkas
237c61a10f Merge branch 'feature/RM-3284_UI_tests_are_failing' into 'master'
Feature/rm 3284 ui tests are failing

This change addresses the failing builds both on master and on latest Aikau build plan. It also bumps up the Aikau version to 1.0.63 (further to @dwebster's confirmation this one is good to use).

See merge request !125
2016-04-15 11:06:34 +01:00
Silviu Dinuta
5801b43947 Merged release/V2.4 into master 2016-04-15 11:32:34 +03:00
Silviu Dinuta
78a78017ab Merge branch 'feature-2.4/RM-3233_NonElectronicRecordsCanNotHavePropertiesChangedThroughRulesInUnfiledRecords' into 'release/V2.4'
Feature 2.4/rm 3233 non electronic records can not have properties changed through rules in unfiled records

When setting a foreground rule to change one properties for files that enter to a folder from Unfiled Records, when trying to create a nonElectronic record sometimes because it was very hard to reproduce this issue, SetPropertyValueActionExecuter is executed before adding the Record aspect from RecordsManagementContainerType.onCreateChildAssociation() and that's why it fails when checking UpdateProperties capability.

When creating "rma:nonElectronicDocument" document formprocessor is used and at some point updateNode from node service is used to update the properties. Therefore I made sure that each time when udating "rma:nonElectronicDocument" node the Record aspect is added if not present.

See merge request !124
2016-04-15 09:23:29 +01:00
Tuna Aksoy
5d0f5dfc1e Merge branch 'release/V2.4' 2016-04-15 09:22:25 +01:00
Roxana Lucana-Ghetu
70b8bb0e65 Merge branch 'feature-2.4/RM-2925_noOptionToDeleteDestroyedRecordFolder' into 'release/V2.4'
Feature 2.4/rm 2925 no option to delete destroyed record folder

RM-2925 - No option to delete destroyed record folder (which maintain record metadata after destroy)

Made Delete action available for destroyed record folder, added unit test class.

See merge request !92
2016-04-15 09:18:39 +01:00
Silviu Dinuta
617db115b3 Changed NonElectronicRecortTypeUnitTest 2016-04-15 11:09:32 +03:00
Silviu Dinuta
6b44bea297 Changed NonElectronicRecordTypeUnitTest 2016-04-15 10:41:53 +03:00
Ana Bozianu
66c0309e44 Merge release/V2.4 into master 2016-04-14 19:40:25 +03:00
Ana Bozianu
bb86b23cb4 Merge branch 'feature-2.4/RM-3283_OutlookIntegrationEmailWithAttachments' into 'release/V2.4'
Feature 2.4/rm 3283 outlook integration email with attachments

RM-3283 - Outlook Integration:Emails cannot be added to Unfiled Records (having a rule set) using Alfresco Outlook Integration

When adding emails with attachments in alfresco a hidden folder of type wpsmail-v2:attachment-folder (subtype of cm:folder) is added to hold the attachment files. When such an email is added in Unfilled Records container the RecordsManagementContainerType.onCreateChildAssociation policy is fired which transforms any subtype of folder into a record folder. When the rule tries to file this folder in another record folder we get an exception from trying to add a record folder in another record folder.

To fix this issue I added an extra check to avoid applying the conversion rule on hidden nodes. I also added a unit test for both hidden and non hidden folders.

See merge request !123
2016-04-14 17:39:08 +01:00
Silviu Dinuta
8c3c02aca5 Added unit tests for NonElectronicRecordType and fixed typo 2016-04-14 18:54:41 +03:00
Kristijan Conkas
ab63e09d8b Merge branch 'master' into feature/RM-3284_UI_tests_are_failing 2016-04-14 16:23:04 +01:00
Silviu Dinuta
14bf20dcef Added @author and @since for the class 2016-04-14 15:24:30 +03:00
Ana Bozianu
b0b1a19b48 RM-3283 - added comment to explain change 2016-04-14 14:25:29 +03:00
Kristijan Conkas
d5fd40d046 RM-3284: Instructions for running tests against latest Aikau snapshot. 2016-04-14 11:20:27 +01:00
Ana Bozianu
ec85454dcd RM-3283 - added missing file header 2016-04-14 12:25:25 +03:00
Silviu Dinuta
8fe2973507 Added NonElectronicRecordType class to make sure that Record aspect is
added before entering in UpdatePropertiesPolicy for nonElectronic
documents
2016-04-14 12:06:39 +03:00
Ana Bozianu
896398c1ff RM-3283 - added extra check for hidden aspect + unit test 2016-04-14 11:28:21 +03:00
Tom Page
1fa5d3a6cc Merge release/V2.4 into master. 2016-04-13 10:16:57 +01:00
Tom Page
96bae15727 Merge release/V2.3 into release/V2.4.
Conflicts:
	rm-community/rm-community-share/source/web/rm/components/console/rm-audit.js
	rm-community/rm-community-share/source/web/rm/components/console/rm-user-rights.js
2016-04-13 10:15:05 +01:00
Tom Page
0b041e4824 Merge release/V2.3.0.x into V2.3. 2016-04-13 10:10:10 +01:00
Tom Page
fd6ba15eac Update version to 2.3.0.4-SNAPSHOT. 2016-04-13 09:07:57 +01:00
Tom Page
a36354820f Update version to 2.3.0.3. 2016-04-13 09:06:16 +01:00
Ana Bozianu
de7718bb22 Merge branch 'feature-2.4/RM-3216_RegressionIMAP' into 'release/V2.4'
Feature 2.4/rm 3216 regression imap

RM-3274 - Error creating bean with name 'imapServiceBootstrap'

I added an invalid authentication util bean reference to the extended IMAP service and the setter was missing.

See merge request !117
2016-04-13 07:30:16 +01:00
Roxana Lucana-Ghetu
ea1dac281f Merge branch 'feature-2.4/RM-3030_PreviewNotAvailableDeclaredRecord' into 'release/V2.4'
Feature 2.4/rm 3030 preview not available declared record

RM-3030 - The documents declared as records in their Details page don't have the preview available afterwards.

I've noticed different behavior when doing steps in different order: if the file is declared as record before navigating to document details page, the error doesn't reproduce; if document details page is accessed first and after declare the file as record,  there is an Access Denied exception.
In the first case the node for preview has the File Plan aspect, in the second one it doesn't.

See merge request !105
2016-04-12 14:10:39 +01:00
Ana Bozianu
b2005355e3 RM-3274 - fixed invalid AuthenticationUtil bean refference 2016-04-12 14:59:02 +03:00
gbroadbent
b208cf0c7c DUTCH: Fixed reverted "workflow" term" files as per EN bundle rev-2016-04-08 2016-04-12 10:46:58 +01:00