GH Auto: Upstream dependencies ADF:8.4.0-22182348850 JS-API:9.4.0-22182348850 using Tag:8.4.0-22182348850 (#5043)

* [ci:force][auto-commit] Update dependencies ADF:8.4.0-22182348850  JS:9.4.0-22182348850

* Refactor components to use Angular's dependency injection with `inject` function. Removed unnecessary constructor parameters in `name-column`, `saved-searches-list`, `node-information`, and `content-url` components. Updated `node-actions` service to use string literals for `BatchOperationType`. Adjusted `showHeader` initialization in `document-base-page` component for consistency.

---------

Co-authored-by: AleksanderSklorz <115619721+AleksanderSklorz@users.noreply.github.com>
Co-authored-by: Denys Vuika <denys.vuika@gmail.com>

package-lock.json

@@ -9,11 +9,11 @@
       "version": "7.3.0",
       "license": "LGPL-3.0",
       "dependencies": {
-        "@alfresco/adf-content-services": "8.4.0-21916318527",
-        "@alfresco/adf-core": "8.4.0-21916318527",
-        "@alfresco/adf-extensions": "8.4.0-21916318527",
-        "@alfresco/eslint-plugin-eslint-angular": "8.4.0-21916318527",
-        "@alfresco/js-api": "9.4.0-21916318527",
+        "@alfresco/adf-content-services": "8.4.0-22182348850",
+        "@alfresco/adf-core": "8.4.0-22182348850",
+        "@alfresco/adf-extensions": "8.4.0-22182348850",
+        "@alfresco/eslint-plugin-eslint-angular": "8.4.0-22182348850",
+        "@alfresco/js-api": "9.4.0-22182348850",
         "@angular/animations": "19.2.18",
         "@angular/cdk": "19.2.18",
         "@angular/common": "19.2.18",
@@ -46,7 +46,7 @@
         "zone.js": "0.15.0"
       },
       "devDependencies": {
-        "@alfresco/adf-cli": "8.4.0-21916318527",
+        "@alfresco/adf-cli": "8.4.0-22182348850",
         "@angular-devkit/build-angular": "19.2.19",
         "@angular-devkit/core": "19.2.18",
         "@angular-devkit/schematics": "19.2.18",
@@ -103,13 +103,13 @@
       }
     },
     "node_modules/@alfresco/adf-cli": {
-      "version": "8.4.0-21916318527",
-      "resolved": "https://registry.npmjs.org/@alfresco/adf-cli/-/adf-cli-8.4.0-21916318527.tgz",
-      "integrity": "sha512-Gh8D537RHAz3b6wzZF7G2OAfTNvFILak3aQiA5yHS4wVECDgqLUV24ts5PAzyYhdU4AJCdJ6UvNO4erldQY6bg==",
+      "version": "8.4.0-22182348850",
+      "resolved": "https://registry.npmjs.org/@alfresco/adf-cli/-/adf-cli-8.4.0-22182348850.tgz",
+      "integrity": "sha512-RzNQrRNeWeO/YTuaqeJyDwqdzzVPjJeMhqhA/FDkEQkpiC+ihDiBRKz+IqFfr4N+43ovMUCjBlU0rIjp8tAZjw==",
       "dev": true,
       "license": "Apache-2.0",
       "dependencies": {
-        "@alfresco/js-api": ">=9.4.0-21916318527",
+        "@alfresco/js-api": ">=9.4.0-22182348850",
         "ejs": "^3.1.10",
         "license-checker": "^25.0.1",
         "node-fetch": "^2.7.0",
@@ -121,16 +121,16 @@
       }
     },
     "node_modules/@alfresco/adf-content-services": {
-      "version": "8.4.0-21916318527",
-      "resolved": "https://registry.npmjs.org/@alfresco/adf-content-services/-/adf-content-services-8.4.0-21916318527.tgz",
-      "integrity": "sha512-Z4ooKxIpfTasMRq2QxIvIRHYkn1sywZdPf2R3oBeRAJq2IQygO8Rp2E9WhPxm+xFgyafLM75z0t5Kd6ZUpLWDA==",
+      "version": "8.4.0-22182348850",
+      "resolved": "https://registry.npmjs.org/@alfresco/adf-content-services/-/adf-content-services-8.4.0-22182348850.tgz",
+      "integrity": "sha512-43HRQdZ0Ff49gF0s8D1kMuD85B9zkYIr58wTwO6g36Rxu5O4iGqhDnLg7KrhaA3pV9IMQmfixVCAXJAHltyeYw==",
       "license": "Apache-2.0",
       "dependencies": {
         "tslib": "^2.3.0"
       },
       "peerDependencies": {
-        "@alfresco/adf-core": ">=8.4.0-21916318527",
-        "@alfresco/js-api": ">=9.4.0-21916318527",
+        "@alfresco/adf-core": ">=8.4.0-22182348850",
+        "@alfresco/js-api": ">=9.4.0-22182348850",
         "@angular/animations": ">=14.1.3",
         "@angular/cdk": ">=14.1.2",
         "@angular/common": ">=14.1.3",
@@ -145,9 +145,9 @@
       }
     },
     "node_modules/@alfresco/adf-core": {
-      "version": "8.4.0-21916318527",
-      "resolved": "https://registry.npmjs.org/@alfresco/adf-core/-/adf-core-8.4.0-21916318527.tgz",
-      "integrity": "sha512-DNkR+UH51drG3V/PNR0B87tTEockFxBoxPWMl7ZgxfPaJRyztXlQIdkXMB0P2GsUGteK4gGkWpzhHpHFjFrsVA==",
+      "version": "8.4.0-22182348850",
+      "resolved": "https://registry.npmjs.org/@alfresco/adf-core/-/adf-core-8.4.0-22182348850.tgz",
+      "integrity": "sha512-KWATXfrqjaXKO0s5mnIIqAD5la0LkaSuBdUpbBonZsBTPvM5tQzGq42y8NJYatFAGrYfsrSKJCOCsEYe4dN1Xw==",
       "license": "Apache-2.0",
       "peer": true,
       "dependencies": {
@@ -159,8 +159,8 @@
         "tslib": "^2.3.0"
       },
       "peerDependencies": {
-        "@alfresco/adf-extensions": ">=8.4.0-21916318527",
-        "@alfresco/js-api": ">=9.4.0-21916318527",
+        "@alfresco/adf-extensions": ">=8.4.0-22182348850",
+        "@alfresco/js-api": ">=9.4.0-22182348850",
         "@angular/animations": ">=16.0.0",
         "@angular/cdk": ">=16.0.0",
         "@angular/common": ">=16.0.0",
@@ -193,30 +193,30 @@
       }
     },
     "node_modules/@alfresco/adf-extensions": {
-      "version": "8.4.0-21916318527",
-      "resolved": "https://registry.npmjs.org/@alfresco/adf-extensions/-/adf-extensions-8.4.0-21916318527.tgz",
-      "integrity": "sha512-sZAOWCcl6OnA3P451ExI/2U4cuAQNFHZAtz66pj+38oQUFZZpRPFMUFdZQJh2JEImUrKhIORyaICcdzDc+fcfA==",
+      "version": "8.4.0-22182348850",
+      "resolved": "https://registry.npmjs.org/@alfresco/adf-extensions/-/adf-extensions-8.4.0-22182348850.tgz",
+      "integrity": "sha512-ubKOcs9c1u5krQgMu7A3RgksVfLiJZNZM4x0yQOsm8wvNeZ0y95FZXdVw50GPx6FKeXE4SH3//YwwCgNvqvRQw==",
       "license": "Apache-2.0",
       "peer": true,
       "dependencies": {
         "tslib": "^2.3.0"
       },
       "peerDependencies": {
-        "@alfresco/js-api": ">=9.4.0-21916318527",
+        "@alfresco/js-api": ">=9.4.0-22182348850",
         "@angular/common": ">=14.1.3",
         "@angular/core": ">=14.1.3"
       }
     },
     "node_modules/@alfresco/eslint-plugin-eslint-angular": {
-      "version": "8.4.0-21916318527",
-      "resolved": "https://registry.npmjs.org/@alfresco/eslint-plugin-eslint-angular/-/eslint-plugin-eslint-angular-8.4.0-21916318527.tgz",
-      "integrity": "sha512-YatXVKxIb83wbNFXvYniTPMmq2Hes4uHUzDtkoswhah1YcbwadKTCElkVht7wXvccL8TeKX4RyM9w2c+fmoq8g==",
+      "version": "8.4.0-22182348850",
+      "resolved": "https://registry.npmjs.org/@alfresco/eslint-plugin-eslint-angular/-/eslint-plugin-eslint-angular-8.4.0-22182348850.tgz",
+      "integrity": "sha512-n0QRqI9Pp08Djf6yjq47bO5i892XO4HzZY91rkdpkI+lPNho6rrzWue/9jBTxTtyTzk6RmXyHmIe2QZkyx5bsQ==",
       "license": "Apache-2.0"
     },
     "node_modules/@alfresco/js-api": {
-      "version": "9.4.0-21916318527",
-      "resolved": "https://registry.npmjs.org/@alfresco/js-api/-/js-api-9.4.0-21916318527.tgz",
-      "integrity": "sha512-hhM+d4L8BErp3N1FY1/RemJ0GOP5wCRhV1b/uku1eSMjQd1kvwVZ+aNvBmKNo8hUCQGtdSnwDlm55tQhBjK1LQ==",
+      "version": "9.4.0-22182348850",
+      "resolved": "https://registry.npmjs.org/@alfresco/js-api/-/js-api-9.4.0-22182348850.tgz",
+      "integrity": "sha512-0WIdQexoUfEMTcqQvbBERAZJEHh9c/YvY1dPbkv9qS9IJT4j9Y1ornzxZY6wi0/bcMWI9g6JsgAfMxZ7u4wNYw==",
       "license": "Apache-2.0",
       "peer": true,
       "dependencies": {

package.json

@@ -41,11 +41,11 @@
   },
   "private": true,
   "dependencies": {
-    "@alfresco/adf-content-services": "8.4.0-21916318527",
-    "@alfresco/adf-core": "8.4.0-21916318527",
-    "@alfresco/adf-extensions": "8.4.0-21916318527",
-    "@alfresco/eslint-plugin-eslint-angular": "8.4.0-21916318527",
-    "@alfresco/js-api": "9.4.0-21916318527",
+    "@alfresco/adf-content-services": "8.4.0-22182348850",
+    "@alfresco/adf-core": "8.4.0-22182348850",
+    "@alfresco/adf-extensions": "8.4.0-22182348850",
+    "@alfresco/eslint-plugin-eslint-angular": "8.4.0-22182348850",
+    "@alfresco/js-api": "9.4.0-22182348850",
     "@angular/animations": "19.2.18",
     "@angular/cdk": "19.2.18",
     "@angular/common": "19.2.18",
@@ -78,7 +78,7 @@
     "zone.js": "0.15.0"
   },
   "devDependencies": {
-    "@alfresco/adf-cli": "8.4.0-21916318527",
+    "@alfresco/adf-cli": "8.4.0-22182348850",
     "@angular-devkit/build-angular": "19.2.19",
     "@angular-devkit/core": "19.2.18",
     "@angular-devkit/schematics": "19.2.18",

projects/aca-content/src/lib/components/dl-custom-components/name-column/name-column.component.ts

@@ -23,7 +23,7 @@
  */
 
 import { NameColumnComponent, NodesApiService } from '@alfresco/adf-content-services';
-import { ChangeDetectorRef, Component, DestroyRef, ElementRef, inject, OnInit, ViewEncapsulation } from '@angular/core';
+import { ChangeDetectorRef, Component, DestroyRef, inject, OnInit, ViewEncapsulation } from '@angular/core';
 import { Actions, ofType } from '@ngrx/effects';
 import { filter } from 'rxjs/operators';
 import { NodeActionTypes } from '@alfresco/aca-shared/store';
@@ -48,15 +48,9 @@ export class CustomNameColumnComponent extends NameColumnComponent implements On
   isFileWriteLocked: boolean;
 
   private readonly destroy = inject(DestroyRef);
-
-  constructor(
-    element: ElementRef,
-    private readonly cd: ChangeDetectorRef,
-    private readonly actions$: Actions,
-    private readonly nodesService: NodesApiService
-  ) {
-    super(element, nodesService);
-  }
+  private readonly cd = inject(ChangeDetectorRef);
+  private readonly actions$ = inject(Actions);
+  private readonly nodesService = inject(NodesApiService);
 
   ngOnInit() {
     this.updateValue();

projects/aca-content/src/lib/components/search/search-save/list/ui-list/saved-searches-list.ui-component.ts

@@ -35,7 +35,6 @@ import {
   ViewEncapsulation
 } from '@angular/core';
 import {
-  AppConfigService,
   DataCellEvent,
   DATATABLE_DIRECTIVES,
   DataTableComponent,
@@ -101,13 +100,12 @@ export class SavedSearchesListUiComponent extends DataTableSchema implements Aft
     }
   ];
 
-  constructor(
-    protected appConfig: AppConfigService,
-    private readonly clipboard: Clipboard,
-    private readonly router: Router,
-    private readonly hostElement: ElementRef<HTMLElement>
-  ) {
-    super(appConfig, '', savedSearchesListSchema);
+  private readonly clipboard = inject(Clipboard);
+  private readonly router = inject(Router);
+  private readonly hostElement: ElementRef<HTMLElement> = inject(ElementRef);
+
+  constructor() {
+    super('', savedSearchesListSchema);
   }
 
   ngAfterContentInit() {
@@ -115,7 +113,7 @@ export class SavedSearchesListUiComponent extends DataTableSchema implements Aft
     this.contextMenuAction$.pipe(takeUntilDestroyed(this.destroyRef)).subscribe((action) => this.executeMenuOption(action.key, action.data));
   }
 
-  @HostListener('document:keydown.escape', ['$event'])
+  @HostListener('document:keydown.escape')
   onEscapeKeydown() {
     const contextMenu = document.querySelector<HTMLElement>('.adf-context-menu');
     if (contextMenu) {

projects/aca-content/src/lib/dialogs/node-details/node-information.component.ts

@@ -24,7 +24,7 @@
 
 import { Component, DestroyRef, inject, OnInit, ViewEncapsulation } from '@angular/core';
 import { CommonModule, NgOptimizedImage } from '@angular/common';
-import { DIALOG_COMPONENT_DATA, LocalizedDatePipe, TimeAgoPipe, IconComponent, FileSizePipe, TranslationService } from '@alfresco/adf-core';
+import { DIALOG_COMPONENT_DATA, LocalizedDatePipe, TimeAgoPipe, IconComponent, FileSizePipe } from '@alfresco/adf-core';
 import { Node, SizeDetails } from '@alfresco/js-api';
 import { MatDividerModule } from '@angular/material/divider';
 import { TranslatePipe, TranslateService } from '@ngx-translate/core';
@@ -47,6 +47,7 @@ class NodeDetails {
 @Component({
   selector: 'app-node-info',
   imports: [CommonModule, MatDividerModule, TimeAgoPipe, TranslatePipe, LocalizedDatePipe, IconComponent, NgOptimizedImage],
+  providers: [FileSizePipe],
   templateUrl: './node-information.component.html',
   styleUrls: ['./node-information.component.scss'],
   encapsulation: ViewEncapsulation.None,
@@ -56,10 +57,9 @@ export class NodeInformationComponent implements OnInit {
   readonly contentService = inject(ContentService);
   readonly nodesService = inject(NodesApiService);
   readonly translateService = inject(TranslateService);
-  readonly translationService = inject(TranslationService);
 
   private readonly destroyRef = inject(DestroyRef);
-  private readonly fileSizePipe = new FileSizePipe(this.translationService);
+  private readonly fileSizePipe = inject(FileSizePipe);
 
   node: Node = inject(DIALOG_COMPONENT_DATA);
   nodeDetails = new NodeDetails();

projects/aca-content/src/lib/services/content-url.service.ts

@@ -22,24 +22,19 @@
  * from Hyland Software. If not, see <http://www.gnu.org/licenses/>.
  */
 
-import { Injectable } from '@angular/core';
+import { inject, Injectable } from '@angular/core';
 import { Observable, of } from 'rxjs';
 import { AppStore, getRepositoryStatus } from '@alfresco/aca-shared/store';
 import { take, map, catchError, mergeMap } from 'rxjs/operators';
 import { Store } from '@ngrx/store';
 import { ContentApiService } from '@alfresco/aca-shared';
 import { DirectAccessUrlEntry } from '@alfresco/js-api';
-import { AlfrescoApiService, ContentVersionService } from '@alfresco/adf-content-services';
+import { ContentVersionService } from '@alfresco/adf-content-services';
 
 @Injectable({ providedIn: 'root' })
 export class ContentUrlService extends ContentVersionService {
-  constructor(
-    private store: Store<AppStore>,
-    private contentApiService: ContentApiService,
-    alfrescoApiService: AlfrescoApiService
-  ) {
-    super(alfrescoApiService);
-  }
+  private readonly store = inject(Store<AppStore>);
+  private readonly contentApiService = inject(ContentApiService);
 
   getNodeContentUrl(nodeId: string, attachment = true): Observable<string> {
     return this.isDirectAccessUrlEnabled().pipe(

projects/aca-content/src/lib/services/node-actions.service.ts

@@ -40,7 +40,7 @@ import { NodeEntry, Node, SitePaging, NodeChildAssociationPaging, NodeChildAssoc
 import { ContentApiService } from '@alfresco/aca-shared';
 import { catchError, map, mergeMap } from 'rxjs/operators';
 
-type BatchOperationType = Extract<NodeAction, NodeAction.COPY | NodeAction.MOVE>;
+type BatchOperationType = Extract<NodeAction, 'COPY' | 'MOVE'>;
 
 @Injectable({
   providedIn: 'root'

projects/aca-shared/src/lib/components/document-base-page/document-base-page.component.ts

@@ -71,7 +71,7 @@ export abstract class PageComponent implements OnInit, OnDestroy, OnChanges {
   canUpdateNode = false;
   canUpload = false;
   nodeResult: NodePaging;
-  showHeader = ShowHeaderMode.Data;
+  showHeader: ShowHeaderMode = ShowHeaderMode.Data;
   filterSorting = 'name-asc';
   createActions: ContentActionRef[] = [];
   isSmallScreen = false;