[ACA-1638] refactor sharedLinksApi to use alfresco-js-api (#547)

* refactor sharedLinksApi to use alfresco-js-api

* update package-lock.json

* re-created package-lock.json file

* update package-lock

* spellcheck fixes

cspell.json

@@ -3,6 +3,7 @@
     "language": "en",
     "words": [
         "succes",
+        "sharedlinks",
 
         "ngrx",
         "ngstack",

e2e/utilities/repo-client/apis/repo-api-new.ts

@@ -0,0 +1,46 @@
+/*!
+ * @license
+ * Alfresco Example Content Application
+ *
+ * Copyright (C) 2005 - 2018 Alfresco Software Limited
+ *
+ * This file is part of the Alfresco Example Content Application.
+ * If the software was purchased under a paid Alfresco license, the terms of
+ * the paid license agreement will prevail.  Otherwise, the software is
+ * provided under the following open source license terms:
+ *
+ * The Alfresco Example Content Application is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Lesser General Public License as published by
+ * the Free Software Foundation, either version 3 of the License, or
+ * (at your option) any later version.
+ *
+ * The Alfresco Example Content Application is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU Lesser General Public License for more details.
+ *
+ * You should have received a copy of the GNU Lesser General Public License
+ * along with Alfresco. If not, see <http://www.gnu.org/licenses/>.
+ */
+
+import * as AlfrescoApi from 'alfresco-js-api-node';
+import { REPO_API_HOST } from '../../../configs';
+import { RepoClientAuth } from '../repo-client-models';
+
+export abstract class RepoApiNew {
+
+    alfrescoJsApi = new AlfrescoApi({
+        provider: 'ECM',
+        hostEcm: REPO_API_HOST
+    });
+
+    constructor(
+        private username: string = RepoClientAuth.DEFAULT_USERNAME,
+        private password: string = RepoClientAuth.DEFAULT_PASSWORD
+    ) {}
+
+    apiAuth() {
+        return this.alfrescoJsApi.login(this.username, this.password);
+    }
+
+}

e2e/utilities/repo-client/apis/shared-links/shared-links-api.ts

@@ -23,55 +23,52 @@
  * along with Alfresco. If not, see <http://www.gnu.org/licenses/>.
  */
 
-import { RepoApi } from '../repo-api';
-import { NodesApi } from '../nodes/nodes-api';
-import { RepoClient } from './../../repo-client';
+import { RepoApiNew } from '../repo-api-new';
 import { Utils } from '../../../../utilities/utils';
 
-export class SharedLinksApi extends RepoApi {
+export class SharedLinksApi extends RepoApiNew {
 
-    shareFileById(id: string): Promise<any> {
-        const data = [{ nodeId: id }];
-
-        return this.post(`/shared-links`, { data })
-            .catch(this.handleError);
+    constructor(username?, password?) {
+        super(username, password);
     }
 
-    shareFilesByIds(ids: string[]): Promise<any[]> {
-        return ids.reduce((previous, current) => (
-            previous.then(() => this.shareFileById(current))
-        ), Promise.resolve());
+    async shareFileById(id: string) {
+        await this.apiAuth();
+        const data = { nodeId: id };
+        return await this.alfrescoJsApi.core.sharedlinksApi.addSharedLink(data);
     }
 
-    getSharedIdOfNode(name: string) {
-        return this.getSharedLinks()
-            .then(resp => resp.data.list.entries.find(entries => entries.entry.name === name))
-            .then(resp => resp.entry.id)
-            .catch(this.handleError);
+    async shareFilesByIds(ids: string[]) {
+        return await ids.reduce(async (previous: any, current: any) => {
+            await previous;
+            return await this.shareFileById(current);
+        }, Promise.resolve());
     }
 
-    unshareFile(name: string) {
-        return this.getSharedIdOfNode(name)
-            .then(id => this.delete(`/shared-links/${id}`))
-            .catch(this.handleError);
+    async getSharedIdOfNode(name: string) {
+        const sharedLinks = (await this.getSharedLinks()).list.entries;
+        const found = sharedLinks.find(sharedLink => sharedLink.entry.name === name);
+        return (found || { entry: { id: null } }).entry.id;
     }
 
-    getSharedLinks(): Promise<any> {
-        return this.get(`/shared-links`)
-            .catch(this.handleError);
+    async unshareFile(name: string) {
+        const id = await this.getSharedIdOfNode(name);
+        return await this.alfrescoJsApi.core.sharedlinksApi.deleteSharedLink(id);
     }
 
-    waitForApi(data) {
-        const sharedFiles = () => {
-            return this.getSharedLinks()
-                .then(response => response.data.list.pagination.totalItems)
-                .then(totalItems => {
-                    if ( totalItems < data.expect) {
-                        return Promise.reject(totalItems);
-                    } else {
-                        return Promise.resolve(totalItems);
-                    }
-                });
+    async getSharedLinks() {
+        await this.apiAuth();
+        return await this.alfrescoJsApi.core.sharedlinksApi.findSharedLinks();
+    }
+
+    async waitForApi(data) {
+        const sharedFiles = async () => {
+            const totalItems = (await this.getSharedLinks()).list.pagination.totalItems;
+            if ( totalItems < data.expect ) {
+                return Promise.reject(totalItems);
+            } else {
+                return Promise.resolve(totalItems);
+            }
         };
 
         return Utils.retryCall(sharedFiles);

e2e/utilities/repo-client/repo-client.ts

@@ -34,14 +34,6 @@ import { TrashcanApi } from './apis/trashcan/trashcan-api';
 import { SearchApi } from './apis/search/search-api';
 
 export class RepoClient {
-    public people: PeopleApi = new PeopleApi(this.auth, this.config);
-    public nodes: NodesApi = new NodesApi(this.auth, this.config);
-    public sites: SitesApi = new SitesApi(this.auth, this.config);
-    public favorites: FavoritesApi = new FavoritesApi(this.auth, this.config);
-    public shared: SharedLinksApi = new SharedLinksApi(this.auth, this.config);
-    public trashcan: TrashcanApi = new TrashcanApi(this.auth, this.config);
-    public search: SearchApi = new SearchApi(this.auth, this.config);
-
     constructor(
         private username: string = RepoClientAuth.DEFAULT_USERNAME,
         private password: string = RepoClientAuth.DEFAULT_PASSWORD,
@@ -52,6 +44,34 @@ export class RepoClient {
         const { username, password } = this;
         return { username, password };
     }
+
+    get people () {
+        return new PeopleApi(this.auth, this.config);
+    }
+
+    get nodes() {
+        return new NodesApi(this.auth, this.config);
+    }
+
+    get sites() {
+        return new SitesApi(this.auth, this.config);
+    }
+
+    get favorites() {
+        return new FavoritesApi(this.auth, this.config);
+    }
+
+    get shared() {
+        return new SharedLinksApi(this.auth.username, this.auth.password);
+    }
+
+    get trashcan() {
+        return new TrashcanApi(this.auth, this.config);
+    }
+
+    get search() {
+        return new SearchApi(this.auth, this.config);
+    }
 }
 
 export * from './apis/nodes/node-body-create';

package.json

@@ -49,6 +49,7 @@
     "@ngrx/store-devtools": "^5.2.0",
     "@ngx-translate/core": "9.1.1",
     "alfresco-js-api": "2.5.0-d5acbab9993711f37b66351a6aaedf6fc72d1ce2",
+    "alfresco-js-api-node": "2.5.0-d5acbab9993711f37b66351a6aaedf6fc72d1ce2",
     "core-js": "2.5.3",
     "cspell": "^2.1.12",
     "hammerjs": "2.0.8",