inteligr8/alfresco-content-app
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-content-app.git synced 2026-09-09 18:02:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

[MNT-25522] display N/A for size and number of files for links in info dialog (#5203)

Browse Source
This commit is contained in:
Mykyta Maliarchuk
2026-05-28 13:11:53 +02:00
committed by GitHub
parent 2825ece875
commit 630f34988a
3 changed files with 67 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
projects/aca-content/assets/i18n/en.json
+1
View File
@@ -505,6 +505,7 @@
"SIZE": "Size",
"NUMBER_OF_FILES": "Number of files",
"CALCULATING": "Calculating...",
"NOT_AVAILABLE": "N/A",
"LOCATION": "Location",
"REFERENCED": "Referenced",
"CREATED": "Created",
projects/aca-content/src/lib/dialogs/node-details/node-information.component.spec.ts
+59
View File
@@ -72,6 +72,29 @@ describe('NodeInformationComponent', () => {
createdAt: new Date(2024, 1, 1, 11, 11),
modifiedAt: new Date(2024, 2, 2, 22, 22)
} as Node;
const mockFileLink = {
name: 'mock-file-link',
id: 'mock-file-link-id',
nodeType: 'app:filelink',
path: {
name: 'mock-file-link-path'
},
isFolder: false,
isFile: true,
createdAt: new Date(2024, 1, 1, 11, 11),
modifiedAt: new Date(2024, 2, 2, 22, 22)
} as Node;
const mockFolderLink = {
name: 'mock-folder-link',
id: 'mock-folder-link-id',
nodeType: 'app:folderlink',
path: {
name: 'mock-folder-link-path'
},
isFolder: true,
createdAt: new Date(2024, 1, 1, 11, 11),
modifiedAt: new Date(2024, 2, 2, 22, 22)
} as Node;
const mockSizeDetailsEntry: SizeDetailsEntry = {
entry: {
id: 'mock-id',
@@ -242,4 +265,40 @@ describe('NodeInformationComponent', () => {
expect(secondaryPaths[1].nativeElement.innerText).toBe('mock-other-secondary-parent-path');
});
});
describe('link nodes', () => {
const setupLinkNode = (node: Node) => {
TestBed.overrideProvider(DIALOG_COMPONENT_DATA, { useValue: node });
fixture = TestBed.createComponent(NodeInformationComponent);
nodeService = TestBed.inject(NodesApiService);
unitTestingUtils = new UnitTestingUtils(fixture.debugElement);
};
it('should display N/A for size and not make size API calls for file link', () => {
setupLinkNode(mockFileLink);
spyOn(nodeService, 'listParents').and.returnValue(of({ list: { entries: [] } } as NodeAssociationPaging));
spyOn(nodeService, 'initiateFolderSizeCalculation');
fixture.detectChanges();
expect(getNodeName()).toBe('mock-file-link');
expect(getNodeSize()).toBe('APP.NODE_INFO.NOT_AVAILABLE');
expect(getNodeLocation()).toBe('mock-file-link-path');
expect(getNodeCreationDate()).toBe('2/1/24, 11:11 AM');
expect(getNodeModifyDate()).toBe('3/2/24, 10:22 PM');
expect(nodeService.initiateFolderSizeCalculation).not.toHaveBeenCalled();
});
it('should display N/A for size and number of files and not make size API calls for folder link', () => {
setupLinkNode(mockFolderLink);
spyOn(nodeService, 'listParents').and.returnValue(of({ list: { entries: [] } } as NodeAssociationPaging));
spyOn(nodeService, 'initiateFolderSizeCalculation');
fixture.detectChanges();
expect(getNodeName()).toBe('mock-folder-link');
expect(getNodeSize()).toBe('APP.NODE_INFO.NOT_AVAILABLE');
expect(getNumberOfFiles()).toBe('APP.NODE_INFO.NOT_AVAILABLE');
expect(getNodeLocation()).toBe('mock-folder-link-path');
expect(getNodeCreationDate()).toBe('2/1/24, 11:11 AM');
expect(getNodeModifyDate()).toBe('3/2/24, 10:22 PM');
expect(nodeService.initiateFolderSizeCalculation).not.toHaveBeenCalled();
});
});
});
projects/aca-content/src/lib/dialogs/node-details/node-information.component.ts
+7
View File
@@ -79,6 +79,13 @@ export class NodeInformationComponent implements OnInit {
.subscribe((parents) => {
this.nodeDetails.secondaryParentsPaths = parents != null ? parents.list.entries.map((entry) => entry.entry.path.name) : [];
});
if (this.node.nodeType === 'app:filelink' || this.node.nodeType === 'app:folderlink') {
this.nodeDetails.size = this.translateService.instant('APP.NODE_INFO.NOT_AVAILABLE');
if (this.node.isFolder) {
this.nodeDetails.numberOfFiles = this.translateService.instant('APP.NODE_INFO.NOT_AVAILABLE');
}
return;
}
if (this.node.isFolder) {
this.nodeDetails.size = this.translateService.instant('APP.NODE_INFO.CALCULATING');
this.nodeDetails.numberOfFiles = this.translateService.instant('APP.NODE_INFO.CALCULATING');