[ACA-4339] Libraries - Delete action for non-site members is rendered (#2046)

* show selection action only if role is manager

* update expectation data

* differentiate actions between member and non member
This commit is contained in:
Cilibiu Bogdan 2021-03-25 15:27:20 +02:00 committed by GitHub
parent 5f0879f9ee
commit b981d24595
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 11 additions and 9 deletions

View File

@ -34,8 +34,10 @@ export const trashActions = ['Permanently Delete', 'Restore'];
const memberFavContextMenu = ['Leave Library', 'Delete', 'Remove Favorite'];
const memberNotFavContextMenu = ['Leave Library', 'Delete', 'Favorite'];
const memberToolbarPrimary = ['Leave Library', 'View Details', 'More Actions'];
const favToolbarMore = ['Delete', 'Remove Favorite'];
const notFavToolbarMore = ['Delete', 'Favorite'];
const favToolbarMore = ['Remove Favorite'];
const notFavToolbarMore = ['Favorite'];
const memberFavToolbarMore = ['Delete', 'Remove Favorite'];
const memberNotFavToolbarMore = ['Delete', 'Favorite'];
const searchMemberToolbarPrimary = ['Toggle search filter', 'Leave Library', 'View Details', 'More Actions'];
const searchReqJoinToolbarPrimary = ['Toggle search filter', 'Cancel Join Request', 'More Actions'];
const searchNotMemberToolbarPrimary = ['Toggle search filter', 'Join', 'More Actions'];
@ -51,7 +53,7 @@ export const publicUserMemberFav = {
description: 'public site, user member, user favorite',
contextMenu: memberFavContextMenu,
toolbarPrimary: memberToolbarPrimary,
toolbarMore: favToolbarMore,
toolbarMore: memberFavToolbarMore,
searchToolbarPrimary: searchMemberToolbarPrimary
};
@ -61,7 +63,7 @@ export const privateUserMemberFav = {
description: 'private site, user member, user favorite',
contextMenu: memberFavContextMenu,
toolbarPrimary: memberToolbarPrimary,
toolbarMore: favToolbarMore,
toolbarMore: memberFavToolbarMore,
searchToolbarPrimary: searchMemberToolbarPrimary
};
@ -71,7 +73,7 @@ export const moderatedUserMemberFav = {
description: 'moderated site, user member, user favorite',
contextMenu: memberFavContextMenu,
toolbarPrimary: memberToolbarPrimary,
toolbarMore: favToolbarMore,
toolbarMore: memberFavToolbarMore,
searchToolbarPrimary: searchMemberToolbarPrimary
};
@ -81,7 +83,7 @@ export const publicUserMemberNotFav = {
description: 'public site, user member, not favorite',
contextMenu: memberNotFavContextMenu,
toolbarPrimary: memberToolbarPrimary,
toolbarMore: notFavToolbarMore,
toolbarMore: memberNotFavToolbarMore,
searchToolbarPrimary: searchMemberToolbarPrimary
};
@ -91,7 +93,7 @@ export const privateUserMemberNotFav = {
description: 'private site, user member, not favorite',
contextMenu: memberNotFavContextMenu,
toolbarPrimary: memberToolbarPrimary,
toolbarMore: notFavToolbarMore,
toolbarMore: memberNotFavToolbarMore,
searchToolbarPrimary: searchMemberToolbarPrimary
};
@ -101,7 +103,7 @@ export const moderatedUserMemberNotFav = {
description: 'moderated site, user member, not favorite',
contextMenu: memberNotFavContextMenu,
toolbarPrimary: memberToolbarPrimary,
toolbarMore: notFavToolbarMore,
toolbarMore: memberNotFavToolbarMore,
searchToolbarPrimary: searchMemberToolbarPrimary
};

View File

@ -560,7 +560,7 @@
"click": "DELETE_LIBRARY"
},
"rules": {
"visible": "app.selection.library"
"visible": "app.toolbar.favorite.canEditMetadata"
}
}
]