31 Commits
Author SHA1 Message Date
swapnil-verma-gl 4357fe9c08 [ACS-8694] Re-introduce visibility rules cleanup (#4516)
* [ACS-8694] Cleanup of visibility rules for extensions in ACA (#4140)

* [ACS-9369] Resolved issues where visibility rules with a single element array would log errors (#4416)

* [ACS-9369] Resolved issues where visibility rules with a single element array would log errors

* [ACS-9369] Improved rule array filtering logic

* [ACS-9369] Added type to variable

(cherry picked from commit 4e33f1126d)

* [ACS-8694] Removed unneeded test cases

* [ACS-8694] Fixed 'Favorite' option showing up in toolbar when opening search page
2025-05-15 10:44:00 +02:00
swapnil-verma-gl 9a8a45479e [ACS-9388] Print button is now hidden for media files (#4495) 2025-04-02 15:56:13 +05:30
swapnil-verma-gl ba75c0b233 [ACS-9466] Folder information dialog no longer displays error message if response returned from API is "IN_PROGRESS' (#4498)
* [ACS-9466] Added delay between folder size initiation and folder size retrieval APIs. Added case to check if folder size calculation is in progress or not, before displaying error message. Updated unit test

* [ACS-9466] Added unit test

* [ACS-9466] Updated unit test

* [ACS-9466] E2Es should now use latest version of alfresco content repository on GHA
2025-04-02 15:46:58 +05:30
swapnil-verma-gl 8c1d2f3cd7 Fixed configuration issue preventing unit tests for rules getting executed (#4466)
* Fixed configuration issue preventing unit tests for rules getting executed

* Added unit tests for SnackbarEffects to improve coverage

* Added unit tests for RouterEffects to improve coverage

* Excluding store actions, models, selectors and states from getting included in code coverage

* Added type to store
2025-03-21 15:44:12 +05:30
swapnil-verma-gl 1ef1976a4c [ACS-9388] Print button is now disabled in viewer for media files (#4465)
* [ACS-9388] Print button is now disabled in viewer for media files

* [ACS-9388] Added canPrintFile rule to documentation. Code review fixes
2025-03-20 14:16:30 +05:30
swapnil-verma-gl 2efea8c6d8 Rollback visibility rules cleanup (#4426)
* Revert "[ACS-9369] Updated rule-migration-guide.md to include missed rule (#4420)"

This reverts commit b3e2af7f0f.

* Revert "[ACS-9369] Resolved issues where visibility rules with a single element array would log errors (#4416)"

This reverts commit 4e33f1126d.

* Revert "[ACS-8694] Cleanup of visibility rules for extensions in ACA (#4140)"

This reverts commit f1c4dcf45d.
2025-03-03 16:56:13 +05:30
swapnil-verma-gl b3e2af7f0f [ACS-9369] Updated rule-migration-guide.md to include missed rule (#4420) 2025-02-28 13:17:26 +05:30
swapnil-verma-gl 4e33f1126d [ACS-9369] Resolved issues where visibility rules with a single element array would log errors (#4416)
* [ACS-9369] Resolved issues where visibility rules with a single element array would log errors

* [ACS-9369] Improved rule array filtering logic

* [ACS-9369] Added type to variable
2025-02-27 17:20:43 +05:30
swapnil-verma-gl f1c4dcf45d [ACS-8694] Cleanup of visibility rules for extensions in ACA (#4140)
* [ACS-8694] Updated occurrences of visible in extensions.json to use arrays instead of single strings. Cleaned up rules in aca-content.module.ts

* [ACS-8694] Removed extra commas

* [ACS-8694] Broke down canDelete rule into seperate entities

* [ACS-8694] Fixed typo for notEmpty rule

* [ACS-8694] Fixed rule for edit offline

* [ACS-8694] Updated extension.schema.json

* [ACS-8694] Updated extension.schema.json

* [ACS-8694] Fixed rule for manage versions context menu item

* [ACS-8694] Fixed rule for manage versions and manage permissions

* [ACS-8694] Added rules.canManageFolderRules

* [ACS-8694] Fixed typo

* [ACS-8694] Updated visibility rules for folder rules and AOS plugin

* [ACS-8694] Updated extension.schema.json

* [ACS-8694] Updated existing rules to use !isTrashcan() instead of isNotTrashcan()

* [ACS-8694] folder-rules.plugin.json now uses arrays for controlling visibility

* [ACS-8694] Updated app.extensions.schema

* [ACS-8694] Removed unused rules

* [ACS-8694] Added unit tests for canToggleFileLock

* [ACS-8694] Added rules-list.md

* [ACS-8694] Revert unneeded project.json change

* [ACS-8694] Fixed toggleEditOffline rule

* [ACS-8694] Added migration guide (#4139)

* [ACS-8694] Added migration guide

* [ACS-8694] Fixed typo

* [ACS-8694] Added missing rule migration. Fixed incorrect rule migration. Fixed typos

* [ACS-8694] Code review finding - Replaced instance of any

* [ACS-8694] Code review finding - Updated rules.md. Removed duplication of rules list from rules-list.md. Added pointer to rules-list.md under tips section

* [ACS-8694] Fixed build issue

* [ACS-8694] Removed unneeded isNotDetails rule
2025-02-25 17:00:22 +05:30
swapnil-verma-gl 02caa7acbd [ACS-9119] Saved Search navbar title now gets translated (#4356)
* [ACS-9119] Fixed issue where Saved Search Nav Bar title was not getting updated on changing language

* [ACS-9119] Added unit test

* [ACS-9119] Added null safety check

* [ACS-9119] Addressed PR comments

* [ACS-9119] Fixed Unit test
2025-01-29 15:24:30 +05:30
swapnil-verma-gl d30c933259 [MNT-24575] Added dialog to display folder information (#4282)
* [MNT-24575] Created folder information dialog

* [MNT-24575] Added unit tests

* [MNT-24575] Integrated API calls into folder information

* [MNT-24575] Added models

* [MNT-24575] Added delay to API retry call. Added unit test for API retry functionality

* [MNT-24575] Folder information is no longer shown in trashcan

* [MNT-24575] Folder information is no longer shown in trashcan

* [MNT-24575] Added return type to function. Consolidated different properties into a single type

* [MNT-24575] Addressed Code review comments

* [MNT-24575] Addressed code review findings. Added error handling and unit tests

* [MNT-24575] Updated template to use adf-icons

* [MNT-24575] Using variables in SCSS
2025-01-17 15:52:18 +05:30
swapnil-verma-gl 03e505a898 [ACS-8902] Fixed incorrect icon for join library option (#4310) 2024-12-23 13:02:56 +05:30
swapnil-verma-gl 111f3f99e8 [ACS-8998] Added validation to search input to disallow certain special characters (#4253)
* [ACS-8998] Added validation to search input to disallow certain special characters

* [ACS-8998] Search input now replaces text: with TEXT: on submit, instead of giving a validation error

* [ACS-8998] Reverted unneeded padding change

* [ACS-8998] Calling search term getter instead of searchFormControl.value directly
2024-12-18 12:37:33 +05:30
swapnil-verma-gl 7985f76b5d Post release version bump (#4250)
* Post release version bump for aca-content and aca-shared

* Post release version bump

* Fixed dependency versions
2024-11-21 15:38:57 +05:30
swapnil-verma-gl dec6c41e5c Release 5.2.0 (#4249)
* Release 5.2.0

* Fixed build issue

* Updated correct dependency versions. Updated compatibility matrix to denote correct ACS version
2024-11-21 13:47:52 +05:30
swapnil-verma-gl cad7355241 [ACS-8450] Fixed issue where required marker * was not showing up for create rule > Name field (#3984)
* [ACS-8450] Fixed issue where required marker * was not showing up for creat rule > Name field

* [ACS-8450] Fixed alignment issue

* [ACS-8450] Changed styling selectors

* [ACS-8450] Added null/undefined safety check for name
2024-08-02 15:38:09 +05:30
swapnil-verma-gl 042269f325 [ACS-8453] Fixed alignment issue of reduce panel button in expanded file details (#3969) 2024-07-31 12:53:42 +05:30
swapnil-verma-gl d8dd62f4c8 [ACS-8452] Fixed UI for folder select input fields in create/edit rules (#3974) 2024-07-29 11:11:58 +05:30
swapnil-verma-gl bf95968981 [ACS-8449] Fixed alignment of close and dropdown icon in search input (#3975) 2024-07-29 11:10:53 +05:30
swapnil-verma-gl 47fb269c4d [ACS-6642] Tags column and getTags API call is now dynamic on app.config.json for search page (#3607) 2024-01-24 12:12:45 +05:30
swapnil-verma-gl dc2c7c9109 [ACS-6573] Manage permissions window can now be opened from inside file preview (#3596)
* [ACS-6573] Resolved issue where manage permissions window could not be opened when opened from inside file preview

* [ACS-6573] Fixed unit test
2024-01-12 17:42:43 +01:00
swapnil-verma-gl 339dc60d6d [ACS-6107] Updated default configuration for date-range component to be compatible with the new advanced search date range component (#3532)
* [ACS-6107] Updated default configuraiton for date-range component in extensions to match the required config for the new date range component

* [ACS-6107] Updated E2Es to remove references to old date-range component

* [ACS-6107] Restored missing column key
2023-12-26 11:14:33 +05:30
swapnil-verma-gl f917a663b7 [ACS-5014] Migrated Copy Move actions E2Es from protractor to playwright (#3531)
* [ACS-5014] Added Playwright E2E tests for copy-move actions

* [ACS-5014] Fixed missing import in tsconfig.e2e.json

* [ACS-5014] Removed unneeded method from utils.ts

* [ACS-5014] Updated playwright.config.ts

* [ACS-5014] Copy and Move tests are now working

* [ACS-5014] Removed unneeded test.only

* [ACS-5014] Added test case IDs to E2E tests

* [ACS-6211] Removed TODO note. Removed protractor test case files

* [ACS-5014] Added E2E tests for Destination Picker in copy-move actions

* [ACS-5014] Removed unneded only from test suite

* [ACS-5014] Updated import of logger from @alfresco/adf-cli to @alfresco/adf-testing

* [ACS-5014] Addressed code review findings. Moved objects to beforeAll/beforeEach wherever applicable. Added missing await.

* [ACS-5014] Addressed code review findings. Removed unused methods/objects from content-node-selector-dialog.ts

* [ACS-5014] Addressed code review findings. Removed unused methods/objects from content-node-selector-dialog.ts

* [ACS-5014] SonarLint fix

* [ACS-5014] Fixed breaking change for other E2Es

* [ACS-5014] Updated E2Es to use correct locator for more actions button
2023-12-06 16:01:48 +05:30
swapnil-verma-gl 34c8976af6 [ACS-6211] Resolved UI alignment issue in create rule dialog (#3505)
* [ACS-6211] Resolved UI alignment issue in create rule dialog

* [ACS-6211] Changed appearance of mat-select form field to standard to match with other action form fields

* [ACS-6211] Fixed unit tests

* [ACS-6138] Updating ADW Styling after ACA changes for angular material - Expansion panel items

* [ACS-6211] Fixed failing E2E
2023-12-06 13:36:00 +05:30
swapnil-verma-gl ec18f6b9cb [ACS-4130] Added autocomplete to folder rules 'Has Category' condition (#3464)
* [ACS-4130] Added autocomplete for 'Has Category' option in manage rules

* [ACS-4130] Added loading spinner and 'No options found' template for Has Category rule condition. Options are now fetched as soon as user selected 'Has Category' option

* [ACS-4130] Added code to fetch category name when viewing/editing existing rule with has category option selected

* [ACS-4130] Resolved issues related to editing existing rules with 'Has Category' condition

* [ACS-4130] Added safety checks and minor code refactoring

* [ACS-4130] Added unit tests for new autocomplete functionality

* [ACS-4130] Added feature to auto select first option from autocomplete dropdown when user focuses out of autocomplete input field

* [ACS-4130] Minor code refactoring. Moved constants from global scope to local scope

* [ACS-4130] Moved mock data to conditions.mock.ts. Removed redundant return type

* [ACS-4130] Resolved PR review comments - AutoCompleteOption is now an interface. Changed occurences of autocomplete with auto-complete. Removed/Added types

* [ACS-4130] Resolved PR review comments - AutoCompleteOption is now built using a single common helper method

* [ACS-4130] Added missed types
2023-10-11 18:00:44 +05:30
swapnil-verma-glandAleksander Sklorz 174d7b61ee [ACS-4985] Added configuration to merge created and modified date filters into a single date filter (#3324)
* ACS-4985 Prepared configuration for created and modified dates in search

* [ACS-4985] Updated search filter configuration for ACA to include the new SearchDateRangeAdvancedTabbed component

* [ACS-4985] Added date-fns adapter to alfresco content app

* [ACS-4985] Added failing e2e test cases to protractor.excludes.json

* [ACS-4985] Removed unused Created Date/Modified Date entries from i18n files after rebase

* [ACS-4985] Removed .env-original (file not required)

* [ACS-4985] Updated protractor.excludes.json

* [ACS-4794][link-adf:feature/dev-mkinas-es-migration] Fix missed test case

* Revert "[ACS-4794][link-adf:feature/dev-mkinas-es-migration] Fix missed test case"

This reverts commit d1cd0ee3de.

* [ACS-4985] Empty commit to trigger finalise job

* Revert "[ACS-4794] Fix missed test case"

This reverts commit d1cd0ee3de.

---------

Co-authored-by: Aleksander Sklorz <Aleksander.Sklorz@hyland.com>
2023-07-28 13:11:11 +05:30
swapnil-verma-gl d125fe5ff9 [ACS-5088] Replaced function calls in templates with variable references (#3227)
* [ACS-5088] Replaced method calls in templates with variables

* [ACS-5088] Replaced method calls in templates with variables

* [ACS-5088] Replaced method calls for *ngIf and *ngFor with variables - Batch 1 (WIP)

* [ACS-5088] Replaced method calls for *ngIf and *ngFor with variables - Batch 2 (WIP)

* [ACS-5088] Replaced instances of $any with cast pipe. Replaced other instances of method calls in templates with variables

* [ACS-5088] Resolved test cases

* [ACS-5088] Resolved test cases in aca-content library

* [ACS-5088] Resolved test cases in aca-shared library

* [ACS-5088] Resolved test cases in aca-folder-rules library

* [ACS-5088] Reverted usage of cast pipe to $any()

* [ACS-5088] Fixed incorrect revert

* [ACS-5088] Resolved code review findings - shortened expressions and made onDestroy subjects use void instead of boolean

* [ACS-5088] Resolved code review findings - changed parameter name in sort function

* [ACS-5088] Resolved code review findings - added 'void' type to onDestroy subjects

* [ACS-5088] Upgraded eslint version to 8.41.0. Added "@angular-eslint/template/no-call-expression" rule to prevent function calls in templates unless needed (reports warnings)

* [ACS-5088] Resolved typo in ToggleFavoriteComponent
2023-06-06 04:32:19 -04:00
swapnil-verma-gl ac49a4acb5 [ACS-5330] Added clearSelection() in afterEach so that tests unslect rows after they have completed their execution (#3244) 2023-06-01 10:41:28 -04:00
swapnil-verma-gl 27da2b8b72 Added missing DirectiveModule import in standalone LogoutComponent (#3241) 2023-05-31 10:22:02 +01:00
swapnil-verma-gl 9148ccc6a9 [ACA-4679] Added code changes and env variables to enable DownloadPrompt and FileAutoDownload features on ACA (#3127)
* [ACA-4679] Added docker variables, app.config.json.tpl config and additional code for enabling non-responsive file preview download and file auto download features in ACA

* [ACA-4679] Added defaults for downloadPrompt for viewer and fileAutoDownload features. Updated variable names from 'nonResponsiveDialog' to 'downloadPrompt'

* [ACA-4679] Added unit test cases for FileAutoDownloadService

* [ACA-4679] Updated env variable references from NonResponsiveDialog to DownloadPrompt

* [ACA-4679] Added missing licence header on new files

* [ACA-4679] Added env variable configuration for GithubActions jobs

* [ACA-4679] Added env variable configuration for GithubActions jobs

* [ACA-4679] Removed unneeded env variable configuration for GithubActions jobs

* [ACA-4679] Updated .env file configuration in README.md
2023-04-20 18:14:13 -04:00
swapnil-verma-gl ce29b36605 [ACS-4259] Updated CSS rules for DateTimePicker (#2986)
* Updated CSS rules for DateTimePicker to show which date is currently focused on when navigating using the keyboard.

* [ACS-4259] Added variables for CSS colors

* [ACS-4259] Updated CSS color variable names to be more generic and not include the colors themselves.

* [ACS-4259] Added CSS variables for white background used in datetimepicker cell background

* [ACS-4259] Resolved typo

* [ACS-4259] Added CSS variables for datetimepicker cell selected background color and cell focus background color
2023-02-17 12:10:35 -05:00