[ACA-3527] Add check to activeFilters update (#5817)

* [ACA-3527] Add check to activeFilters update

* [ACA-3527] Add unit test
This commit is contained in:
Baptiste Mahé 2020-06-25 18:08:50 +02:00 committed by GitHub
parent bd074c83e1
commit 0fcff58c04
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 29 additions and 1 deletions

View File

@ -175,4 +175,30 @@ describe('SearchHeaderQueryBuilder', () => {
'Filters are not as expected'
);
});
it('should not add duplicate column names in activeFilters', () => {
const activeFilter = 'FakeColumn';
const config: SearchConfiguration = {
categories: [
<any> { id: 'cat1', enabled: true }
],
filterQueries: [
{ query: 'PARENT:"workspace://SpacesStore/fake-node-id' }
]
};
const searchHeaderService = new SearchHeaderQueryBuilderService(
buildConfig(config),
null,
null
);
expect(searchHeaderService.activeFilters.length).toBe(0);
searchHeaderService.setActiveFilter(activeFilter);
searchHeaderService.setActiveFilter(activeFilter);
expect(searchHeaderService.activeFilters.length).toBe(1);
});
});

View File

@ -54,7 +54,9 @@ export class SearchHeaderQueryBuilderService extends BaseQueryBuilderService {
}
setActiveFilter(columnActivated: string) {
this.activeFilters.push(columnActivated);
if (!this.activeFilters.includes(columnActivated)) {
this.activeFilters.push(columnActivated);
}
}
isNoFilterActive(): boolean {