inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

[AAE-485] Fix card view int item validator when value is empty (#5205)

Browse Source 
* [AAE-485] Fix card view int item validator when value is empty

* Avoid creating a function every time we validate number

* Add return type to method
This commit is contained in:
davidcanonieto
2019-11-08 14:06:22 +00:00
committed by Eugenio Romano
parent f0ac4b19ad
commit 2a76b0846d
3 changed files with 11 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
lib/core/card-view/components/card-view-textitem/card-view-textitem.component.html
View File

@@ -59,7 +59,6 @@
<button mat-icon-button class="adf-textitem-action" (click)="update()"
[attr.aria-label]="'CORE.METADATA.ACTIONS.SAVE' | translate"
[attr.title]="'CORE.METADATA.ACTIONS.SAVE' | translate"
[disabled]="hasErrors()"
[attr.data-automation-id]="'card-textitem-update-' + property.key">
<mat-icon class="adf-textitem-icon">done</mat-icon>

4
lib/core/card-view/validators/card-view-item-float.validator.ts
View File

@@ -22,6 +22,8 @@ export class CardViewItemFloatValidator implements CardViewItemValidator {
message = 'CORE.CARDVIEW.VALIDATORS.FLOAT_VALIDATION_ERROR';
isValid(value: any): boolean {
return !isNaN(parseFloat(value)) && isFinite(value);
return value === ''
|| !isNaN(parseFloat(value))
&& isFinite(value);
}
}

9
lib/core/card-view/validators/card-view-item-int.validator.ts
View File

@@ -22,6 +22,13 @@ export class CardViewItemIntValidator implements CardViewItemValidator {
message = 'CORE.CARDVIEW.VALIDATORS.INT_VALIDATION_ERROR';
isValid(value: any): boolean {
return !isNaN(value) && (function(x) { return (x | 0) === x; })(parseFloat(value));
return value === ''
|| !isNaN(value)
&& this.isIntegerNumber(value);
}
isIntegerNumber(value: any): boolean {
const parsedNumber = parseFloat(value);
return (parsedNumber | 0) === parsedNumber;
}
}