fix: incorrect angular attributes in search components (#9479)

This commit is contained in:
Denys Vuika
2024-03-27 10:25:58 -04:00
committed by GitHub
parent 97a2d98c3b
commit 3dff1e0091
4 changed files with 12 additions and 16 deletions

View File

@@ -1,11 +1,11 @@
<mat-chip [attr.data-automation-id]="'search-filter-chip-tabbed-' + tabbedFacet.label" <mat-chip [attr.data-automation-id]="'search-filter-chip-tabbed-' + tabbedFacet.label"
disableRipple [disableRipple]="true"
class="adf-search-filter-chip-tabbed" class="adf-search-filter-chip-tabbed"
[class.adf-search-toggle-chip]="displayValue || menuTrigger.menuOpen" [class.adf-search-toggle-chip]="displayValue || menuTrigger.menuOpen"
[disabled]="!isPopulated" [disabled]="!isPopulated"
tabIndex="0" [tabIndex]="0"
[matMenuTriggerFor]="menu" [matMenuTriggerFor]="menu"
(onMenuOpen)="onMenuOpen()" (menuOpened)="onMenuOpen()"
(keydown.enter)="onEnterKeydown()" (keydown.enter)="onEnterKeydown()"
(keydown.escape)="onEscKeydown()" (keydown.escape)="onEscKeydown()"
[attr.title]="displayValue" [attr.title]="displayValue"

View File

@@ -1,9 +1,9 @@
<mat-chip [attr.data-automation-id]="'search-filter-chip-' + field.label" <mat-chip [attr.data-automation-id]="'search-filter-chip-' + field.label"
disableRipple [disableRipple]="true"
class="adf-search-filter-chip adf-search-filter-facet-chip" class="adf-search-filter-chip adf-search-filter-facet-chip"
[class.adf-search-toggle-chip]="(facetField.displayValue$ | async) || menuTrigger.menuOpen" [class.adf-search-toggle-chip]="(facetField.displayValue$ | async) || menuTrigger.menuOpen"
[disabled]="!isPopulated()" [disabled]="!isPopulated()"
tabIndex="0" [tabIndex]="0"
[matMenuTriggerFor]="menu" [matMenuTriggerFor]="menu"
(menuOpened)="onMenuOpen()" (menuOpened)="onMenuOpen()"
(keydown.enter)="onEnterKeydown()" (keydown.enter)="onEnterKeydown()"

View File

@@ -1,8 +1,8 @@
<mat-chip [attr.data-automation-id]="'search-filter-chip-' + category.name" <mat-chip [attr.data-automation-id]="'search-filter-chip-' + category.name"
disableRipple [disableRipple]="true"
class="adf-search-filter-chip" class="adf-search-filter-chip"
[class.adf-search-toggle-chip]="(widget.getDisplayValue() | async) || menuTrigger.menuOpen" [class.adf-search-toggle-chip]="(widget.getDisplayValue() | async) || menuTrigger.menuOpen"
tabIndex="0" [tabIndex]="0"
[matMenuTriggerFor]="menu" [matMenuTriggerFor]="menu"
(menuOpened)="onMenuOpen()" (menuOpened)="onMenuOpen()"
(keydown.enter)="onEnterKeydown()" (keydown.enter)="onEnterKeydown()"

View File

@@ -2,12 +2,11 @@
<ng-container *ngIf="forms.length === 1"> <ng-container *ngIf="forms.length === 1">
<button class="adf-search-form adf-search-form-button" <button class="adf-search-form adf-search-form-button"
[disableRipple] mat-button [disableRipple]="true"
mat-button
[title]="getSelected(forms) | translate" [title]="getSelected(forms) | translate"
[attr.aria-label]="getSelected(forms) | translate"> [attr.aria-label]="getSelected(forms) | translate">
<span class="adf-search-form-title"> <span class="adf-search-form-title">{{ getSelected(forms) | translate }}</span>
{{ getSelected(forms) | translate }}
</span>
</button> </button>
</ng-container> </ng-container>
@@ -15,16 +14,13 @@
<button class="adf-search-form adf-search-form-button" <button class="adf-search-form adf-search-form-button"
[matMenuTriggerFor]="menu" [matMenuTriggerFor]="menu"
#menuTrigger="matMenuTrigger" #menuTrigger="matMenuTrigger"
[disableRipple] [disableRipple]="true"
mat-button mat-button
[title]="getSelected(forms) | translate" [title]="getSelected(forms) | translate"
[attr.aria-label]="getSelected(forms) | translate" [attr.aria-label]="getSelected(forms) | translate"
[matMenuTriggerRestoreFocus]="true"> [matMenuTriggerRestoreFocus]="true">
<span class="adf-search-form-title" > <span class="adf-search-form-title">{{ getSelected(forms) | translate }}</span>
{{ getSelected(forms) | translate }}
</span>
<mat-icon [class.adf-search-form-icon-selected]="menuTrigger.menuOpen" class="adf-search-form-icon">expand_more</mat-icon> <mat-icon [class.adf-search-form-icon-selected]="menuTrigger.menuOpen" class="adf-search-form-icon">expand_more</mat-icon>
</button> </button>