inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix linting

Browse Source
This commit is contained in:
Eugenio Romano
2019-01-15 22:47:28 +00:00
parent df56ce179d
commit 5aec3d4a28
1 changed files with 68 additions and 57 deletions
Download Patch File Download Diff File Expand all files Collapse all files

125
lib/core/datatable/components/datatable/datatable.component.spec.ts
View File

@@ -32,12 +32,15 @@ import { DataColumnComponent } from '../../../data-column/data-column.component'
class FakeDataRow implements DataRow { class FakeDataRow implements DataRow {
isDropTarget = false; isDropTarget = false;
isSelected = true; isSelected = true;
hasValue(key: any) { hasValue(key: any) {
return true; return true;
} }
getValue() { getValue() {
return '1'; return '1';
} }
imageErrorResolver() { imageErrorResolver() {
return './assets/images/ft_ic_miscellaneous.svg'; return './assets/images/ft_ic_miscellaneous.svg';
} }
@@ -467,7 +470,10 @@ describe('DataTable', () => {
done(); done();
}); });
dataTable.onRowClick(rows[0], <any>{ metaKey: true, preventDefault() { } }); dataTable.onRowClick(rows[0], <any> {
metaKey: true, preventDefault() {
}
});
}); });
it('should select multiple rows with [multiple] selection mode and modifier key', (done) => { it('should select multiple rows with [multiple] selection mode and modifier key', (done) => {
@@ -547,7 +553,7 @@ describe('DataTable', () => {
}); });
it('should emit row click event', (done) => { it('should emit row click event', (done) => {
let row = <DataRow>{}; let row = <DataRow> {};
dataTable.rowClick.subscribe((e) => { dataTable.rowClick.subscribe((e) => {
expect(e.value).toBe(row); expect(e.value).toBe(row);
@@ -560,7 +566,7 @@ describe('DataTable', () => {
it('should emit double click if there are two single click in 250ms', (done) => { it('should emit double click if there are two single click in 250ms', (done) => {
let row = <DataRow>{}; let row = <DataRow> {};
dataTable.ngOnChanges({}); dataTable.ngOnChanges({});
dataTable.rowDblClick.subscribe(() => { dataTable.rowDblClick.subscribe(() => {
@@ -569,15 +575,15 @@ describe('DataTable', () => {
dataTable.onRowClick(row, null); dataTable.onRowClick(row, null);
setTimeout(() => { setTimeout(() => {
dataTable.onRowClick(row, null); dataTable.onRowClick(row, null);
} }
, 240); , 240);
}); });
it('should emit double click if there are more than two single click in 250ms', (done) => { it('should emit double click if there are more than two single click in 250ms', (done) => {
let row = <DataRow>{}; let row = <DataRow> {};
dataTable.ngOnChanges({}); dataTable.ngOnChanges({});
dataTable.rowDblClick.subscribe(() => { dataTable.rowDblClick.subscribe(() => {
@@ -587,16 +593,16 @@ describe('DataTable', () => {
dataTable.onRowClick(row, null); dataTable.onRowClick(row, null);
setTimeout(() => { setTimeout(() => {
dataTable.onRowClick(row, null); dataTable.onRowClick(row, null);
dataTable.onRowClick(row, null); dataTable.onRowClick(row, null);
} }
, 240); , 240);
}); });
it('should emit single click if there are two single click in more than 250ms', (done) => { it('should emit single click if there are two single click in more than 250ms', (done) => {
let row = <DataRow>{}; let row = <DataRow> {};
let clickCount = 0; let clickCount = 0;
dataTable.ngOnChanges({}); dataTable.ngOnChanges({});
@@ -610,13 +616,13 @@ describe('DataTable', () => {
dataTable.onRowClick(row, null); dataTable.onRowClick(row, null);
setTimeout(() => { setTimeout(() => {
dataTable.onRowClick(row, null); dataTable.onRowClick(row, null);
} }
, 260); , 260);
}); });
it('should emit row-click dom event', (done) => { it('should emit row-click dom event', (done) => {
let row = <DataRow>{}; let row = <DataRow> {};
fixture.nativeElement.addEventListener('row-click', (e) => { fixture.nativeElement.addEventListener('row-click', (e) => {
expect(e.detail.value).toBe(row); expect(e.detail.value).toBe(row);
@@ -628,7 +634,7 @@ describe('DataTable', () => {
}); });
it('should emit row-dblclick dom event', (done) => { it('should emit row-dblclick dom event', (done) => {
let row = <DataRow>{}; let row = <DataRow> {};
fixture.nativeElement.addEventListener('row-dblclick', (e) => { fixture.nativeElement.addEventListener('row-dblclick', (e) => {
expect(e.detail.value).toBe(row); expect(e.detail.value).toBe(row);
@@ -730,9 +736,9 @@ describe('DataTable', () => {
it('should invert "select all" status', () => { it('should invert "select all" status', () => {
expect(dataTable.isSelectAllChecked).toBeFalsy(); expect(dataTable.isSelectAllChecked).toBeFalsy();
dataTable.onSelectAllClick(<MatCheckboxChange>{ checked: true }); dataTable.onSelectAllClick(<MatCheckboxChange> { checked: true });
expect(dataTable.isSelectAllChecked).toBeTruthy(); expect(dataTable.isSelectAllChecked).toBeTruthy();
dataTable.onSelectAllClick(<MatCheckboxChange>{ checked: false }); dataTable.onSelectAllClick(<MatCheckboxChange> { checked: false });
expect(dataTable.isSelectAllChecked).toBeFalsy(); expect(dataTable.isSelectAllChecked).toBeFalsy();
}); });
@@ -742,7 +748,7 @@ describe('DataTable', () => {
dataTable.data = data; dataTable.data = data;
dataTable.multiselect = true; dataTable.multiselect = true;
dataTable.ngAfterContentInit(); dataTable.ngAfterContentInit();
dataTable.onSelectAllClick(<MatCheckboxChange>{ checked: true }); dataTable.onSelectAllClick(<MatCheckboxChange> {checked: true });
expect(dataTable.selection.every((entry) => entry.isSelected)); expect(dataTable.selection.every((entry) => entry.isSelected));
@@ -760,13 +766,13 @@ describe('DataTable', () => {
dataTable.multiselect = true; dataTable.multiselect = true;
dataTable.ngAfterContentInit(); dataTable.ngAfterContentInit();
dataTable.onSelectAllClick(<MatCheckboxChange>{ checked: true }); dataTable.onSelectAllClick(<MatCheckboxChange> {checked: true });
expect(dataTable.isSelectAllChecked).toBe(true); expect(dataTable.isSelectAllChecked).toBe(true);
for (let i = 0; i < rows.length; i++) { for (let i = 0; i < rows.length; i++) {
expect(rows[i].isSelected).toBe(true); expect(rows[i].isSelected).toBe(true);
} }
dataTable.onSelectAllClick(<MatCheckboxChange>{ checked: false }); dataTable.onSelectAllClick(<MatCheckboxChange> {checked: false });
expect(dataTable.isSelectAllChecked).toBe(false); expect(dataTable.isSelectAllChecked).toBe(false);
for (let i = 0; i < rows.length; i++) { for (let i = 0; i < rows.length; i++) {
expect(rows[i].isSelected).toBe(false); expect(rows[i].isSelected).toBe(false);
@@ -777,7 +783,7 @@ describe('DataTable', () => {
dataTable.multiselect = true; dataTable.multiselect = true;
dataTable.ngOnChanges({ 'data': new SimpleChange('123', {}, true) }); dataTable.ngOnChanges({ 'data': new SimpleChange('123', {}, true) });
dataTable.onSelectAllClick(<MatCheckboxChange>{ checked: true }); dataTable.onSelectAllClick(<MatCheckboxChange> {checked: true });
expect(dataTable.isSelectAllChecked).toBe(true); expect(dataTable.isSelectAllChecked).toBe(true);
}); });
@@ -789,7 +795,7 @@ describe('DataTable', () => {
dataTable.multiselect = false; dataTable.multiselect = false;
dataTable.ngAfterContentInit(); dataTable.ngAfterContentInit();
dataTable.onSelectAllClick(<MatCheckboxChange>{ checked: true }); dataTable.onSelectAllClick(<MatCheckboxChange> {checked: true });
expect(dataTable.isSelectAllChecked).toBe(true); expect(dataTable.isSelectAllChecked).toBe(true);
for (let i = 0; i < rows.length; i++) { for (let i = 0; i < rows.length; i++) {
expect(rows[i].isSelected).toBe(false); expect(rows[i].isSelected).toBe(false);
@@ -798,12 +804,12 @@ describe('DataTable', () => {
it('should require row and column for icon value check', () => { it('should require row and column for icon value check', () => {
expect(dataTable.isIconValue(null, null)).toBeFalsy(); expect(dataTable.isIconValue(null, null)).toBeFalsy();
expect(dataTable.isIconValue(<DataRow>{}, null)).toBeFalsy(); expect(dataTable.isIconValue(<DataRow> {}, null)).toBeFalsy();
expect(dataTable.isIconValue(null, <DataColumn>{})).toBeFalsy(); expect(dataTable.isIconValue(null, <DataColumn> {})).toBeFalsy();
}); });
it('should use special material url scheme', () => { it('should use special material url scheme', () => {
let column = <DataColumn>{}; let column = <DataColumn> {};
let row = { let row = {
getValue: function (key: string) { getValue: function (key: string) {
@@ -811,11 +817,11 @@ describe('DataTable', () => {
} }
}; };
expect(dataTable.isIconValue(<DataRow>row, column)).toBeTruthy(); expect(dataTable.isIconValue(<DataRow> row, column)).toBeTruthy();
}); });
it('should not use special material url scheme', () => { it('should not use special material url scheme', () => {
let column = <DataColumn>{}; let column = <DataColumn> {};
let row = { let row = {
getValue: function (key: string) { getValue: function (key: string) {
@@ -823,11 +829,11 @@ describe('DataTable', () => {
} }
}; };
expect(dataTable.isIconValue(<DataRow>row, column)).toBeFalsy(); expect(dataTable.isIconValue(<DataRow> row, column)).toBeFalsy();
}); });
it('should parse icon value', () => { it('should parse icon value', () => {
let column = <DataColumn>{}; let column = <DataColumn> {};
let row = { let row = {
getValue: function (key: string) { getValue: function (key: string) {
@@ -835,11 +841,11 @@ describe('DataTable', () => {
} }
}; };
expect(dataTable.asIconValue(<DataRow>row, column)).toBe('android'); expect(dataTable.asIconValue(<DataRow> row, column)).toBe('android');
}); });
it('should not parse icon value', () => { it('should not parse icon value', () => {
let column = <DataColumn>{}; let column = <DataColumn> {};
let row = { let row = {
getValue: function (key: string) { getValue: function (key: string) {
@@ -847,7 +853,7 @@ describe('DataTable', () => {
} }
}; };
expect(dataTable.asIconValue(<DataRow>row, column)).toBe(null); expect(dataTable.asIconValue(<DataRow> row, column)).toBe(null);
}); });
it('should parse icon values to a valid i18n key', () => { it('should parse icon values to a valid i18n key', () => {
@@ -858,25 +864,25 @@ describe('DataTable', () => {
it('should require column and direction to evaluate sorting state', () => { it('should require column and direction to evaluate sorting state', () => {
expect(dataTable.isColumnSorted(null, null)).toBeFalsy(); expect(dataTable.isColumnSorted(null, null)).toBeFalsy();
expect(dataTable.isColumnSorted(<DataColumn>{}, null)).toBeFalsy(); expect(dataTable.isColumnSorted(<DataColumn> {}, null)).toBeFalsy();
expect(dataTable.isColumnSorted(null, 'asc')).toBeFalsy(); expect(dataTable.isColumnSorted(null, 'asc')).toBeFalsy();
}); });
it('should require adapter sorting to evaluate sorting state', () => { it('should require adapter sorting to evaluate sorting state', () => {
dataTable.ngOnChanges({ 'data': new SimpleChange('123', {}, true) }); dataTable.ngOnChanges({ 'data': new SimpleChange('123', {}, true) });
spyOn(dataTable.data, 'getSorting').and.returnValue(null); spyOn(dataTable.data, 'getSorting').and.returnValue(null);
expect(dataTable.isColumnSorted(<DataColumn>{}, 'asc')).toBeFalsy(); expect(dataTable.isColumnSorted(<DataColumn> {}, 'asc')).toBeFalsy();
}); });
it('should evaluate column sorting state', () => { it('should evaluate column sorting state', () => {
dataTable.ngOnChanges({ 'data': new SimpleChange('123', {}, true) }); dataTable.ngOnChanges({ 'data': new SimpleChange('123', {}, true) });
spyOn(dataTable.data, 'getSorting').and.returnValue(new DataSorting('column_1', 'asc')); spyOn(dataTable.data, 'getSorting').and.returnValue(new DataSorting('column_1', 'asc'));
expect(dataTable.isColumnSorted(<DataColumn>{ key: 'column_1' }, 'asc')).toBeTruthy(); expect(dataTable.isColumnSorted(<DataColumn> { key: 'column_1' }, 'asc')).toBeTruthy();
expect(dataTable.isColumnSorted(<DataColumn>{ key: 'column_2' }, 'desc')).toBeFalsy(); expect(dataTable.isColumnSorted(<DataColumn> { key: 'column_2' }, 'desc')).toBeFalsy();
}); });
it('should replace image source with fallback thumbnail on error', () => { it('should replace image source with fallback thumbnail on error', () => {
let event = <any>{ let event = <any> {
target: { target: {
src: 'missing-image' src: 'missing-image'
} }
@@ -889,7 +895,7 @@ describe('DataTable', () => {
it('should replace image source with miscellaneous icon when fallback is not available', () => { it('should replace image source with miscellaneous icon when fallback is not available', () => {
const originalSrc = 'missing-image'; const originalSrc = 'missing-image';
let event = <any>{ let event = <any> {
target: { target: {
src: originalSrc src: originalSrc
} }
@@ -901,48 +907,54 @@ describe('DataTable', () => {
}); });
it('should not get cell tooltip when row is not provided', () => { it('should not get cell tooltip when row is not provided', () => {
const col = <DataColumn>{ key: 'name', type: 'text' }; const col = <DataColumn> { key: 'name', type: 'text' };
expect(dataTable.getCellTooltip(null, col)).toBeNull(); expect(dataTable.getCellTooltip(null, col)).toBeNull();
}); });
it('should not get cell tooltip when column is not provided', () => { it('should not get cell tooltip when column is not provided', () => {
const row = <DataRow>{}; const row = <DataRow> {};
expect(dataTable.getCellTooltip(row, null)).toBeNull(); expect(dataTable.getCellTooltip(row, null)).toBeNull();
}); });
it('should not get cell tooltip when formatter is not provided', () => { it('should not get cell tooltip when formatter is not provided', () => {
const col = <DataColumn>{ key: 'name', type: 'text' }; const col = <DataColumn> { key: 'name', type: 'text' };
const row = <DataRow>{}; const row = <DataRow> {};
expect(dataTable.getCellTooltip(row, col)).toBeNull(); expect(dataTable.getCellTooltip(row, col)).toBeNull();
}); });
it('should use formatter function to generate tooltip', () => { it('should use formatter function to generate tooltip', () => {
const tooltip = 'tooltip value'; const tooltip = 'tooltip value';
const col = <DataColumn>{ const col = <DataColumn> {
key: 'name', key: 'name',
type: 'text', type: 'text',
formatTooltip: () => tooltip formatTooltip: () => tooltip
}; };
const row = <DataRow>{}; const row = <DataRow> {};
expect(dataTable.getCellTooltip(row, col)).toBe(tooltip); expect(dataTable.getCellTooltip(row, col)).toBe(tooltip);
}); });
it('should return null value from the tooltip formatter', () => { it('should return null value from the tooltip formatter', () => {
const col = <DataColumn>{ const col = <DataColumn> {
key: 'name', key: 'name',
type: 'text', type: 'text',
formatTooltip: () => null formatTooltip: () => null
}; };
const row = <DataRow>{}; const row = <DataRow> {};
expect(dataTable.getCellTooltip(row, col)).toBeNull(); expect(dataTable.getCellTooltip(row, col)).toBeNull();
}); });
it('should reset the menu cache after rows change', () => { it('should reset the menu cache after rows change', () => {
let emitted = 0; let emitted = 0;
dataTable.showRowActionsMenu.subscribe(() => { emitted++; }); dataTable.showRowActionsMenu.subscribe(() => {
emitted++;
});
const column = <DataColumn>{}; const column = <DataColumn> {};
const row = <DataRow>{ getValue: function (key: string) { return 'id'; } }; const row = <DataRow> {
getValue: function (key: string) {
return 'id';
}
};
dataTable.getRowActions(row, column); dataTable.getRowActions(row, column);
dataTable.ngOnChanges({ 'data': new SimpleChange('123', {}, true) }); dataTable.ngOnChanges({ 'data': new SimpleChange('123', {}, true) });
@@ -952,7 +964,6 @@ describe('DataTable', () => {
}); });
}); });
describe('Accesibility', () => { describe('Accesibility', () => {
let fixture: ComponentFixture<DataTableComponent>; let fixture: ComponentFixture<DataTableComponent>;
@@ -976,7 +987,7 @@ describe('Accesibility', () => {
fixture.destroy(); fixture.destroy();
}); });
it('should have accesibility tags', () => { it('should have accessibility tags', () => {
const dataRows = const dataRows =
[ [
@@ -1001,11 +1012,11 @@ describe('Accesibility', () => {
const datatableBodyRowAttributes = element.querySelector('.adf-datatable-body .adf-datatable-row').attributes; const datatableBodyRowAttributes = element.querySelector('.adf-datatable-body .adf-datatable-row').attributes;
const datatableBodyCellAttributes = element.querySelector('.adf-datatable-body .adf-datatable-table-cell').attributes; const datatableBodyCellAttributes = element.querySelector('.adf-datatable-body .adf-datatable-table-cell').attributes;
expect(datatableAttributes.getNamedItem('role').value).toEqual("grid"); expect(datatableAttributes.getNamedItem('role').value).toEqual('grid');
expect(datatableHeaderAttributes.getNamedItem('role').value).toEqual("rowgroup"); expect(datatableHeaderAttributes.getNamedItem('role').value).toEqual('rowgroup');
expect(datatableHeaderCellAttributes.getNamedItem('role').value).toEqual("columnheader"); expect(datatableHeaderCellAttributes.getNamedItem('role').value).toEqual('columnheader');
expect(datatableBodyAttributes.getNamedItem('role').value).toEqual("rowgroup"); expect(datatableBodyAttributes.getNamedItem('role').value).toEqual('rowgroup');
expect(datatableBodyRowAttributes.getNamedItem('role').value).toEqual("row"); expect(datatableBodyRowAttributes.getNamedItem('role').value).toEqual('row');
expect(datatableBodyCellAttributes.getNamedItem('role').value).toEqual("gridcell"); expect(datatableBodyCellAttributes.getNamedItem('role').value).toEqual('gridcell');
}); });
}) });