[ADF-3873] Implement automated tests for edit process filter cloud (#4118)

* Implement edit process filter tests

* Added tests to edit-process-filters-component.e2e.ts

* Fix lint error

* Rebase

* Fixing a part of the existent tests for edit-process

* no message

* Fixing the tests.

* Fixing edit process filter tests

* Fixing lint errors.

* Remove some waits

* Removed some more waits

* Delete a file that is not used.

* Fix edit process filter tests

* Update editProcessFilterCloudComponent.ts

* Remove checkSpinnerIsDisplayed() check from tests

* Moved clickCustomiseFilterHeader() to beforeEach()
This commit is contained in:
cristinaj 2019-03-04 18:47:58 +02:00 committed by Eugenio Romano
parent b5631b9a7f
commit 64cd91d66d
4 changed files with 314 additions and 32 deletions

View File

@ -301,6 +301,10 @@ export class DataTablePage {
return this;
}
checkSpinnerIsNotDisplayed() {
Util.waitUntilElementIsNotOnPage(this.spinner);
}
checkRowIsDisplayedByName(filename) {
Util.waitUntilElementIsVisible(element.all(by.css(`div[filename="${filename}"]`)).first());
}

View File

@ -15,14 +15,17 @@
* limitations under the License.
*/
import { Util } from '../../../util/util';
import { by, element } from 'protractor';
import { by, element, protractor } from 'protractor';
import { EditProcessFilterDialog } from '../dialog/editProcessFilterDialog';
export class EditProcessFilterCloudComponent {
customiseFilter = element(by.id('adf-edit-process-filter-title-id'));
selectedOption = element(by.css('mat-option[class*="mat-selected"]'));
saveButton = element(by.css('button[id="adf-save-id"]'));
saveAsButton = element(by.css('button[id="adf-save-as-id"]'));
deleteButton = element(by.css('button[id="adf-delete-id"]'));
editProcessFilter = new EditProcessFilterDialog();
@ -36,6 +39,14 @@ export class EditProcessFilterCloudComponent {
return this;
}
checkCustomiseFilterHeaderIsExpanded() {
let expansionPanelExtended = element.all(by.css('mat-expansion-panel-header[class*="mat-expanded"]')).first();
Util.waitUntilElementIsVisible(expansionPanelExtended);
let content = element(by.css('div[class*="mat-expansion-panel-content "][style*="visible"]'));
Util.waitUntilElementIsVisible(content);
return this;
}
setStateFilterDropDown(option) {
this.clickOnDropDownArrow('state');
@ -46,6 +57,10 @@ export class EditProcessFilterCloudComponent {
return this;
}
getStateFilterDropDownValue() {
return element(by.css("mat-form-field[data-automation-id='status'] span")).getText();
}
setSortFilterDropDown(option) {
this.clickOnDropDownArrow('sort');
@ -56,6 +71,12 @@ export class EditProcessFilterCloudComponent {
return this;
}
getSortFilterDropDownValue() {
let sortLocator = element.all(by.css("mat-form-field[data-automation-id='sort'] span")).first();
Util.waitUntilElementIsVisible(sortLocator);
return sortLocator.getText();
}
setOrderFilterDropDown(option) {
this.clickOnDropDownArrow('order');
@ -66,9 +87,14 @@ export class EditProcessFilterCloudComponent {
return this;
}
getOrderFilterDropDownValue() {
return element(by.css("mat-form-field[data-automation-id='order'] span")).getText();
}
clickOnDropDownArrow(option) {
let dropDownArrow = element.all(by.css("mat-form-field[data-automation-id='" + option + "'] div[class*='arrow']")).first();
let dropDownArrow = element.all(by.css("mat-form-field[data-automation-id='" + option + "'] div[class='mat-select-arrow-wrapper']")).first();
Util.waitUntilElementIsVisible(dropDownArrow);
Util.waitUntilElementIsClickable(dropDownArrow);
dropDownArrow.click();
Util.waitUntilElementIsVisible(this.selectedOption);
}
@ -96,10 +122,57 @@ export class EditProcessFilterCloudComponent {
return this;
}
checkSaveButtonIsDisplayed() {
Util.waitUntilElementIsVisible(this.saveButton);
return this;
}
checkSaveAsButtonIsDisplayed() {
Util.waitUntilElementIsVisible(this.saveAsButton);
return this;
}
checkDeleteButtonIsDisplayed() {
Util.waitUntilElementIsVisible(this.deleteButton);
return this;
}
checkSaveButtonIsEnabled() {
Util.waitUntilElementIsVisible(this.saveButton);
return this.saveButton.isEnabled();
}
checkSaveAsButtonIsEnabled() {
Util.waitUntilElementIsVisible(this.saveAsButton);
return this.saveAsButton.isEnabled();
}
checkDeleteButtonIsEnabled() {
Util.waitUntilElementIsVisible(this.deleteButton);
return this.deleteButton.isEnabled();
}
clickSaveAsButton() {
let disabledButton = element(by.css(("button[id='adf-save-as-id'][disabled]")));
Util.waitUntilElementIsClickable(this.saveAsButton);
Util.waitUntilElementIsVisible(this.saveAsButton);
Util.waitUntilElementIsNotVisible(disabledButton);
this.saveAsButton.click();
return this.editProcessFilter;
}
clickDeleteButton() {
Util.waitUntilElementIsVisible(this.deleteButton);
this.deleteButton.click();
return this;
}
clickSaveButton() {
let disabledButton = element(by.css(("button[id='adf-save-as-id'][disabled]")));
Util.waitUntilElementIsClickable(this.saveButton);
Util.waitUntilElementIsVisible(this.saveButton);
Util.waitUntilElementIsNotVisible(disabledButton);
this.saveButton.click();
return this;
}
}

View File

@ -0,0 +1,205 @@
/*!
* @license
* Copyright 2019 Alfresco Software, Ltd.
*
* Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
import TestConfig = require('../test.config');
import { LoginSSOPage } from '../pages/adf/loginSSOPage';
import { SettingsPage } from '../pages/adf/settingsPage';
import { NavigationBarPage } from '../pages/adf/navigationBarPage';
import { TasksCloudDemoPage } from '../pages/adf/demo-shell/process-services/tasksCloudDemoPage';
import { ProcessCloudDemoPage } from '../pages/adf/demo-shell/process-services/processCloudDemoPage';
import { AppListCloudComponent } from '../pages/adf/process-cloud/appListCloudComponent';
describe('Edit process filters cloud', () => {
describe('Edit process Filters', () => {
const settingsPage = new SettingsPage();
const loginSSOPage = new LoginSSOPage();
const navigationBarPage = new NavigationBarPage();
let appListCloudComponent = new AppListCloudComponent();
let tasksCloudDemoPage = new TasksCloudDemoPage();
let processCloudDemoPage = new ProcessCloudDemoPage();
let silentLogin;
const simpleApp = 'simple-app';
beforeAll(async () => {
silentLogin = false;
settingsPage.setProviderBpmSso(TestConfig.adf.hostBPM, TestConfig.adf.hostSso, TestConfig.adf.hostIdentity, silentLogin);
loginSSOPage.clickOnSSOButton();
loginSSOPage.loginAPS(TestConfig.adf.adminEmail, TestConfig.adf.adminPassword);
});
beforeEach((done) => {
navigationBarPage.navigateToProcessServicesCloudPage();
appListCloudComponent.checkApsContainer();
appListCloudComponent.goToApp(simpleApp);
tasksCloudDemoPage.taskListCloudComponent().checkTaskListIsLoaded();
processCloudDemoPage.clickOnProcessFilters();
processCloudDemoPage.editProcessFilterCloudComponent().clickCustomiseFilterHeader().checkCustomiseFilterHeaderIsExpanded();
done();
});
afterEach((done) => {
processCloudDemoPage.allProcessesFilter().clickProcessFilter();
done();
});
it('[C291804] Delete Save and Save as actions should be displayed when clicking on custom filter header', () => {
processCloudDemoPage.allProcessesFilter().clickProcessFilter();
processCloudDemoPage.allProcessesFilter().checkProcessFilterIsDisplayed();
expect(processCloudDemoPage.getActiveFilterName()).toBe('All Processes');
processCloudDemoPage.editProcessFilterCloudComponent().checkSaveButtonIsDisplayed().checkSaveAsButtonIsDisplayed()
.checkDeleteButtonIsDisplayed();
expect(processCloudDemoPage.editProcessFilterCloudComponent().checkSaveButtonIsEnabled()).toEqual(false);
expect(processCloudDemoPage.editProcessFilterCloudComponent().checkSaveAsButtonIsEnabled()).toEqual(false);
expect(processCloudDemoPage.editProcessFilterCloudComponent().checkDeleteButtonIsEnabled()).toEqual(true);
processCloudDemoPage.editProcessFilterCloudComponent().clickCustomiseFilterHeader();
});
it('[C291805] New process filter is added when clicking Save As button', () => {
processCloudDemoPage.allProcessesFilter().clickProcessFilter();
processCloudDemoPage.editProcessFilterCloudComponent().setSortFilterDropDown('ID');
processCloudDemoPage.allProcessesFilter().checkProcessFilterIsDisplayed();
processCloudDemoPage.editProcessFilterCloudComponent().clickSaveAsButton();
processCloudDemoPage.editProcessFilterCloudComponent().editProcessFilterDialog().setFilterName('New').clickOnSaveButton();
expect(processCloudDemoPage.getActiveFilterName()).toBe('New');
processCloudDemoPage.editProcessFilterCloudComponent().clickCustomiseFilterHeader();
expect(processCloudDemoPage.editProcessFilterCloudComponent().checkSaveButtonIsEnabled()).toEqual(false);
expect(processCloudDemoPage.editProcessFilterCloudComponent().getSortFilterDropDownValue()).toEqual('ID');
expect(processCloudDemoPage.editProcessFilterCloudComponent().checkSaveAsButtonIsEnabled()).toEqual(false);
expect(processCloudDemoPage.editProcessFilterCloudComponent().checkDeleteButtonIsEnabled()).toEqual(true);
processCloudDemoPage.allProcessesFilter().clickProcessFilter();
expect(processCloudDemoPage.editProcessFilterCloudComponent().getSortFilterDropDownValue()).toEqual('START DATE');
processCloudDemoPage.customProcessFilter('custom-new').clickProcessFilter();
expect(processCloudDemoPage.editProcessFilterCloudComponent().getSortFilterDropDownValue()).toEqual('ID');
processCloudDemoPage.editProcessFilterCloudComponent().clickDeleteButton();
});
it('[C291806] Two process filters with same name can be created when clicking the Save As button', () => {
processCloudDemoPage.allProcessesFilter().clickProcessFilter();
processCloudDemoPage.editProcessFilterCloudComponent().setSortFilterDropDown('ID');
processCloudDemoPage.editProcessFilterCloudComponent().clickSaveAsButton();
processCloudDemoPage.editProcessFilterCloudComponent().editProcessFilterDialog().setFilterName('New').clickOnSaveButton();
processCloudDemoPage.editProcessFilterCloudComponent().clickCustomiseFilterHeader().checkCustomiseFilterHeaderIsExpanded();
expect(processCloudDemoPage.getActiveFilterName()).toBe('New');
expect(processCloudDemoPage.editProcessFilterCloudComponent().getSortFilterDropDownValue()).toEqual('ID');
processCloudDemoPage.editProcessFilterCloudComponent().setSortFilterDropDown('NAME');
expect(processCloudDemoPage.editProcessFilterCloudComponent().getSortFilterDropDownValue()).toEqual('NAME');
processCloudDemoPage.editProcessFilterCloudComponent().clickSaveAsButton().setFilterName('New').clickOnSaveButton();
processCloudDemoPage.editProcessFilterCloudComponent().clickCustomiseFilterHeader().checkCustomiseFilterHeaderIsExpanded();
expect(processCloudDemoPage.getActiveFilterName()).toBe('New');
expect(processCloudDemoPage.editProcessFilterCloudComponent().getSortFilterDropDownValue()).toEqual('NAME');
processCloudDemoPage.editProcessFilterCloudComponent().clickDeleteButton();
processCloudDemoPage.customProcessFilter('custom-new').clickProcessFilter();
processCloudDemoPage.editProcessFilterCloudComponent().clickCustomiseFilterHeader().checkCustomiseFilterHeaderIsExpanded();
expect(processCloudDemoPage.editProcessFilterCloudComponent().getSortFilterDropDownValue()).toEqual('ID');
processCloudDemoPage.editProcessFilterCloudComponent().clickDeleteButton();
});
it('[C291807] A process filter is overrided when clicking on save button', () => {
processCloudDemoPage.allProcessesFilter().clickProcessFilter();
processCloudDemoPage.editProcessFilterCloudComponent().setSortFilterDropDown('ID');
processCloudDemoPage.allProcessesFilter().checkProcessFilterIsDisplayed();
processCloudDemoPage.editProcessFilterCloudComponent().clickSaveAsButton();
processCloudDemoPage.editProcessFilterCloudComponent().editProcessFilterDialog().setFilterName('New').clickOnSaveButton();
expect(processCloudDemoPage.getActiveFilterName()).toBe('New');
processCloudDemoPage.editProcessFilterCloudComponent().clickCustomiseFilterHeader().checkCustomiseFilterHeaderIsExpanded();
expect(processCloudDemoPage.editProcessFilterCloudComponent().getSortFilterDropDownValue()).toEqual('ID');
processCloudDemoPage.editProcessFilterCloudComponent().setSortFilterDropDown('NAME');
expect(processCloudDemoPage.editProcessFilterCloudComponent().getSortFilterDropDownValue()).toEqual('NAME');
processCloudDemoPage.editProcessFilterCloudComponent().clickSaveButton();
processCloudDemoPage.editProcessFilterCloudComponent().clickCustomiseFilterHeader().checkCustomiseFilterHeaderIsExpanded();
expect(processCloudDemoPage.getActiveFilterName()).toBe('New');
expect(processCloudDemoPage.editProcessFilterCloudComponent().getSortFilterDropDownValue()).toEqual('NAME');
processCloudDemoPage.editProcessFilterCloudComponent().clickDeleteButton();
});
it('[C291808] A process filter is deleted when clicking on delete button', () => {
processCloudDemoPage.allProcessesFilter().clickProcessFilter();
processCloudDemoPage.editProcessFilterCloudComponent().setSortFilterDropDown('ID');
processCloudDemoPage.allProcessesFilter().checkProcessFilterIsDisplayed();
processCloudDemoPage.editProcessFilterCloudComponent().clickSaveAsButton();
processCloudDemoPage.editProcessFilterCloudComponent().editProcessFilterDialog().setFilterName('New').clickOnSaveButton();
processCloudDemoPage.editProcessFilterCloudComponent().clickCustomiseFilterHeader();
expect(processCloudDemoPage.getActiveFilterName()).toBe('New');
expect(processCloudDemoPage.editProcessFilterCloudComponent().getSortFilterDropDownValue()).toEqual('ID');
processCloudDemoPage.editProcessFilterCloudComponent().clickDeleteButton();
expect(processCloudDemoPage.getActiveFilterName()).toBe('All Processes');
processCloudDemoPage.customProcessFilter('New').checkProcessFilterNotDisplayed();
});
it('[C291810] Process filter should not be created when process filter dialog is closed', () => {
processCloudDemoPage.allProcessesFilter().clickProcessFilter();
processCloudDemoPage.editProcessFilterCloudComponent().setSortFilterDropDown('ID');
processCloudDemoPage.allProcessesFilter().checkProcessFilterIsDisplayed();
processCloudDemoPage.editProcessFilterCloudComponent().clickSaveAsButton();
processCloudDemoPage.editProcessFilterCloudComponent().editProcessFilterDialog().setFilterName('Cancel');
expect(processCloudDemoPage.editProcessFilterCloudComponent().editProcessFilterDialog().getFilterName()).toEqual('Cancel');
processCloudDemoPage.editProcessFilterCloudComponent().editProcessFilterDialog().clickOnCancelButton();
processCloudDemoPage.customProcessFilter('Cancel').checkProcessFilterNotDisplayed();
expect(processCloudDemoPage.getActiveFilterName()).toEqual('All Processes');
processCloudDemoPage.runningProcessesFilter().clickProcessFilter();
expect(processCloudDemoPage.getActiveFilterName()).toEqual('Running Processes');
processCloudDemoPage.editProcessFilterCloudComponent().clickCustomiseFilterHeader();
processCloudDemoPage.allProcessesFilter().clickProcessFilter();
expect(processCloudDemoPage.getActiveFilterName()).toEqual('All Processes');
expect(processCloudDemoPage.editProcessFilterCloudComponent().getSortFilterDropDownValue()).toEqual('START DATE');
processCloudDemoPage.editProcessFilterCloudComponent().clickCustomiseFilterHeader();
});
it('[C291811] Save button of process filter dialog should be disabled when process name is empty', () => {
processCloudDemoPage.allProcessesFilter().clickProcessFilter();
processCloudDemoPage.editProcessFilterCloudComponent().setSortFilterDropDown('ID');
processCloudDemoPage.allProcessesFilter().checkProcessFilterIsDisplayed();
processCloudDemoPage.editProcessFilterCloudComponent().clickSaveAsButton();
processCloudDemoPage.editProcessFilterCloudComponent().editProcessFilterDialog().clearFilterName();
expect(processCloudDemoPage.editProcessFilterCloudComponent().editProcessFilterDialog().getFilterName()).toEqual('');
expect(processCloudDemoPage.editProcessFilterCloudComponent().editProcessFilterDialog().checkSaveButtonIsEnabled()).toEqual(false);
expect(processCloudDemoPage.editProcessFilterCloudComponent().editProcessFilterDialog().checkCancelButtonIsEnabled()).toEqual(true);
processCloudDemoPage.editProcessFilterCloudComponent().editProcessFilterDialog().clickOnCancelButton();
processCloudDemoPage.editProcessFilterCloudComponent().clickCustomiseFilterHeader().checkCustomiseFilterHeaderIsExpanded();
processCloudDemoPage.editProcessFilterCloudComponent().setSortFilterDropDown('START DATE');
expect(processCloudDemoPage.editProcessFilterCloudComponent().getSortFilterDropDownValue()).toEqual('START DATE');
processCloudDemoPage.editProcessFilterCloudComponent().clickSaveButton();
});
it('[C291809] Process filter dialog is displayed when clicking on Save As button', () => {
processCloudDemoPage.allProcessesFilter().clickProcessFilter();
processCloudDemoPage.editProcessFilterCloudComponent().setSortFilterDropDown('NAME');
processCloudDemoPage.allProcessesFilter().checkProcessFilterIsDisplayed();
processCloudDemoPage.editProcessFilterCloudComponent().clickSaveAsButton();
expect(processCloudDemoPage.editProcessFilterCloudComponent().editProcessFilterDialog().checkCancelButtonIsEnabled()).toEqual(true);
expect(processCloudDemoPage.editProcessFilterCloudComponent().editProcessFilterDialog().checkSaveButtonIsEnabled()).toEqual(true);
expect(processCloudDemoPage.editProcessFilterCloudComponent().editProcessFilterDialog().getTitle()).toEqual('Save filter as');
expect(processCloudDemoPage.editProcessFilterCloudComponent().editProcessFilterDialog().getFilterName()).toEqual('All Processes');
processCloudDemoPage.editProcessFilterCloudComponent().editProcessFilterDialog().clickOnCancelButton();
});
});
});

View File

@ -21,26 +21,26 @@
</mat-expansion-panel-header>
<form [formGroup]="editProcessFilterForm">
<div fxLayout="row wrap" fxLayout.xs="column" fxLayoutGap="10px" fxLayoutAlign="start center">
<ng-container *ngFor="let processFilterProperty of processFilterProperties">
<mat-form-field fxFlex="23%" *ngIf="isSelectType(processFilterProperty)" [attr.data-automation-id]="processFilterProperty.key">
<mat-select
placeholder="{{processFilterProperty.label | translate}}"
[formControlName]="processFilterProperty.key"
[attr.data-automation-id]="'adf-cloud-edit-process-property-' + processFilterProperty.key">
<mat-option *ngFor="let propertyOption of processFilterProperty.options" [value]="propertyOption.value" [attr.data-automation-id]="'adf-cloud-edit-process-property-options' + processFilterProperty.key">
{{ propertyOption.label }}
</mat-option>
</mat-select>
</mat-form-field>
<mat-form-field fxFlex="23%" *ngIf="isTextType(processFilterProperty)" [attr.data-automation-id]="processFilterProperty.key">
<input matInput
[formControlName]="processFilterProperty.key"
type="text"
placeholder="{{processFilterProperty.label | translate}}"
[attr.data-automation-id]="'adf-cloud-edit-process-property-' + processFilterProperty.key"/>
</mat-form-field>
<mat-form-field fxFlex="23%" *ngIf="isDateType(processFilterProperty)" [attr.data-automation-id]="processFilterProperty.key">
<mat-label>{{processFilterProperty.label | translate}}</mat-label>
<ng-container *ngFor="let processFilterProperty of processFilterProperties">
<mat-form-field fxFlex="23%" *ngIf="isSelectType(processFilterProperty)" [attr.data-automation-id]="processFilterProperty.key">
<mat-select
placeholder="{{processFilterProperty.label | translate}}"
[formControlName]="processFilterProperty.key"
[attr.data-automation-id]="'adf-cloud-edit-process-property-' + processFilterProperty.key">
<mat-option *ngFor="let propertyOption of processFilterProperty.options" [value]="propertyOption.value" [attr.data-automation-id]="'adf-cloud-edit-process-property-options' + processFilterProperty.key">
{{ propertyOption.label }}
</mat-option>
</mat-select>
</mat-form-field>
<mat-form-field fxFlex="23%" *ngIf="isTextType(processFilterProperty)" [attr.data-automation-id]="processFilterProperty.key">
<input matInput
[formControlName]="processFilterProperty.key"
type="text"
placeholder="{{processFilterProperty.label | translate}}"
[attr.data-automation-id]="'adf-cloud-edit-process-property-' + processFilterProperty.key"/>
</mat-form-field>
<mat-form-field fxFlex="23%" *ngIf="isDateType(processFilterProperty)" [attr.data-automation-id]="processFilterProperty.key">
<mat-label>{{processFilterProperty.label | translate}}</mat-label>
<input
matInput
(keyup)="onDateChanged($event.srcElement.value, processFilterProperty)"
@ -49,17 +49,17 @@
placeholder="{{processFilterProperty.label | translate}}"
[formControlName]="processFilterProperty.key"
[attr.data-automation-id]="'adf-cloud-edit-process-property-' + processFilterProperty.key">
<mat-datepicker-toggle matSuffix [for]="dateController" [attr.data-automation-id]="'adf-cloud-edit-process-property-date-toggle' + processFilterProperty.key"></mat-datepicker-toggle>
<mat-datepicker #dateController [attr.data-automation-id]="'adf-cloud-edit-process-property-date-picker' + processFilterProperty.key"></mat-datepicker>
<div class="adf-edit-process-filter-date-error-container">
<div *ngIf="hasError(processFilterProperty)">
<div class="adf-error-text">{{'ADF_CLOUD_EDIT_PROCESS_FILTER.ERROR.DATE' | translate}}</div>
<mat-icon class="adf-error-icon">warning</mat-icon>
<mat-datepicker-toggle matSuffix [for]="dateController" [attr.data-automation-id]="'adf-cloud-edit-process-property-date-toggle' + processFilterProperty.key"></mat-datepicker-toggle>
<mat-datepicker #dateController [attr.data-automation-id]="'adf-cloud-edit-process-property-date-picker' + processFilterProperty.key"></mat-datepicker>
<div class="adf-edit-process-filter-date-error-container">
<div *ngIf="hasError(processFilterProperty)">
<div class="adf-error-text">{{'ADF_CLOUD_EDIT_PROCESS_FILTER.ERROR.DATE' | translate}}</div>
<mat-icon class="adf-error-icon">warning</mat-icon>
</div>
</div>
</div>
</mat-form-field>
</ng-container>
</div>
</mat-form-field>
</ng-container>
</div>
</form>
</mat-expansion-panel>
</mat-accordion>