inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-05-12 17:04:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACS-5831] Added Generic Error to Library Dialog. (#9005)

Browse Source 
* [ACS-5831] Added Generic Error to Library Dialogue.

* format fix

* format fix

* [ci:force]
This commit is contained in:
Aayush Rohila 2023-10-18 18:50:31 +05:30 committed by GitHub
parent 678df4298d
commit d500bc67d7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 29 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
lib/content-services/src/lib/dialogs/library/library.dialog.spec.ts
View File

@ -25,12 +25,14 @@ import { of, throwError } from 'rxjs';
import { delay } from 'rxjs/operators';
import { SiteEntry } from '@alfresco/js-api';
import { SitesService } from '../../common/services/sites.service';
import { NotificationService } from '@alfresco/adf-core';
describe('LibraryDialogComponent', () => {
let fixture: ComponentFixture<LibraryDialogComponent>;
let component: LibraryDialogComponent;
let sitesService: SitesService;
let findSitesSpy;
let notificationService: NotificationService;
const findSitesResponse = { list: { entries: [] } };
const dialogRef = {
close: jasmine.createSpy('close')
@ -51,6 +53,7 @@ describe('LibraryDialogComponent', () => {
component = fixture.componentInstance;
sitesService = TestBed.inject(SitesService);
findSitesSpy = spyOn(component['queriesApi'], 'findSites');
notificationService = TestBed.inject(NotificationService);
});
afterEach(() => {
@ -205,6 +208,26 @@ describe('LibraryDialogComponent', () => {
});
}));
it('should handle default errors and show generic error in snackbar', fakeAsync(() => {
findSitesSpy.and.returnValue(Promise.resolve(findSitesResponse));
const error = {};
spyOn(sitesService, 'createSite').and.callFake(() => throwError(error));
spyOn(sitesService, 'getSite').and.callFake(() => throwError('error'));
spyOn(notificationService, 'showError').and.callThrough();
fixture.detectChanges();
component.form.controls.title.setValue('test');
tick(500);
flush();
fixture.detectChanges();
component.submit();
fixture.detectChanges();
flush();
expect(notificationService.showError).toHaveBeenCalledWith('CORE.MESSAGES.ERRORS.GENERIC');
}));
it('should not translate library title if value is not a valid id', fakeAsync(() => {
findSitesSpy.and.returnValue(Promise.resolve(findSitesResponse));
spyOn(sitesService, 'getSite').and.callFake(() => throwError('error'));

8
lib/content-services/src/lib/dialogs/library/library.dialog.ts
View File

@ -33,7 +33,7 @@ import {
} from '@angular/forms';
import { MatDialogRef } from '@angular/material/dialog';
import { QueriesApi, SiteBodyCreate, SiteEntry, SitePaging } from '@alfresco/js-api';
import { AlfrescoApiService } from '@alfresco/adf-core';
import { AlfrescoApiService, NotificationService } from '@alfresco/adf-core';
import { debounceTime, finalize, mergeMap, takeUntil } from 'rxjs/operators';
import { SitesService } from '../../common/services/sites.service';
@ -84,7 +84,8 @@ export class LibraryDialogComponent implements OnInit, OnDestroy {
private alfrescoApiService: AlfrescoApiService,
private sitesService: SitesService,
private formBuilder: UntypedFormBuilder,
private dialog: MatDialogRef<LibraryDialogComponent>
private dialog: MatDialogRef<LibraryDialogComponent>,
private notificationService: NotificationService
) {
}
@ -198,6 +199,8 @@ export class LibraryDialogComponent implements OnInit, OnDestroy {
}
private handleError(error: any): any {
let errorMessage = 'CORE.MESSAGES.ERRORS.GENERIC';
try {
const {
error: { statusCode }
@ -209,6 +212,7 @@ export class LibraryDialogComponent implements OnInit, OnDestroy {
});
}
} catch {
this.notificationService.showError(errorMessage);
}
return error;