[ACS-5575] Should use declaration-no-important rule in the stylelint-config.json file to avoid use of !important in ADF (#9302)

This commit is contained in:
jacekpluta
2024-03-11 15:33:09 +01:00
committed by GitHub
parent 6bc532abf2
commit e9dc55bca2
80 changed files with 533 additions and 565 deletions

View File

@@ -12,7 +12,7 @@
<mat-icon class="adf-app-listgrid-item-card-logo-icon">{{ getIcon() }}</mat-icon>
</div>
<div mat-card-title class="adf-app-listgrid-item-card-title">
<h1>{{applicationInstance.name}}</h1>
<h1 class="adf-app-listgrid-item-card-title-text">{{applicationInstance.name}}</h1>
</div>
<mat-card-subtitle class="adf-app-listgrid-item-card-subtitle">
<div class="adf-line-clamp">{{applicationInstance.description}}</div>

View File

@@ -2,7 +2,7 @@
@mixin adf-line-clamp($line-height: 1.25, $lines: 3) {
position: relative;
line-height: $line-height;
padding: 0 !important;
padding: 0;
overflow: hidden;
text-overflow: ellipsis;
@@ -39,7 +39,7 @@ adf-cloud-app-details {
padding: 8px;
display: block;
&-item {
.adf-app-listgrid-item {
outline: none;
padding: 8px;
box-sizing: border-box;
@@ -65,7 +65,7 @@ adf-cloud-app-details {
flex-direction: column;
box-sizing: border-box;
display: flex;
padding: 0 !important;
padding: 0;
max-width: unset;
&:hover {
@@ -84,16 +84,16 @@ adf-cloud-app-details {
padding: 16px;
z-index: 9;
&-icon {
.adf-app-listgrid-item-card-logo-icon {
font-size: 70px;
width: 1em !important;
height: 1em !important;
width: 1em;
height: 1em;
}
}
&-title {
&-title:has(.adf-app-listgrid-item-card-title-text) {
padding: 16px;
margin-bottom: 0 !important;
margin-bottom: 0;
z-index: 9999;
h1 {
@@ -108,7 +108,7 @@ adf-cloud-app-details {
}
}
&-subtitle {
&-subtitle:has(.adf-line-clamp) {
color: white;
z-index: 9999;
padding: 16px;
@@ -120,7 +120,7 @@ adf-cloud-app-details {
}
&-actions {
padding: 0 16px 16px !important;
padding: 0 16px 16px;
border-top: 1px solid rgba(0, 0, 0, 0.1);
min-height: 48px;
box-sizing: border-box;

View File

@@ -62,7 +62,7 @@
</h4>
</mat-card-title>
</mat-card-header>
<mat-card-content>
<mat-card-content class="adf-form-container-card-content">
<adf-form-renderer [formDefinition]="form">
</adf-form-renderer>
</mat-card-content>

View File

@@ -1,5 +1,5 @@
<div class="adf-file-properties-table">
<table mat-table [dataSource]="uploadedFiles" class="mat-elevation-z0" *ngIf="hasFile">
<div class="adf-file-properties-table-container">
<table mat-table [dataSource]="uploadedFiles" class="adf-properties-table adf-file-properties-table mat-elevation-z0" *ngIf="hasFile">
<ng-container matColumnDef="icon">
<th mat-header-cell *matHeaderCellDef></th>
<td mat-cell class="adf-file-properties-table-cell" *matCellDef="let element">

View File

@@ -1,5 +1,5 @@
.adf-file-properties-table {
table {
.adf-file-properties-table-container {
.adf-file-properties-table.adf-properties-table table {
width: 100%;
border: 1px solid var(--adf-theme-foreground-text-color-007);
box-shadow: none;
@@ -22,7 +22,7 @@
th {
font-weight: bold;
padding-right: 0 !important;
padding-right: 0;
}
td {
@@ -30,12 +30,12 @@
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
padding-right: 0 !important;
padding-right: 0;
}
td.adf-file-properties-table-cell:first-of-type,
td.adf-file-properties-table-cell:last-of-type {
width: 18% !important;
width: 18%;
}
}
}

View File

@@ -4,7 +4,7 @@
margin-top: 13px;
.adf-select {
padding-top: 0 !important;
padding-top: 0;
width: 100%;
}
@@ -16,12 +16,14 @@
width: 100%;
}
&-dropdown-required-message .adf-error-container {
margin-top: 1px !important;
&-dropdown-required-message {
.adf-error-container {
margin-top: 1px;
}
}
&-dropdown-failed-message .adf-error-container {
margin-top: 1px !important;
margin-top: 1px;
}
}
}

View File

@@ -1,11 +1,4 @@
.adf {
&-group-short-name {
background: var(--theme-primary-color);
width: 40px;
height: 40px;
box-shadow: none !important;
}
&-cloud-group-list {
margin: 5px 0;
padding: 10px 0;
@@ -17,6 +10,10 @@
.adf-group-short-name {
margin-right: 20px;
background: var(--theme-primary-color);
width: 40px;
height: 40px;
box-shadow: none;
}
}
}
@@ -37,7 +34,7 @@
}
&-option-not-active:not(&:active) {
background: inherit !important;
background: inherit;
color: var(--adf-group-cloud-autosuggest-result-disabled-color);
}

View File

@@ -2,8 +2,9 @@
&-people-cloud {
width: 100%;
&-option-not-active {
background: inherit !important;
&-option-not-active:not(&:active) {
background: inherit;
color: var(--adf-group-cloud-autosuggest-result-disabled-color);
}
&-title {

View File

@@ -34,14 +34,14 @@
}
&-form-container {
.adf-form-container-card {
box-shadow: none !important;
padding: 0 !important;
.adf-form-container-card:has(.adf-form-container-card-content) {
box-shadow: none;
padding: 0;
}
}
&-start-form-actions {
text-align: right !important;
text-align: right;
}
&-loading {

View File

@@ -3,6 +3,7 @@
.editorjs {
&.readonly {
.codex-editor__redactor {
/* stylelint-disable declaration-no-important */
padding-bottom: 0 !important;
}
}

View File

@@ -94,7 +94,7 @@
type="button"
(click)="onCancel()"
id="button-cancel">
{{'ADF_CLOUD_TASK_LIST.START_TASK.FORM.ACTION.CANCEL'|translate}}
{{'ADF_CLOUD_TASK_LIST.START_TASK.FORM.ACTION.CANCEL' | translate | uppercase}}
</button>
<button
color="primary"
@@ -103,7 +103,7 @@
mat-button
class="adf-cloud-start-task-footer-button"
id="button-start">
{{'ADF_CLOUD_TASK_LIST.START_TASK.FORM.ACTION.START'|translate}}
{{'ADF_CLOUD_TASK_LIST.START_TASK.FORM.ACTION.START' | translate | uppercase}}
</button>
</div>
</mat-card-actions>

View File

@@ -52,12 +52,6 @@
adf-cloud-start-task {
.adf {
&-cloud-start-task-footer {
.adf-cloud-start-task-footer-button {
text-transform: uppercase !important;
}
}
&-task-name {
display: flex;

View File

@@ -1,4 +1,4 @@
<div *ngIf="!loading; else loadingTemplate">
<div class="adf-task-form-cloud-container" *ngIf="!loading; else loadingTemplate">
<adf-cloud-form #adfCloudForm *ngIf="hasForm(); else withoutForm"
[appName]="appName"
[appVersion]="taskDetails.appVersion"

View File

@@ -1,23 +1,25 @@
.adf-task-form {
&-container {
overflow: hidden;
}
.adf-task-form-cloud-container {
.adf-task-form {
&-container {
overflow: hidden;
&-actions {
float: right;
padding-bottom: 25px !important;
padding-right: 25px !important;
.adf-task-form-actions:has(button) {
float: right;
padding-bottom: 25px;
padding-right: 25px;
& .adf-task-form-actions-button {
height: 36px;
border-radius: 5px;
& .adf-task-form-actions-button {
height: 36px;
border-radius: 5px;
span {
width: 58px;
height: 20px;
opacity: 0.54;
font-size: var(--theme-body-2-font-size);
font-weight: bold;
span {
width: 58px;
height: 20px;
opacity: 0.54;
font-size: var(--theme-body-2-font-size);
font-weight: bold;
}
}
}
}
}
@@ -30,10 +32,10 @@
}
adf-cloud-task-form {
.adf-task-form-spinner {
display: flex !important;
justify-content: center !important;
align-items: center !important;
.adf-task-form-cloud-spinner {
display: flex;
justify-content: center;
align-items: center;
position: absolute;
top: 50%;
left: 50%;