inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-31 17:38:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix "ng lint" command (#5012)

Browse Source 
* update to latest js-api

* fix the "ng lint" command

* fix linting issues

* fix lint issues

* lint fixes

* code fixes

* fix html

* fix html

* update tests

* test fixes

* update tests

* fix tests and api

* fix code
This commit is contained in:
Denys Vuika
2019-08-29 16:35:30 +01:00
committed by Eugenio Romano
parent 140c64b79f
commit edc0945f39
162 changed files with 537 additions and 530 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
e2e/actions/drop.actions.ts
View File

@@ -24,7 +24,7 @@ const JS_BIND_INPUT = function(target) {
const input = document.createElement('input');
input.type = 'file';
input.style.display = 'none';
input.addEventListener('change', function(event) {
input.addEventListener('change', function() {
target.scrollIntoView(true);
const rect = target.getBoundingClientRect();
@@ -52,7 +52,7 @@ const JS_BIND_INPUT_FOLDER = function(target) {
input.style.display = 'none';
input.multiple = true;
input.webkitdirectory = true;
input.addEventListener('change', function(event) {
input.addEventListener('change', function() {
target.scrollIntoView(true);
const rect = target.getBoundingClientRect();

8
e2e/content-services/comments/comment-component.e2e.ts
View File

@@ -118,7 +118,7 @@ describe('Comment Component', () => {
await viewerPage.clickOnCommentsTab();
await commentsPage.addComment(comments.first);
await commentsPage.checkUserIconIsDisplayed(0);
await commentsPage.checkUserIconIsDisplayed();
await expect(await commentsPage.getTotalNumberOfComments()).toEqual('Comments (1)');
await expect(await commentsPage.getMessage(0)).toEqual(comments.first);
@@ -134,7 +134,7 @@ describe('Comment Component', () => {
await viewerPage.clickOnCommentsTab();
await commentsPage.addComment(comments.multiline);
await commentsPage.checkUserIconIsDisplayed(0);
await commentsPage.checkUserIconIsDisplayed();
await expect(await commentsPage.getTotalNumberOfComments()).toEqual('Comments (1)');
await expect(await commentsPage.getMessage(0)).toEqual(comments.multiline);
@@ -142,7 +142,7 @@ describe('Comment Component', () => {
await expect(await commentsPage.getTime(0)).toMatch(/(ago|few)/);
await commentsPage.addComment(comments.second);
await commentsPage.checkUserIconIsDisplayed(0);
await commentsPage.checkUserIconIsDisplayed();
await expect(await commentsPage.getTotalNumberOfComments()).toEqual('Comments (2)');
await expect(await commentsPage.getMessage(0)).toEqual(comments.second);
@@ -158,7 +158,7 @@ describe('Comment Component', () => {
await viewerPage.clickOnCommentsTab();
await commentsPage.addComment(comments.codeType);
await commentsPage.checkUserIconIsDisplayed(0);
await commentsPage.checkUserIconIsDisplayed();
await expect(await commentsPage.getTotalNumberOfComments()).toEqual('Comments (1)');
await expect(await commentsPage.getMessage(0)).toEqual('First name: Last name:');

2
e2e/pages/adf/commentsPage.ts
View File

@@ -35,7 +35,7 @@ export class CommentsPage {
return BrowserActions.getText(this.numberOfComments);
}
async checkUserIconIsDisplayed(position): Promise<void> {
async checkUserIconIsDisplayed(): Promise<void> {
await BrowserVisibility.waitUntilElementIsVisible(this.commentUserIcon.first());
}

2
e2e/pages/adf/process-services/startProcessPage.ts
View File

@@ -48,7 +48,7 @@ export class StartProcessPage {
return this.defaultProcessName.getAttribute('value');
}
async deleteDefaultName(name) {
async deleteDefaultName() {
await BrowserVisibility.waitUntilElementIsVisible(this.processNameInput);
await BrowserActions.clearWithBackSpace(this.processNameInput);
}

4
e2e/process-services/comment-component-processes.e2e.ts
View File

@@ -81,7 +81,7 @@ describe('Comment component for Processes', () => {
addedComment = await this.alfrescoJsApi.activiti.commentsApi.getProcessInstanceComments(processInstanceId, { 'latestFirst': true });
await commentsPage.checkUserIconIsDisplayed(0);
await commentsPage.checkUserIconIsDisplayed();
await expect(await commentsPage.getTotalNumberOfComments()).toEqual('Comments (' + addedComment.total + ')');
await expect(await commentsPage.getMessage(0)).toEqual(addedComment.data[0].message);
@@ -119,7 +119,7 @@ describe('Comment component for Processes', () => {
const addedTaskComment = await this.alfrescoJsApi.activiti.commentsApi.getProcessInstanceComments(processInstanceId, { 'latestFirst': true });
await commentsPage.checkUserIconIsDisplayed(0);
await commentsPage.checkUserIconIsDisplayed();
await expect(await commentsPage.getTotalNumberOfComments()).toEqual('Comments (' + addedTaskComment.total + ')');
await expect(await commentsPage.getMessage(0)).toEqual(addedTaskComment.data[0].message);

10
e2e/process-services/comment-component-tasks.e2e.ts
View File

@@ -119,8 +119,8 @@ describe('Comment component for Processes', () => {
const thirdTaskComment = { message: 'Third Task Comment' };
await commentsPage.checkUserIconIsDisplayed(0);
await commentsPage.checkUserIconIsDisplayed(1);
await commentsPage.checkUserIconIsDisplayed();
await commentsPage.checkUserIconIsDisplayed();
await expect(await commentsPage.getTotalNumberOfComments()).toEqual('Comments (' + totalCommentsLatest.total + ')');
@@ -145,9 +145,9 @@ describe('Comment component for Processes', () => {
const totalComments = await this.alfrescoJsApi.activiti.taskApi.getTaskComments(newTaskId, { 'latestFirst': true });
await commentsPage.checkUserIconIsDisplayed(0);
await commentsPage.checkUserIconIsDisplayed(1);
await commentsPage.checkUserIconIsDisplayed(2);
await commentsPage.checkUserIconIsDisplayed();
await commentsPage.checkUserIconIsDisplayed();
await commentsPage.checkUserIconIsDisplayed();
await expect(await commentsPage.getTotalNumberOfComments()).toEqual('Comments (' + totalComments.total + ')');

2
e2e/process-services/start-process-component.e2e.ts
View File

@@ -163,7 +163,7 @@ describe('Start Process Component', () => {
await processFiltersPage.clickNewProcessDropdown();
await startProcessPage.selectFromProcessDropdown(processModelWithoutSe);
await startProcessPage.deleteDefaultName('My Default Name');
await startProcessPage.deleteDefaultName();
await browser.sleep(1000);