inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-31 17:38:48 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix "ng lint" command (#5012)

Browse Source 
* update to latest js-api

* fix the "ng lint" command

* fix linting issues

* fix lint issues

* lint fixes

* code fixes

* fix html

* fix html

* update tests

* test fixes

* update tests

* fix tests and api

* fix code
This commit is contained in:
Denys Vuika
2019-08-29 16:35:30 +01:00
committed by Eugenio Romano
parent 140c64b79f
commit edc0945f39
162 changed files with 537 additions and 530 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
lib/core/viewer/components/pdfViewer-thumb.component.ts
View File

@@ -39,8 +39,7 @@ export class PdfThumbComponent implements OnInit {
private getThumb(page): Promise<string> {
const viewport = page.getViewport(1);
const pageRatio = viewport.width / viewport.height;
const canvas = this.getCanvas(pageRatio);
const canvas = this.getCanvas();
const scale = Math.min((canvas.height / viewport.height), (canvas.width / viewport.width));
return page.render({
@@ -53,7 +52,7 @@ export class PdfThumbComponent implements OnInit {
});
}
private getCanvas(pageRatio): HTMLCanvasElement {
private getCanvas(): HTMLCanvasElement {
const canvas = document.createElement('canvas');
canvas.width = this.page.getWidth();
canvas.height = this.page.getHeight();

2
lib/core/viewer/components/pdfViewer-thumbnails.component.spec.ts
View File

@@ -47,7 +47,7 @@ describe('PdfThumbListComponent', () => {
return this._currentPageNumber;
},
pdfDocument: {
getPage: (pageNum) => Promise.resolve({
getPage: () => Promise.resolve({
getViewport: () => ({ height: 421, width: 335 }),
render: jasmine.createSpy('render').and.returnValue(Promise.resolve())
})

6
lib/core/viewer/components/pdfViewer-thumbnails.component.ts
View File

@@ -43,8 +43,8 @@ export class PdfThumbListComponent implements OnInit, AfterViewInit, OnDestroy {
@ContentChild(TemplateRef)
template: any;
@HostListener('window:resize', ['$event'])
onResize(event) {
@HostListener('window:resize')
onResize() {
this.calculateItems();
}
@@ -74,7 +74,7 @@ export class PdfThumbListComponent implements OnInit, AfterViewInit, OnDestroy {
this.pdfViewer.eventBus.off('pagechange', this.onPageChange);
}
trackByFn(index: number, item: any): number {
trackByFn(_: number, item: any): number {
return item.id;
}

2
lib/core/viewer/components/pdfViewer.component.spec.ts
View File

@@ -336,7 +336,7 @@ describe('Test PdfViewer component', () => {
fixtureUrlTestPasswordComponent = TestBed.createComponent(UrlTestPasswordComponent);
componentUrlTestPasswordComponent = fixtureUrlTestPasswordComponent.componentInstance;
spyOn(dialog, 'open').and.callFake((comp, context) => {
spyOn(dialog, 'open').and.callFake((_, context) => {
if (context.data.reason === pdfjsLib.PasswordResponses.NEED_PASSWORD) {
return {
afterClosed: () => of('wrong_password')

2
lib/core/viewer/components/pdfViewer.component.ts
View File

@@ -487,7 +487,7 @@ export class PdfViewerComponent implements OnChanges, OnDestroy {
*
* @param event
*/
onPagesLoaded(event) {
onPagesLoaded() {
this.isPanelDisabled = false;
}

60
lib/core/viewer/components/viewer.component.spec.ts
View File

@@ -170,7 +170,7 @@ describe('ViewerComponent', () => {
it('should extension file pdf be loaded', (done) => {
component.urlFile = 'fake-test-file.pdf';
component.ngOnChanges(null);
component.ngOnChanges();
fixture.detectChanges();
fixture.whenStable().then(() => {
@@ -182,7 +182,7 @@ describe('ViewerComponent', () => {
it('should extension file png be loaded', (done) => {
component.urlFile = 'fake-url-file.png';
component.ngOnChanges(null);
component.ngOnChanges();
fixture.detectChanges();
fixture.whenStable().then(() => {
@@ -194,7 +194,7 @@ describe('ViewerComponent', () => {
it('should extension file mp4 be loaded', (done) => {
component.urlFile = 'fake-url-file.mp4';
component.ngOnChanges(null);
component.ngOnChanges();
fixture.detectChanges();
fixture.whenStable().then(() => {
@@ -206,7 +206,7 @@ describe('ViewerComponent', () => {
it('should extension file txt be loaded', (done) => {
component.urlFile = 'fake-test-file.txt';
component.ngOnChanges(null);
component.ngOnChanges();
fixture.detectChanges();
fixture.whenStable().then(() => {
@@ -219,7 +219,7 @@ describe('ViewerComponent', () => {
it('should display [unknown format] for unsupported extensions', (done) => {
component.urlFile = 'fake-url-file.unsupported';
component.mimeType = '';
component.ngOnChanges(null);
component.ngOnChanges();
fixture.detectChanges();
fixture.whenStable().then(() => {
@@ -240,7 +240,7 @@ describe('ViewerComponent', () => {
component.urlFile = 'fake-content-img';
component.mimeType = 'image/png';
fixture.detectChanges();
component.ngOnChanges(null);
component.ngOnChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
@@ -253,7 +253,7 @@ describe('ViewerComponent', () => {
component.urlFile = 'fake-content-img.bin';
component.mimeType = 'image/png';
fixture.detectChanges();
component.ngOnChanges(null);
component.ngOnChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
@@ -266,7 +266,7 @@ describe('ViewerComponent', () => {
component.urlFile = 'fake-content-txt.bin';
component.mimeType = 'text/plain';
fixture.detectChanges();
component.ngOnChanges(null);
component.ngOnChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
@@ -292,7 +292,7 @@ describe('ViewerComponent', () => {
component.displayName = null;
spyOn(alfrescoApiService, 'getInstance').and.returnValue(alfrescoApiInstanceMock);
component.ngOnChanges(null);
component.ngOnChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
expect(element.querySelector('adf-viewer-unknown-format')).toBeDefined();
@@ -304,7 +304,7 @@ describe('ViewerComponent', () => {
component.urlFile = 'fake-content-video.bin';
component.mimeType = 'video/mp4';
fixture.detectChanges();
component.ngOnChanges(null);
component.ngOnChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
@@ -317,7 +317,7 @@ describe('ViewerComponent', () => {
component.urlFile = 'fake-content-video';
component.mimeType = 'video/mp4';
fixture.detectChanges();
component.ngOnChanges(null);
component.ngOnChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
@@ -330,7 +330,7 @@ describe('ViewerComponent', () => {
component.urlFile = 'fake-content-pdf';
component.mimeType = 'application/pdf';
fixture.detectChanges();
component.ngOnChanges(null);
component.ngOnChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
@@ -343,7 +343,7 @@ describe('ViewerComponent', () => {
it('should display a PDF file identified by mimetype when the file extension is wrong', (done) => {
component.urlFile = 'fake-content-pdf.bin';
component.mimeType = 'application/pdf';
component.ngOnChanges(null);
component.ngOnChanges();
fixture.detectChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
@@ -366,13 +366,13 @@ describe('ViewerComponent', () => {
component.showViewer = true;
component.nodeId = 'id1';
component.ngOnChanges({});
component.ngOnChanges();
tick();
expect(component.fileTitle).toBe('file1');
component.nodeId = 'id2';
component.ngOnChanges({});
component.ngOnChanges();
tick();
expect(component.fileTitle).toBe('file2');
@@ -601,7 +601,7 @@ describe('ViewerComponent', () => {
};
spyOn(alfrescoApiService, 'getInstance').and.returnValue(alfrescoApiInstanceMock);
component.ngOnChanges(null);
component.ngOnChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
expect(component.nodeEntry).toBe(node);
@@ -642,7 +642,7 @@ describe('ViewerComponent', () => {
component.urlFile = null;
component.mimeType = null;
component.ngOnChanges(null);
component.ngOnChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
expect(element.querySelector('[data-automation-id="adf-toolbar-back"]')).toBeNull();
@@ -666,7 +666,7 @@ describe('ViewerComponent', () => {
});
it('should Name File be present if is overlay mode ', (done) => {
component.ngOnChanges(null);
component.ngOnChanges();
fixture.detectChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
@@ -733,7 +733,7 @@ describe('ViewerComponent', () => {
component.urlFile = undefined;
expect(() => {
component.ngOnChanges(null);
component.ngOnChanges();
}).toThrow();
});
@@ -743,7 +743,7 @@ describe('ViewerComponent', () => {
component.urlFile = undefined;
expect(() => {
component.ngOnChanges(null);
component.ngOnChanges();
}).not.toThrow();
});
@@ -752,7 +752,7 @@ describe('ViewerComponent', () => {
component.nodeId = undefined;
expect(() => {
component.ngOnChanges(null);
component.ngOnChanges();
}).not.toThrow();
});
@@ -778,7 +778,7 @@ describe('ViewerComponent', () => {
component.urlFile = null;
component.mimeType = null;
component.ngOnChanges(null);
component.ngOnChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
expect(element.querySelector('adf-viewer-unknown-format')).not.toBeNull();
@@ -794,7 +794,7 @@ describe('ViewerComponent', () => {
component.urlFile = null;
component.mimeType = null;
component.ngOnChanges(null);
component.ngOnChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
expect(element.querySelector('adf-viewer-unknown-format')).not.toBeNull();
@@ -815,7 +815,7 @@ describe('ViewerComponent', () => {
component.urlFile = null;
component.mimeType = null;
component.ngOnChanges(null);
component.ngOnChanges();
});
});
@@ -831,7 +831,7 @@ describe('ViewerComponent', () => {
component.urlFile = 'fake-url-file.png';
component.ngOnChanges(null);
component.ngOnChanges();
});
});
@@ -841,7 +841,7 @@ describe('ViewerComponent', () => {
component.urlFile = 'fake-test-file.pdf';
component.displayName = 'test name';
fixture.detectChanges();
component.ngOnChanges(null);
component.ngOnChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
@@ -854,7 +854,7 @@ describe('ViewerComponent', () => {
component.urlFile = 'fake-test-file.pdf';
component.displayName = null;
fixture.detectChanges();
component.ngOnChanges(null);
component.ngOnChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
@@ -870,7 +870,7 @@ describe('ViewerComponent', () => {
component.displayName = 'blob file display name';
component.blobFile = new Blob(['This is my blob content'], { type: 'text/plain' });
fixture.detectChanges();
component.ngOnChanges(null);
component.ngOnChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
@@ -883,7 +883,7 @@ describe('ViewerComponent', () => {
component.displayName = null;
component.blobFile = new Blob(['This is my blob content'], { type: 'text/plain' });
fixture.detectChanges();
component.ngOnChanges(null);
component.ngOnChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
@@ -911,7 +911,7 @@ describe('ViewerComponent', () => {
component.displayName = null;
spyOn(alfrescoApiService, 'getInstance').and.returnValue(alfrescoApiInstanceMock);
component.ngOnChanges(null);
component.ngOnChanges();
fixture.whenStable().then(() => {
fixture.detectChanges();
expect(element.querySelector('#adf-viewer-display-name').textContent).toEqual(displayName);

6
lib/core/viewer/components/viewer.component.ts
View File

@@ -17,7 +17,7 @@
import {
Component, ContentChild, EventEmitter, HostListener, ElementRef,
Input, OnChanges, Output, SimpleChanges, TemplateRef,
Input, OnChanges, Output, TemplateRef,
ViewEncapsulation, OnInit, OnDestroy
} from '@angular/core';
import { RenditionPaging, SharedLinkEntry, Node, RenditionEntry, NodeEntry } from '@alfresco/js-api';
@@ -278,7 +278,7 @@ export class ViewerComponent implements OnChanges, OnInit, OnDestroy {
}
}
ngOnChanges(changes: SimpleChanges) {
ngOnChanges() {
if (this.showViewer) {
if (!this.isSourceDefined()) {
throw new Error('A content source attribute value is missing.');
@@ -299,7 +299,7 @@ export class ViewerComponent implements OnChanges, OnInit, OnDestroy {
this.isLoading = false;
});
},
(error) => {
() => {
this.isLoading = false;
this.logService.error('This node does not exist');
}