inteligr8/alfresco-ng2-components
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-ng2-components.git synced 2025-07-24 17:32:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix "ng lint" command (#5012)

Browse Source 
* update to latest js-api

* fix the "ng lint" command

* fix linting issues

* fix lint issues

* lint fixes

* code fixes

* fix html

* fix html

* update tests

* test fixes

* update tests

* fix tests and api

* fix code
This commit is contained in:
Denys Vuika
2019-08-29 16:35:30 +01:00
committed by Eugenio Romano
parent 140c64b79f
commit edc0945f39
162 changed files with 537 additions and 530 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/insights/analytics-process/components/analytics-report-list.component.ts
View File

@@ -77,7 +77,7 @@ export class AnalyticsReportListComponent implements OnInit {
/**
* Reload the component
*/
reload(reportId?) {
reload(reportId?: number) {
this.reset();
this.getReportList(this.appId, reportId);
}
@@ -85,7 +85,7 @@ export class AnalyticsReportListComponent implements OnInit {
/**
* Get the report list
*/
getReportList(appId: number, reportId?: string) {
getReportList(appId: number, reportId?: number) {
this.analyticsService.getReportList(appId).subscribe(
(res: ReportParametersModel[]) => {
if (res && res.length === 0) {
@@ -152,7 +152,7 @@ export class AnalyticsReportListComponent implements OnInit {
this.reportClick.emit(report);
}
public selectReportByReportId(reportId) {
public selectReportByReportId(reportId: number) {
const reportFound = this.reports.find((report) => report.id === reportId);
if (reportFound) {
this.currentReport = reportFound;

2
lib/insights/analytics-process/components/analytics-report-parameters.component.spec.ts
View File

@@ -316,7 +316,7 @@ describe('AnalyticsReportParametersComponent', () => {
});
it('Should create an empty valid form when there are no parameters definitions', () => {
component.success.subscribe((res) => {
component.success.subscribe(() => {
expect(component.reportForm).toBeDefined();
expect(component.reportForm.valid).toEqual(true);
expect(component.reportForm.controls).toEqual({});

4
lib/insights/analytics-process/components/analytics-report-parameters.component.ts
View File

@@ -199,7 +199,7 @@ export class AnalyticsReportParametersComponent implements OnInit, OnChanges, On
});
this.reportForm = this.formBuilder.group(formBuilderGroup);
this.reportForm.valueChanges.subscribe((data) => this.onValueChanged(data));
this.reportForm.statusChanges.subscribe((data) => this.onStatusChanged(data));
this.reportForm.statusChanges.subscribe(() => this.onStatusChanged());
}
public getReportParams(reportId: string) {
@@ -251,7 +251,7 @@ export class AnalyticsReportParametersComponent implements OnInit, OnChanges, On
}
}
onStatusChanged(status: any) {
onStatusChanged() {
if (this.reportForm && !this.reportForm.pending && this.reportForm.dirty) {
this.formValidState = this.reportForm.valid;
}

4
lib/insights/analytics-process/components/analytics.component.ts
View File

@@ -15,7 +15,7 @@
* limitations under the License.
*/
import { Component, EventEmitter, Input, OnChanges, Output, SimpleChanges, ViewChild, ViewEncapsulation } from '@angular/core';
import { Component, EventEmitter, Input, OnChanges, Output, ViewChild, ViewEncapsulation } from '@angular/core';
import { ReportQuery } from '../../diagram/models/report/reportQuery.model';
import { AnalyticsGeneratorComponent } from './analytics-generator.component';
@@ -50,7 +50,7 @@ export class AnalyticsComponent implements OnChanges {
reportParamQuery: ReportQuery;
ngOnChanges(changes: SimpleChanges) {
ngOnChanges() {
this.analyticsGenerator.reset();
}