inteligr8/alfresco-transform-core
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-transform-core.git synced 2026-09-16 18:12:54 +00:00
Code Issues Packages Projects Releases Wiki Activity

ACS-11995 codeql alerts cleanup (#1290)

Browse Source
This commit is contained in:
tathagta15
2026-06-18 12:14:03 +05:30
committed by GitHub
parent 0641c29b07
commit 7fa5897a87
3 changed files with 10 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
deprecated/alfresco-transformer-base/src/test/java/org/alfresco/transformer/AbstractMetadataExtractsIT.java
+3 -1
View File
@@ -39,6 +39,7 @@ import java.io.File;
import java.io.IOException;
import java.io.InputStream;
import java.io.Serializable;
import java.nio.file.Files;
import java.util.HashMap;
import java.util.Map;
@@ -101,7 +102,8 @@ public abstract class AbstractMetadataExtractsIT
String metadataFilename = sourceFile + "_metadata.json";
Map<String, Serializable> actualMetadata = readMetadata(response.getBody().getInputStream());
File actualMetadataFile = new File(metadataFilename);
File actualMetadataFile = Files.createTempFile(
"actual-" + new File(sourceFile).getName() + "-", ".json").toFile();
jsonObjectMapper.writerWithDefaultPrettyPrinter().writeValue(actualMetadataFile, actualMetadata);
Map<String, Serializable> expectedMetadata = readExpectedMetadata(metadataFilename, actualMetadataFile);
engines/base/src/main/java/org/alfresco/transform/base/executors/RuntimeExec.java
+4 -4
View File
@@ -666,11 +666,11 @@ public class RuntimeExec
for (Map.Entry<String, String> entry : execProperties.entrySet())
{
String key = entry.getKey();
String value = entry.getValue();
// ignore null
if (value == null)
String value = entry.getValue() == null ? "" : entry.getValue();
if (value.contains("\n") || value.contains("\r") || value.contains("\0"))
{
value = "";
throw new IllegalArgumentException(
"Command property '" + key + "' contains an illegal character");
}
// progressively replace the property in the command
key = (VAR_OPEN + key + VAR_CLOSE);
engines/base/src/test/java/org/alfresco/transform/base/metadata/AbstractMetadataExtractsIT.java
+3 -1
View File
@@ -39,6 +39,7 @@ import java.io.File;
import java.io.IOException;
import java.io.InputStream;
import java.io.Serializable;
import java.nio.file.Files;
import java.util.HashMap;
import java.util.Map;
@@ -100,7 +101,8 @@ public abstract class AbstractMetadataExtractsIT
String metadataFilename = sourceFile + "_metadata.json";
Map<String, Serializable> actualMetadata = readMetadata(response.getBody().getInputStream());
File actualMetadataFile = new File(metadataFilename);
File actualMetadataFile = Files.createTempFile(
"actual-" + new File(sourceFile).getName() + "-", ".json").toFile();
jsonObjectMapper.writerWithDefaultPrettyPrinter().writeValue(actualMetadataFile, actualMetadata);
Map<String, Serializable> expectedMetadata = readExpectedMetadata(metadataFilename, actualMetadataFile);