inteligr8/alfresco-content-app
1
0
Fork 0
mirror of https://github.com/Alfresco/alfresco-content-app.git synced 2025-10-01 14:41:14 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ACS-5540] Implemented the review comments

Browse Source
This commit is contained in:
Yasa-Nataliya
2023-09-28 11:19:39 +05:30
parent f400575378
commit 1116dfd3ae
3 changed files with 12 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
projects/aca-content/src/lib/components/details/details.component.scss
View File

@@ -4,7 +4,7 @@ app-details-manager {
.aca-close-details-button {
margin-right: 15px;
margin-top: 2px;
margin-top: 12px;
outline: none;
border-radius: 4px;

30
projects/aca-shared/rules/src/navigation.rules.spec.ts
View File

@@ -226,26 +226,6 @@ describe('navigation.evaluators', () => {
});
describe('isDetails', () => {
it('should return true if url ends with `/details`', () => {
const context: any = {
navigation: {
url: '/path/details'
}
};
expect(app.isDetails(context)).toBe(true);
});
it('should return true if url starts with `/details`', () => {
const context: any = {
navigation: {
url: '/details/path'
}
};
expect(app.isDetails(context)).toBe(true);
});
it('should return true if url includes with `/details`', () => {
const context: any = {
navigation: {
@@ -255,6 +235,16 @@ describe('navigation.evaluators', () => {
expect(app.isDetails(context)).toBe(true);
});
it('should return false if url not includes with `/details`', () => {
const context: any = {
navigation: {
url: '/path'
}
};
expect(app.isDetails(context)).toBe(false);
});
});
describe('isRecentFiles', () => {

2
projects/aca-shared/rules/src/navigation.rules.ts
View File

@@ -112,7 +112,7 @@ export function isLibraryContent(context: RuleContext): boolean {
export function isDetails(context: RuleContext): boolean {
const { url } = context.navigation;
return url && (url.endsWith('/details') || url.includes('/details/') || url.startsWith('/details'));
return url?.includes('/details');
}
/**